A self-improving RLM agent for coding workflows and long-running autonomous tasks.
Rust
advance nightly tag after publishing verified build assets (#3545)
kt0d86d0bf4e8a
diff --git a/.github/workflows/release.yml b/.github/workflows/release.ymlindex bb3fff8fd4..e04c2a0b23 100644--- a/.github/workflows/release.yml+++ b/.github/workflows/release.yml@@ -1258,12 +1258,21 @@ jobs:# bootstrap), so it is validated up front: a tag the strict nightly# regex rejects fails closed here instead of publishing a nightly# that later refreshes refuse to parse.- python3 <<'PY_RELEASE'- import os, re+ built_commit="$(python3 <<'PY_RELEASE'+ import json, os, reversion = os.environ["RELEASE_VERSION"]if not re.fullmatch(r"v[0-9]+\.[0-9]+\.[0-9]+-beta\.[0-9]+", version):raise SystemExit(f"invalid nightly version: {version!r}")+ manifest = json.load(open("release-out/manifest.json"))+ channel = json.load(open("release-out/beta.json"))+ if manifest.get("version") != version or channel.get("version") != version:+ raise SystemExit("nightly payload manifests do not match the release version")+ commit = manifest.get("commit")+ if not isinstance(commit, str) or not re.fullmatch(r"[0-9a-f]{40}", commit):+ raise SystemExit(f"invalid nightly build commit: {commit!r}")+ print(commit)PY_RELEASE+ )"# Only an explicit API 404 permits bootstrap. Authentication, network,# rate-limit, and malformed-response errors must not bypass the guard.state="$(mktemp -d)"@@ -1350,6 +1359,7 @@ jobs:exit 1figh release create nightly \+ --target "$built_commit" \--title "nightly" \--notes "The rolling nightly channel (beta builds). Assets are overwritten per -beta* tag; beta.json names the current build." \--prerelease \@@ -1359,3 +1369,13 @@ jobs:release-out/SHA256SUMS \release-out/*.jsonfi+ # Publish first: a failed or partial asset upload must not advance+ # the source tag. This stays inside the serialized newest-wins guard.+ # The manifest records the verified build source, which can differ+ # from both the version-only tag commit and today's main HEAD.+ gh api "repos/${GH_REPO}/git/refs/tags/nightly" --method PATCH \+ -f sha="$built_commit" -F force=true >/dev/null+ printf 'Current build: %s\n\nSource commit: https://github.com/%s/commit/%s\n\nUpdated: %s\n\nThe rolling nightly channel. beta.json names the current build; older versioned assets may remain.\n' \+ "$RELEASE_VERSION" "$GH_REPO" "$built_commit" "$(date -u +%Y-%m-%dT%H:%M:%SZ)" > "$state/notes.md"+ gh release edit nightly --title "nightly ($RELEASE_VERSION)" \+ --notes-file "$state/notes.md" --prerelease --latest=falsediff --git a/scripts/release/README.md b/scripts/release/README.mdindex 12c6481aaa..dc6348bc42 100644--- a/scripts/release/README.md+++ b/scripts/release/README.md@@ -12,6 +12,12 @@ beta.json, and per-target SPDX SBOMs. Audit files upload before channel pointersadvance, even when a newer main commit has superseded the build. The existingprovenance attestation step continues to cover tarballs and decoders. The rollingnightly release also carries the full current payload and checksums.+After a successful nightly asset publication, the same serialized refresh moves+`refs/tags/nightly` to `manifest.json`'s verified build commit and updates the+release title/notes with the version, source commit, and refresh time. It never+uses a newly read main HEAD. Failed uploads leave the existing tag unchanged;+a failed tag/metadata update fails the job and can be repaired by rerunning the+same version. GitHub's original release publication date is not rewritten.Installers and native/npm updaters keep using the R2 channel manifests andversioned payload paths anonymously; they do not require per-beta GitHub releasediff --git a/scripts/release/test_release_publication.py b/scripts/release/test_release_publication.pyindex a6bb3a1ac1..89b409cb9a 100644--- a/scripts/release/test_release_publication.py+++ b/scripts/release/test_release_publication.py@@ -48,9 +48,22 @@ elif args[:2] == ['release', 'download']:path = pathlib.Path(args[args.index('--dir') + 1]) / 'beta.json'path.write_text(json.dumps({'version': os.environ['CURRENT']}))elif args[:2] in (['release', 'upload'], ['release', 'create']):+ if os.environ.get('FAIL_PUBLISH') == '1': sys.exit(1)+ pathlib.Path('published').write_text('yes')for arg in args:if arg.startswith('release-out/'):assert pathlib.Path(arg).is_file(), arg+elif args[:2] == ['release', 'edit']:+ assert pathlib.Path('published').exists()+ if os.environ.get('FAIL_METADATA') == '1': sys.exit(1)+ pathlib.Path('release-notes').write_text(pathlib.Path(args[args.index('--notes-file') + 1]).read_text())+elif args[0] == 'api' and '--method' in args and args[args.index('--method') + 1] == 'PATCH':+ assert args[1].endswith('/git/refs/tags/nightly')+ assert pathlib.Path('published').exists()+ if os.environ.get('FAIL_TAG') == '1': sys.exit(1)+ sha = next(a.removeprefix('sha=') for a in args if a.startswith('sha='))+ pathlib.Path('nightly-tag').write_text(sha)+ print(json.dumps({'object': {'sha': sha}}))elif args[0] == 'api':if '--include' in args:status = '404 Not Found' if mode == 'absent' else '503 Service Unavailable'@@ -86,10 +99,11 @@ class PublicationTests(unittest.TestCase):path.write_text(script)path.chmod(0o755)self.version = 'v0.10.1-beta.10'+ self.commit = 'a' * 40self.env = dict(os.environ, PATH=f'{self.bin}:{os.environ["PATH"]}',RELEASE_VERSION=self.version, CURRENT='v0.10.1-beta.9',GH_REPO='owner/repo', GITHUB_REPOSITORY='owner/repo',- GITHUB_REF_NAME=self.version, R2_BUCKET='bucket',+ GITHUB_REF_NAME=self.version, GITHUB_SHA='b' * 40, R2_BUCKET='bucket',R2_ENDPOINT_URL='https://invalid.example',R2_PUBLIC_BASE_URL='https://invalid.example')self.out = self.root / 'release-out'@@ -100,6 +114,8 @@ class PublicationTests(unittest.TestCase):'manifest.json', 'beta.json', 'sbom-spdx-linux.json']for name in names:(self.out / name).write_text('{}')+ (self.out / 'manifest.json').write_text(json.dumps({'version': self.version, 'commit': self.commit}))+ (self.out / 'beta.json').write_text(json.dumps({'version': self.version}))self.sums = ''.join(f'{hashlib.sha256(b"{}").hexdigest()} {name}\n'for name in names if name.endswith(('.gz', '.tgz')))(self.out / 'SHA256SUMS').write_text(self.sums)@@ -192,6 +208,78 @@ class PublicationTests(unittest.TestCase):self.assertNotEqual(result.returncode, 0)self.assertEqual(self.mutations(), [])+ def test_tag_and_metadata_follow_the_published_manifest_commit(self):+ result = self.refresh()+ self.assertEqual(result.returncode, 0, result.stderr)+ self.assertEqual((self.root / 'nightly-tag').read_text(), self.commit)+ notes = (self.root / 'release-notes').read_text()+ self.assertIn(self.version, notes)+ self.assertIn(self.commit, notes)+ calls = list(map(json.loads, (self.root / 'calls.jsonl').read_text().splitlines()))+ upload = next(i for i, a in enumerate(calls) if a[:2] == ['release', 'upload'])+ patch = next(i for i, a in enumerate(calls) if a[0] == 'api' and 'PATCH' in a)+ edit = next(i for i, a in enumerate(calls) if a[:2] == ['release', 'edit'])+ self.assertLess(upload, patch)+ self.assertLess(patch, edit)+ self.assertIn('force=true', calls[patch])+ self.assertIn('--latest=false', calls[edit])++ def test_bootstrap_targets_the_manifest_commit(self):+ result = self.refresh(MODE='absent')+ self.assertEqual(result.returncode, 0, result.stderr)+ create = self.mutations()[0]+ self.assertEqual(create[create.index('--target') + 1], self.commit)+ self.assertEqual((self.root / 'nightly-tag').read_text(), self.commit)++ def test_invalid_payload_provenance_never_publishes(self):+ for document in ({'version': self.version},+ {'version': self.version, 'commit': 'main'},+ {'version': self.version, 'commit': 'a' * 39},+ {'version': self.version, 'commit': None},+ {'version': 'v0.10.1-beta.9', 'commit': self.commit}):+ with self.subTest(document=document):+ (self.out / 'manifest.json').write_text(json.dumps(document))+ result = self.refresh()+ self.assertNotEqual(result.returncode, 0)+ self.assertEqual(self.mutations(), [])+ self.assertFalse((self.root / 'nightly-tag').exists())++ def test_mismatched_channel_manifest_never_publishes(self):+ (self.out / 'beta.json').write_text(json.dumps({'version': 'v0.10.1-beta.9'}))+ result = self.refresh()+ self.assertNotEqual(result.returncode, 0)+ self.assertEqual(self.mutations(), [])++ def test_failed_asset_publication_never_advances_tag_or_metadata(self):+ for mode in ('existing', 'absent'):+ with self.subTest(mode=mode):+ result = self.refresh(MODE=mode, FAIL_PUBLISH='1')+ self.assertNotEqual(result.returncode, 0)+ self.assertFalse((self.root / 'nightly-tag').exists())+ self.assertFalse((self.root / 'release-notes').exists())++ def test_failed_tag_update_stops_metadata_and_same_version_retry_repairs_it(self):+ result = self.refresh(FAIL_TAG='1')+ self.assertNotEqual(result.returncode, 0)+ self.assertFalse((self.root / 'release-notes').exists())+ result = self.refresh(CURRENT=self.version)+ self.assertEqual(result.returncode, 0, result.stderr)+ self.assertEqual((self.root / 'nightly-tag').read_text(), self.commit)++ def test_stale_refresh_never_moves_tag_or_metadata(self):+ result = self.refresh(CURRENT='v0.10.1-beta.11')+ self.assertEqual(result.returncode, 0, result.stderr)+ self.assertFalse((self.root / 'nightly-tag').exists())+ self.assertFalse((self.root / 'release-notes').exists())++ def test_metadata_failure_fails_run_and_same_version_retry_repairs_it(self):+ result = self.refresh(FAIL_METADATA='1')+ self.assertNotEqual(result.returncode, 0)+ self.assertEqual((self.root / 'nightly-tag').read_text(), self.commit)+ result = self.refresh(CURRENT=self.version)+ self.assertEqual(result.returncode, 0, result.stderr)+ self.assertIn(self.commit, (self.root / 'release-notes').read_text())+def test_superseded_beta_archives_every_file_without_advancing_pointers(self):result = self.run_step('Publish the R2 channel (the channel serves no GitHub URL)')self.assertEqual(result.returncode, 0, result.stderr)