Skip to content

A self-improving RLM agent for coding workflows and long-running autonomous tasks.

Rust

fix(coding-agent): trust supervisor-approved session renames in worker mode (#1841)

Sebastian Müller90343dca053d
diff --git a/packages/coding-agent/.changes/supervised-rename-authority.md b/packages/coding-agent/.changes/supervised-rename-authority.md
new file mode 100644
index 0000000000..b56a24e5e5
--- /dev/null
+++ b/packages/coding-agent/.changes/supervised-rename-authority.md
@@ -0,0 +1 @@
+- Fixed supervised session renames failing after the supervisor approved an available name.
diff --git a/packages/coding-agent/src/modes/daemon/daemon-mode.ts b/packages/coding-agent/src/modes/daemon/daemon-mode.ts
index 0bda7e5ea5..ce35ab2ca3 100644
--- a/packages/coding-agent/src/modes/daemon/daemon-mode.ts
+++ b/packages/coding-agent/src/modes/daemon/daemon-mode.ts
@@ -3988,7 +3988,7 @@ export class AgentDaemon {
if (!name) {
throw new Error("Session name cannot be empty");
}
- await this.setStateSessionName(state, name);
+ await this.setStateSessionNameForCommand(state, name);
return success(command.id, "rename", summaryForActiveSession(state));
}
@@ -4002,7 +4002,7 @@ export class AgentDaemon {
throw new Error("Session name cannot be empty");
}
if (state) {
- await this.setStateSessionName(state, name);
+ await this.setStateSessionNameForCommand(state, name);
} else {
const info = await readSessionInfo(command.sessionPath);
if (!info) throw new Error(`Session not found: ${command.sessionPath}`);
@@ -4898,7 +4898,7 @@ export class AgentDaemon {
if (!name) {
throw new Error("Session name cannot be empty");
}
- await this.setStateSessionName(state, name);
+ await this.setStateSessionNameForCommand(state, name);
return success(command.id, "set_session_name");
}
@@ -5572,6 +5572,15 @@ export class AgentDaemon {
}
}
+ private setStateSessionNameForCommand(state: ActiveSessionState, name: string): Promise<void> {
+ return this.options.worker ? this.applyStateSessionName(state, name) : this.setStateSessionName(state, name);
+ }
+
+ private async applyStateSessionName(state: ActiveSessionState, name: string): Promise<void> {
+ state.runtime.session.setSessionName(name);
+ await this.appendRlmLedgerRenameForState(state, name);
+ }
+
private async setStateSessionName(state: ActiveSessionState, name: string): Promise<void> {
const normalizedName = name.trim();
if (!normalizedName) {
@@ -5594,8 +5603,7 @@ export class AgentDaemon {
},
async () => {
await this.assertStateSessionNameAvailable(state, normalizedName);
- state.runtime.session.setSessionName(normalizedName);
- await this.appendRlmLedgerRenameForState(state, normalizedName);
+ await this.applyStateSessionName(state, normalizedName);
},
);
}
diff --git a/packages/coding-agent/test/daemon-mode.test.ts b/packages/coding-agent/test/daemon-mode.test.ts
index 8f690b2642..2fe66fde0d 100644
--- a/packages/coding-agent/test/daemon-mode.test.ts
+++ b/packages/coding-agent/test/daemon-mode.test.ts
@@ -97,6 +97,40 @@ describe("daemon mode helpers", () => {
expect(setSessionName).toHaveBeenCalledOnce();
});
+ it("uses a supervisor-approved worker session name without validating it again", async () => {
+ const daemon = new AgentDaemon("/tmp/unused-worker.sock", {
+ defaultSessionConfig: { agentDir: "/tmp", cwd: "/tmp" },
+ createRuntime: vi.fn(),
+ worker: { authenticationToken: "token" },
+ });
+ const setSessionName = vi.fn();
+ const state = makeState("active");
+ state.runtime = {
+ ...state.runtime,
+ session: { setSessionName },
+ } as never;
+ const assertStateSessionNameAvailable = vi.fn(async () => {
+ throw new Error("stale peer name");
+ });
+ const internals = daemon as unknown as {
+ sessions: Map<string, ActiveSessionState>;
+ assertStateSessionNameAvailable: typeof assertStateSessionNameAvailable;
+ handleCommand(client: DaemonSocketClient, command: DaemonCommand): Promise<DaemonOutbound | undefined>;
+ };
+ internals.sessions.set(state.activeSessionId, state);
+ internals.assertStateSessionNameAvailable = assertStateSessionNameAvailable;
+
+ await expect(
+ internals.handleCommand(makeClient("supervisor", state.activeSessionId), {
+ type: "set_session_name",
+ activeSessionId: state.activeSessionId,
+ name: "approved",
+ }),
+ ).resolves.toMatchObject({ success: true });
+ expect(assertStateSessionNameAvailable).not.toHaveBeenCalled();
+ expect(setSessionName).toHaveBeenCalledWith("approved");
+ });
+
it("treats a depth-zero fork as a sibling of another root", () => {
const daemon = new AgentDaemon("/tmp/prime-agent-fork-family.sock", {
defaultSessionConfig: { agentDir: "/tmp", cwd: "/tmp" },