Skip to content

A self-improving RLM agent for coding workflows and long-running autonomous tasks.

Rust

fix onboarding showing no models after entering provider key (#221)

kt97875403661d
diff --git a/packages/coding-agent/src/main.ts b/packages/coding-agent/src/main.ts
index 6ec9ace2dc..98f1b3d62a 100644
--- a/packages/coding-agent/src/main.ts
+++ b/packages/coding-agent/src/main.ts
@@ -1389,7 +1389,7 @@ export async function main(args: string[], options?: MainOptions) {
model: startupModel.model,
thinkingLevel: prepared.sessionOptions.thinkingLevel ?? defaultSessionConfig.thinking ?? "off",
scopedModels: prepared.sessionOptions.scopedModels ?? [],
- availableModels: services.modelRegistry.getAvailable(),
+ availableModels: () => services.modelRegistry.getAvailable(),
steeringMode: settingsManager.getSteeringMode(),
followUpMode: settingsManager.getFollowUpMode(),
autoCompactionEnabled: settingsManager.getCompactionEnabled(),
diff --git a/packages/coding-agent/src/modes/agent-connection/deferred-agent-connection.ts b/packages/coding-agent/src/modes/agent-connection/deferred-agent-connection.ts
index d082787442..37e102c4c7 100644
--- a/packages/coding-agent/src/modes/agent-connection/deferred-agent-connection.ts
+++ b/packages/coding-agent/src/modes/agent-connection/deferred-agent-connection.ts
@@ -47,7 +47,7 @@ export interface DeferredAgentConnectionSeed {
model?: AgentConnectionModel;
thinkingLevel: ThinkingLevel;
scopedModels: AgentConnectionScopedModel[];
- availableModels: AgentConnectionModel[];
+ availableModels: () => AgentConnectionModel[];
steeringMode: AgentConnectionQueueMode;
followUpMode: AgentConnectionQueueMode;
autoCompactionEnabled: boolean;
@@ -237,7 +237,7 @@ export class DeferredAgentConnection implements AgentConnection {
}
async getAvailableModels(): Promise<AgentConnectionModel[]> {
- return this.real ? this.real.getAvailableModels() : this.seed.availableModels;
+ return this.real ? this.real.getAvailableModels() : this.seed.availableModels();
}
async getSessionStats(): Promise<SessionStats> {
diff --git a/packages/coding-agent/src/modes/interactive/components/model-selector.ts b/packages/coding-agent/src/modes/interactive/components/model-selector.ts
index e6a8344ea2..3f274fd154 100644
--- a/packages/coding-agent/src/modes/interactive/components/model-selector.ts
+++ b/packages/coding-agent/src/modes/interactive/components/model-selector.ts
@@ -182,7 +182,10 @@ export class ModelSelectorComponent extends Container implements Focusable {
// Load available models (built-in models still work even if models.json failed)
let availableModels: ReadonlyArray<Model<any>>;
try {
- availableModels = this.availableModels ?? (await this.modelRegistry.getAvailable());
+ // An empty snapshot may predate login; prefer a live query.
+ availableModels = this.availableModels?.length
+ ? this.availableModels
+ : await this.modelRegistry.getAvailable();
models = availableModels.map((model: Model<any>) => ({
provider: model.provider,
id: model.id,
@@ -203,7 +206,9 @@ export class ModelSelectorComponent extends Container implements Focusable {
const scopedModelId = `${scoped.model.provider}/${scoped.model.id}`;
const refreshed =
availableModelsById.get(scopedModelId) ??
- (this.availableModels ? undefined : this.modelRegistry.find(scoped.model.provider, scoped.model.id));
+ (this.availableModels?.length
+ ? undefined
+ : this.modelRegistry.find(scoped.model.provider, scoped.model.id));
return refreshed ? { ...scoped, model: refreshed } : scoped;
});
this.scopedModelItems = this.scopedModels.map((scoped) => ({
diff --git a/packages/coding-agent/test/deferred-agent-connection.test.ts b/packages/coding-agent/test/deferred-agent-connection.test.ts
index 2ceee34b1c..3ade5b8828 100644
--- a/packages/coding-agent/test/deferred-agent-connection.test.ts
+++ b/packages/coding-agent/test/deferred-agent-connection.test.ts
@@ -17,7 +17,7 @@ const SEED: DeferredAgentConnectionSeed = {
model: MODEL,
thinkingLevel: "off",
scopedModels: [],
- availableModels: [MODEL],
+ availableModels: () => [MODEL],
steeringMode: "all",
followUpMode: "all",
autoCompactionEnabled: true,
@@ -84,6 +84,18 @@ describe("DeferredAgentConnection", () => {
expect(conn.created).toBe(false);
});
+ test("re-evaluates availableModels on each read so login during onboarding shows models", async () => {
+ const { factory } = makeFactory();
+ let models: AgentConnectionModel[] = [];
+ const conn = new DeferredAgentConnection(factory, { ...SEED, availableModels: () => models });
+
+ expect(await conn.getAvailableModels()).toEqual([]);
+
+ models = [MODEL];
+ expect(await conn.getAvailableModels()).toEqual([MODEL]);
+ expect(factory).not.toHaveBeenCalled();
+ });
+
test("creates the session on first prompt and delegates", async () => {
const { factory, fake } = makeFactory();
const conn = new DeferredAgentConnection(factory, SEED);