Skip to content

A self-improving RLM agent for coding workflows and long-running autonomous tasks.

Rust

Show opened idle sessions as idle instead of running (#2778)

Sebastian Müllerc4afa57352e7
diff --git a/packages/coding-agent/.changes/activity-misreport.md b/packages/coding-agent/.changes/activity-misreport.md
new file mode 100644
index 0000000000..6188d3c54a
--- /dev/null
+++ b/packages/coding-agent/.changes/activity-misreport.md
@@ -0,0 +1 @@
+- Fixed old sessions showing as running in the agents view as soon as you open them, even though nothing is running: a session now counts as running only while it is doing work, not while its status summary is out of date.
diff --git a/packages/coding-agent/src/modes/daemon/agent-roster.ts b/packages/coding-agent/src/modes/daemon/agent-roster.ts
index d50b907227..6727d586ef 100644
--- a/packages/coding-agent/src/modes/daemon/agent-roster.ts
+++ b/packages/coding-agent/src/modes/daemon/agent-roster.ts
@@ -177,7 +177,7 @@ export function sessionActivityDetail(summary: SessionSummary, options: SessionA
return "replied";
}
if (summary.activity === "working") {
- return "classifying";
+ return "working";
}
if (summary.taskState === "error") {
return "error";
diff --git a/packages/coding-agent/src/modes/daemon/daemon-session-list.ts b/packages/coding-agent/src/modes/daemon/daemon-session-list.ts
index 55f7bc791d..de1a00cb8e 100644
--- a/packages/coding-agent/src/modes/daemon/daemon-session-list.ts
+++ b/packages/coding-agent/src/modes/daemon/daemon-session-list.ts
@@ -20,8 +20,7 @@ export { classifySessionRosterStatus, isSessionSummaryBusy } from "./agent-roste
// reachable only via --resume <selector>.
export type SessionLifecycle = "draft" | "live" | "archived";
-// Heuristic activity of a live session. Classification-in-flight counts as
-// "working" so the view never sees an unlabeled idle session.
+// Activity of a live session: "working" only while the session itself is active.
export type SessionActivity = "working" | "idle";
// Upper bound on the spawn-code source carried in a session summary. Generous
@@ -695,23 +694,9 @@ export function hasLiveSessionWork(activeSession: ActiveSessionState): boolean {
return session.isSessionActive || session.hasRunningRlmChildren();
}
+// The session's own work only; delegated work and the classification verdict don't count.
export function activeActivityForSession(activeSession: ActiveSessionState): SessionActivity {
- // The session's own work only, ignoring the classification verdict.
- if (activeSession.runtime.session.isSessionActive) {
- return "working";
- }
- // A finished subagent is resident but never gets a summarizer verdict, so don't hold
- // it at "working" waiting for one — a not-busy subagent is simply idle/done.
- if (activeSession.runtime.metadata?.kind === "subagent") {
- return "idle";
- }
- // An empty session never gets a summarizer verdict; don't hold it at "working" forever.
- if (activeSession.runtime.session.messages.length === 0) {
- return "idle";
- }
- // Hold at "working" until the idle verdict is current, so the view never
- // buckets an unlabeled idle session.
- return isSummaryCurrent(activeSession) ? "idle" : "working";
+ return activeSession.runtime.session.isSessionActive ? "working" : "idle";
}
/**
diff --git a/packages/coding-agent/src/modes/daemon/daemon-session-summarizer.ts b/packages/coding-agent/src/modes/daemon/daemon-session-summarizer.ts
index 2742e8a0ca..770579adc9 100644
--- a/packages/coding-agent/src/modes/daemon/daemon-session-summarizer.ts
+++ b/packages/coding-agent/src/modes/daemon/daemon-session-summarizer.ts
@@ -203,11 +203,6 @@ export async function generateAgentStatus(params: GenerateAgentStatusParams): Pr
}
}
-function isSessionWorking(state: ActiveSessionState): boolean {
- const session = state.runtime.session;
- return session.isSessionActive;
-}
-
// Recap prefix for a turn that errored; the transcript's own error text follows
// it so the persisted verdict reports the real last event, never invented work.
const ERROR_RECAP_PREFIX = "Model request failed";
@@ -346,7 +341,7 @@ export class DaemonSessionSummarizer {
return;
}
const messageCount = messages.length;
- const isWorking = isSessionWorking(state);
+ const isWorking = session.isSessionActive;
const previous = state.summaryState;
// Idle sessions with a current verdict need no refresh — except a
// transcript whose terminal turn errored (owesErrorVerdict below) —
@@ -423,9 +418,8 @@ export class DaemonSessionSummarizer {
lastFailureAt: Date.now(),
});
}
- // A failed classification on an idle session would spin at "working"
- // forever (the activity axis holds unjudged idle sessions there), so
- // settle it to needs_input.
+ // A failed classification on an idle session settles to needs_input so it
+ // carries a current verdict.
const result =
generated ??
(!isWorking && (owesIdleVerdict || owesSummary)
@@ -439,7 +433,7 @@ export class DaemonSessionSummarizer {
if (
controller.signal.aborted ||
state.runtime.session !== session ||
- isSessionWorking(state) !== isWorking ||
+ session.isSessionActive !== isWorking ||
session.messages.length !== messageCount
) {
return;
@@ -503,8 +497,8 @@ export class DaemonSessionSummarizer {
status: AgentStatus,
{ isWorking, previous, persist }: { isWorking: boolean; previous: AgentStatus | undefined; persist: boolean },
): void {
- // An idle settle refreshes the verdict's currency, which drives the roster's
- // activity axis: it must publish even when the verdict text is unchanged.
+ // An idle settle refreshes the verdict's currency, which gates the published
+ // taskState: it must publish even when the verdict text is unchanged.
const changed =
previous?.summary !== status.summary ||
previous?.taskState !== status.taskState ||
diff --git a/packages/coding-agent/test/daemon-agent-roster.test.ts b/packages/coding-agent/test/daemon-agent-roster.test.ts
index 124413f5f6..523a3fbc03 100644
--- a/packages/coding-agent/test/daemon-agent-roster.test.ts
+++ b/packages/coding-agent/test/daemon-agent-roster.test.ts
@@ -7,6 +7,7 @@ import { SessionManager } from "../src/core/session-manager.js";
import type { ActiveSessionState } from "../src/modes/daemon/active-session-state.js";
import {
type AgentRosterEntry,
+ classifySessionRosterStatus,
type WorkerRosterEntry,
workerRosterEntryFromSummary,
} from "../src/modes/daemon/agent-roster.js";
@@ -400,7 +401,7 @@ describe("worker roster reporter", () => {
expect(daemon.rosterReporter.lastComposed.has("session-root-active")).toBe(false);
});
- it("republishes a finished row as idle once the settled verdict makes the summary current", async () => {
+ it("publishes a settled resident row as idle before its verdict and republishes when the verdict lands", async () => {
const { daemon, sentDeltas } = makeWorkerReporter();
const state = makeState({
activeSessionId: "finished",
@@ -409,7 +410,9 @@ describe("worker roster reporter", () => {
});
daemon.sessions.set("finished", state);
daemon.flushRoster();
- expect(sentDeltas.at(-1)?.entries.map((entry) => entry.summary.activity)).toEqual(["working"]);
+ const published = sentDeltas.at(-1)?.entries[0]?.summary;
+ expect(published?.activity).toBe("idle");
+ expect(classifySessionRosterStatus(published!)).toBe("idle");
(state as unknown as { summaryState?: unknown }).summaryState = {
summary: "Waiting for review",
@@ -419,7 +422,10 @@ describe("worker roster reporter", () => {
daemon.observeRosterEvent(state, { type: "session_status", activeSessionId: "finished" });
await new Promise((resolve) => setImmediate(resolve));
- expect(sentDeltas.at(-1)?.entries.map((entry) => entry.summary.activity)).toEqual(["idle"]);
+ expect(sentDeltas.at(-1)?.entries[0]?.summary).toMatchObject({
+ activity: "idle",
+ taskState: "needs_input",
+ });
});
it("flushes cron and model changes that have no session-event carrier", async () => {
diff --git a/packages/coding-agent/test/daemon-session-list.test.ts b/packages/coding-agent/test/daemon-session-list.test.ts
index 19d8367ea0..491fa63205 100644
--- a/packages/coding-agent/test/daemon-session-list.test.ts
+++ b/packages/coding-agent/test/daemon-session-list.test.ts
@@ -42,6 +42,18 @@ describe("buildSessionList", () => {
{ messages: oneMessage, summaryState: currentSummary },
{ activity: "idle" },
],
+ [
+ "a resident session with a stale verdict is idle, not held at working",
+ {
+ messages: oneMessage,
+ summaryState: {
+ summary: "Old recap",
+ taskState: "completed",
+ basedOnMessageCount: 0,
+ } as ActiveSessionState["summaryState"],
+ },
+ { activity: "idle", summary: "Old recap" },
+ ],
["an empty resident session is idle", {}, { activity: "idle" }],
[
"a finished subagent is idle instead of stuck working",
diff --git a/packages/coding-agent/test/daemon-session-summarizer-lifecycle.test.ts b/packages/coding-agent/test/daemon-session-summarizer-lifecycle.test.ts
index fb9a9b70cb..037bab2c81 100644
--- a/packages/coding-agent/test/daemon-session-summarizer-lifecycle.test.ts
+++ b/packages/coding-agent/test/daemon-session-summarizer-lifecycle.test.ts
@@ -125,8 +125,8 @@ describe("DaemonSessionSummarizer lifecycle", () => {
summarizer.notifyActivity(state);
await vi.advanceTimersByTimeAsync(SETTLE_MS + 500);
expect(generate).toHaveBeenCalledOnce();
- // The activity axis holds an unjudged idle session at "working"; the fallback
- // settles it to needs_input so it doesn't spin forever.
+ // A failed classification on an idle session settles to needs_input so it
+ // carries a current verdict.
expect(state.summaryState).toMatchObject({ taskState: "needs_input", basedOnMessageCount: 2 });
});
diff --git a/packages/coding-agent/test/sessions-table-format.test.ts b/packages/coding-agent/test/sessions-table-format.test.ts
index 550d8ff2b5..155b283ad2 100644
--- a/packages/coding-agent/test/sessions-table-format.test.ts
+++ b/packages/coding-agent/test/sessions-table-format.test.ts
@@ -67,7 +67,7 @@ describe("formatSessionsTable", () => {
["compacting", { activity: "working", isCompacting: true }, row("s", "running", "compacting")],
["completed verdict", { taskState: "completed" }, row("s", "idle", "completed")],
["saved status", { activeSessionId: undefined, rosterStatus: "inactive" }, row("s", "inactive", "")],
- ["queued label", { activity: "working", statusLabel: "queued" }, row("s", "queued", "classifying")],
+ ["queued label", { activity: "working", statusLabel: "queued" }, row("s", "queued", "working")],
["recovering label", { statusLabel: "recovering" }, row("s", "recovering", "")],
["failed label", { statusLabel: "failed" }, row("s", "failed", "", "", "worker failed")],
[
@@ -75,7 +75,7 @@ describe("formatSessionsTable", () => {
{ modelFallbackMessage: "boom\u0007\u001B[31m!\u001B[39m" },
row("s", "idle", "", "", "boom!"),
],
- ["staleness", { activity: "working", lastHeardFromAt: STALE_AT }, row("s", "running", "classifying", "10m")],
+ ["staleness", { activity: "working", lastHeardFromAt: STALE_AT }, row("s", "running", "working", "10m")],
["usage compact", { usage: SPEND }, row("s", "idle", "", "", "", "1.2k/567 $0.42")],
[
"sanitizes and truncates the recap appended to the activity detail",
@@ -112,7 +112,7 @@ describe("formatSessionsTable", () => {
["starting", { activity: "working", workerState: "starting" }],
["archived", { lifecycle: "archived", rosterStatus: "inactive" }],
["replied", { runtimeKind: "subagent", repliedSinceTask: true }],
- ["classifying", { activity: "working" }],
+ ["working", { activity: "working" }],
["error", { taskState: "error" }],
["completed", { taskState: "completed" }],
])("%s agrees with the table's activity wording", (expected, overrides) => {