Skip to content

A self-improving RLM agent for coding workflows and long-running autonomous tasks.

Rust

pa-tui: pass the missing level argument in ipython render tests (#3858)

Seth Kartene375911c1275
diff --git a/.changes/fix-ipython-render-test-args.md b/.changes/fix-ipython-render-test-args.md
new file mode 100644
index 0000000000..aa8b429552
--- /dev/null
+++ b/.changes/fix-ipython-render-test-args.md
@@ -0,0 +1 @@
+fix: pass the missing conversation-level argument in the ipython card render tests, repairing a workspace build broken by the combination of the live-timer and click-fix PRs
diff --git a/crates/pa-daemon/tests/agent_family_e2e.rs b/crates/pa-daemon/tests/agent_family_e2e.rs
index 28196cc60f..1ad6558529 100644
--- a/crates/pa-daemon/tests/agent_family_e2e.rs
+++ b/crates/pa-daemon/tests/agent_family_e2e.rs
@@ -1428,6 +1428,7 @@ async fn passivated_child_recent_messages_reads_its_file_end_to_end() {
model: None,
thinking: None,
spawned_by_request_id: None,
+ factory: None,
})
.await
.expect("spawn kid-a");
diff --git a/crates/pa-tui/src/tool_card/ipython/tests.rs b/crates/pa-tui/src/tool_card/ipython/tests.rs
index 0f204db3d7..7f905c6563 100644
--- a/crates/pa-tui/src/tool_card/ipython/tests.rs
+++ b/crates/pa-tui/src/tool_card/ipython/tests.rs
@@ -260,7 +260,15 @@ fn running_cell_summary_ticks_live_elapsed() {
.checked_sub(std::time::Duration::from_millis(1500))
.expect("the clock is past the start"),
);
- let lines = render(&card, 0, Detail::Overview, &theme(), 100, true);
+ let lines = render(
+ &card,
+ 0,
+ Detail::Overview,
+ Detail::Overview,
+ &theme(),
+ 100,
+ true,
+ );
let text = text_of(&lines[0]);
assert!(text.contains("↑ 1 lines"), "got: {text}");
// The duration slot ticks right after the line counts: the summary's
@@ -289,7 +297,15 @@ fn running_cell_long_preview_keeps_live_duration_visible() {
.checked_sub(std::time::Duration::from_millis(1500))
.expect("the clock is past the start"),
);
- let lines = render(&card, 0, Detail::Overview, &theme(), 80, true);
+ let lines = render(
+ &card,
+ 0,
+ Detail::Overview,
+ Detail::Overview,
+ &theme(),
+ 80,
+ true,
+ );
let text = text_of(&lines[0]);
// Pre-fix this line is red: the row overflows to 95 columns and the
// right clip eats the duration slot entirely, so the summary's last
@@ -344,7 +360,15 @@ fn aborted_cell_never_renders_done_from_a_stale_exit_code() {
});
let mut card = cell_card(code, details, false, false);
card.aborted = true;
- let lines = render(&card, 0, Detail::Overview, &theme(), 100, true);
+ let lines = render(
+ &card,
+ 0,
+ Detail::Overview,
+ Detail::Overview,
+ &theme(),
+ 100,
+ true,
+ );
let text = text_of(&lines[0]);
assert!(text.contains("\u{2717}"), "got: {text}");
assert!(!text.contains("\u{2713}"), "got: {text}");
@@ -493,8 +517,24 @@ fn an_aborted_cell_freezes_its_duration_from_card_timestamps() {
card.started_at = now.checked_sub(std::time::Duration::from_secs(4));
card.ended_at = now.checked_sub(std::time::Duration::from_secs(1));
card.aborted = true;
- let first = render(&card, 0, Detail::Overview, &theme(), 100, true);
- let later = render(&card, 10, Detail::Overview, &theme(), 100, true);
+ let first = render(
+ &card,
+ 0,
+ Detail::Overview,
+ Detail::Overview,
+ &theme(),
+ 100,
+ true,
+ );
+ let later = render(
+ &card,
+ 10,
+ Detail::Overview,
+ Detail::Overview,
+ &theme(),
+ 100,
+ true,
+ );
assert_eq!(
first, later,
"a settled timer never repaints a different duration"