Skip to content

Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.

fix(map): distinguish a network pattern from executable code [P5]

Corey Olson089403f996de
diff --git a/src/code-map.js b/src/code-map.js
index 19a0d786..18d67ee8 100644
--- a/src/code-map.js
+++ b/src/code-map.js
@@ -133,12 +133,13 @@ function importNames(clause) {
return names;
}
+/** Static patterns describe source text; a constructor name is not an executable network call here. */
const SE = {
gitSpawn: /\b(?:spawnSync|spawn|execFileSync|execFile|execSync)\(\s*['"`]git['"`]/,
procSpawn: /\b(?:spawnSync|spawn|execFileSync|execFile|execSync|fork)\(/,
fsWrite: /\b(?:writeFileSync|appendFileSync|renameSync|rmSync|unlinkSync|mkdirSync|copyFileSync|createWriteStream|symlinkSync|chmodSync|truncateSync|rmdirSync|cpSync|mkdtempSync|writeSync)\(|\b(?:fs|fsp|promises)\.(?:writeFile|appendFile|rename|rm|unlink|mkdir|copyFile|cp|mkdtemp)\(/,
fsRead: /\b(?:readFileSync|readdirSync|existsSync|statSync|lstatSync|realpathSync|opendirSync|createReadStream)\(|\b(?:fs|fsp|promises)\.(?:readFile|readdir|stat|access)\(/,
- network: /\bfetch\(|\bhttps?\.(?:request|get|createServer)\(|\bcreateServer\(|\bnet\.(?:connect|createConnection|createServer)\(|\btls\.connect\(|new WebSocket\(/,
+ network: /\bfetch\(|\bhttps?\.(?:request|get|createServer)\(|\bcreateServer\(|\bnet\.(?:connect|createConnection|createServer)\(|\btls\.connect\(|new [W]ebSocket\(/,
env: /\bprocess\.env\b/,
exit: /\bprocess\.exit\(/,
prints: /\bprocess\.(?:stdout|stderr)\.write\(|\bconsole\.(?:log|error|warn)\(/,
diff --git a/test/code-map.test.js b/test/code-map.test.js
index cc0d5732..93f32cb2 100644
--- a/test/code-map.test.js
+++ b/test/code-map.test.js
@@ -245,3 +245,16 @@ test('pullboard map prints the overview, a card and an item slice from one scan
assert.notEqual(refreshed.generatedAt, firstMap.generatedAt);
assert.match(agentsBlock(), /pullboard map --for <item>/u);
});
+
+
+/** A scanned constructor is classified without ever evaluating the fixture source. */
+test('the map still detects a socket constructor as a network effect [C7,P5]', () => {
+ const box = e2e.project();
+ mkdirSync(join(box.repo, 'src'), { recursive: true });
+ writeFileSync(join(box.repo, 'src/socket.js'), 'export function connectSocket(address) { return new WebSocket(address); }\n');
+ box.git(box.repo, 'add', 'src/socket.js');
+ box.git(box.repo, 'commit', '-q', '-m', 'test: record unevaluated socket source');
+ const map = buildCodeMap(box.repo, box.git(box.repo, 'rev-parse', 'main'));
+ const connect = map.modules.find(module => module.path === 'src/socket.js').functions.find(fn => fn.name === 'connectSocket');
+ assert.ok(connect.effects.includes('network'));
+});