Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.
JavaScript agentic-codingai-agentsai-governanceautonomous-agentsclaude-codeclicode-reviewcodexcoding-agentsdeveloper-toolsgit-hooksllmlocal-firstmulti-agentsoftware-factoryspec-driven-developmentverificationvibe-coding
feat: bind signed bar commands to exact effects [E22,V1,H16]
Corey Olson12ff03fd624f
diff --git a/relay/browser-client.js b/relay/browser-client.jsindex 5086e32f..d41fc537 100644--- a/relay/browser-client.js+++ b/relay/browser-client.js@@ -1,3 +1,4 @@+import { browserPersonBarEffect } from './person-bar-effect.js';/** Device-only relay transport: cookie authorization, local keys and authenticated ciphertext [H5,H15,H16,H17]. */import {rememberDevicePairing,@@ -843,6 +844,9 @@ export async function createTransport({ onUpdate = () => {}, onOpenBoard = () =>if (rows.some(row => !row || typeof row.source !== 'string')) throw new Refused('STALE_ROW_DECISION', 'Refresh this board to read each exact row, gate and signer list before confirming.');value = preparePersonRequest(value.move, value.id, rows);}+ if (entry.state.personSigning?.signed && ['add', 'edit', 'bar-sign'].includes(value.move.verb) && !value.effect) {+ value = preparePersonRequest(value.move, value.id, value.rows, browserPersonBarEffect(entry.state, value.move));+ }if (entry.state.personSigning?.signed && !presences.has(value.id)) {presences.set(value.id, await passkeyPresence((path, options) => documentAt(path, denied, { ...options, signal: access.signal }), entry.id, value));}@@ -853,7 +857,7 @@ export async function createTransport({ onUpdate = () => {}, onOpenBoard = () =>}installPersonPasskeys(document, { documentAt: (path, options) => documentAt(path, denied, { ...options, signal: access.signal }),boards: () => [...paired.values()], signal: access.signal,- confirm: (board, proposal) => sendPersonRequest(paired.get(board), preparePersonRequest(proposal.move, proposal.id, proposal.rows)) });+ confirm: (board, proposal) => sendPersonRequest(paired.get(board), preparePersonRequest(proposal.move, proposal.id, proposal.rows, proposal.effect)) });return {/** Give the startup frame back only after an opted-in viewer has drawn a readable board. */didRender() { rendered = true; notice(); for (const entry of paired.values()) entry.history?.start(); },diff --git a/relay/browser-page.js b/relay/browser-page.jsindex bcb75ac2..3ccf1d3a 100644--- a/relay/browser-page.js+++ b/relay/browser-page.js@@ -63,6 +63,7 @@ export function createRelayBrowserHandler({ authenticate }) {['/relay/engine.js', ['text/javascript', 'export const ENGINE_VERSION = ' + ENGINE_VERSION + ';\n']],['/relay/seal.js', ['text/javascript', readFileSync(new URL('../src/seal.js', import.meta.url), 'utf8')]],['/relay/api-moves.js', ['text/javascript', readFileSync(new URL('../src/api-moves.js', import.meta.url), 'utf8')]],+ ['/relay/person-bar-effect.js', ['text/javascript', readFileSync(new URL('../src/person-bar-effect.js', import.meta.url), 'utf8')]],['/relay/person-request.js', ['text/javascript', readFileSync(new URL('../src/person-request.js', import.meta.url), 'utf8')]],['/relay/refused.js', ['text/javascript', readFileSync(new URL('../src/refused.js', import.meta.url), 'utf8')]],]);diff --git a/relay/browser-passkeys.js b/relay/browser-passkeys.jsindex 8b487339..5432b921 100644--- a/relay/browser-passkeys.js+++ b/relay/browser-passkeys.js@@ -110,7 +110,7 @@ export function installPersonPasskeys(doc, { documentAt, boards, confirm, signalfor (const proposal of entry.state.personProposals ?? []) {if (done.has(proposal.id) || Date.parse(proposal.expires) <= Date.now()) continue;const card = doc.createElement('div'); card.className = 'phone-approval'; card.dataset.proposal = proposal.id;- const text = doc.createElement('p'); text.className = 'phone-approval-title'; text.textContent = proposalText(proposal.move) + (proposal.rows?.length ? '\n' + proposal.rows.map(row => `${row.id}: ${row.source ?? row.text}`).join('\n') : '');+ const text = doc.createElement('p'); text.className = 'phone-approval-title'; text.textContent = proposalText(proposal.move) + (proposal.rows?.length ? '\n' + proposal.rows.map(row => `${row.id}: ${row.source ?? row.text}`).join('\n') : '') + (proposal.effect ? '\n' + JSON.stringify(proposal.effect, null, 2) : '');const button = doc.createElement('button'); button.type = 'button'; button.id = 'person-confirm-' + proposal.id; button.textContent = 'Confirm with passkey';button.onclick = async () => {button.disabled = true;diff --git a/src/api-moves.js b/src/api-moves.jsindex bdd0d898..69b8c343 100644--- a/src/api-moves.js+++ b/src/api-moves.js@@ -10,9 +10,10 @@ const MOVES = {'spec-answer': { prefix: ['spec', 'answer'], positions: ['row', 'answer'] },'check-accept': { prefix: ['check', 'accept'], item: true },'land-waive': { prefix: ['land'], flags: ['waive', 'until', 'reason'] },+ 'bar-sign': { prefix: ['bar', 'sign'], item: true, flags: ['note'] },signing: { prefix: ['settings', 'person.signed'], positions: ['signed'] },- add: { positions: ['lane', 'title'], flags: ['criterion', 'specs', 'parent', 'after', 'brief', 'route', 'check'], booleans: ['wait'], booleans: ['wait'] },- edit: { item: true, flags: ['criterion', 'brief', 'route', 'check', 'reason'], booleans: ['wait'], booleans: ['wait'] },+ add: { positions: ['lane', 'title'], flags: ['criterion', 'specs', 'parent', 'after', 'brief', 'route', 'check', 'as'], booleans: ['wait'] },+ edit: { item: true, flags: ['criterion', 'brief', 'route', 'check', 'reason', 'after', 'as'], booleans: ['wait'] },fact: { item: true, positions: ['kind', 'text'], flags: ['supersedes', 'ref', 'implies', 'as', 'cause'], booleans: ['never-again'] },claim: { item: true },release: { item: true, flags: ['note'] },diff --git a/src/bar-coverage.js b/src/bar-coverage.jsindex 3f4728f6..fe447ff9 100644--- a/src/bar-coverage.js+++ b/src/bar-coverage.js@@ -54,8 +54,8 @@ export function normalizeBarCoverage(value, item) {runner: value.runner, required, files, totalMs, ...(files.length ? { named: { ...value.named }, installMs: value.installMs, ...(value.install ? { install: { ...value.install } } : {}) } : {}) };}/** Bind inventory and accepted execution settings, allowing unrelated main changes without resigning. */-function coverageInputs(root, item, policy) {- const committed = new Set(git(root, ['ls-tree', '-r', '--name-only', '-z', policy.commit]).split('\0').filter(Boolean));+function coverageInputs(root, item, policy, inventory) {+ const committed = inventory ?? new Set(git(root, ['ls-tree', '-r', '--name-only', '-z', policy.commit]).split('\0').filter(Boolean));const required = [...new Set(briefFiles(item.item_brief).filter(path => committed.has(path) && barTestPath(path, policy.config.claim.barTestFiles)))].sort();const policyKey = createHash('sha256').update(JSON.stringify({ required, runner: policy.config.affectedTests ?? '',install: policy.config.check.install, timeoutMs: policy.config.check.timeoutMs, patterns: policy.config.claim.barTestFiles })).digest('hex');@@ -92,3 +92,18 @@ export function barCoverageCommand(sourceCheck, plan) {const paths = plan.files.filter(file => file.mode === 'whole').map(file => `'./${file.path.replaceAll("'", "'\\''")}'`);return paths.length ? `(\n${sourceCheck}\n) && (\n${plan.runner} ${paths.join(' ')}\n)` : sourceCheck;}++/** Build sealed phone previews with one accepted inventory read; missing measured evidence remains missing. */+export function previewBarCoverage(root, entries, policy) {+ const inventory = new Set(git(root, ['ls-tree', '-r', '--name-only', '-z', policy.commit]).split('\0').filter(Boolean));+ return entries.map(({ item, coverage }) => {+ const { required, policyKey } = coverageInputs(root, item, policy, inventory);+ if (coverage) {+ const plan = normalizeBarCoverage(coverage, item);+ if (plan.policyKey === policyKey && plan.sourceCheck === item.item_check) return plan;+ }+ if (required.length) return null;+ return normalizeBarCoverage({ version: 1, sourceMain: policy.commit, sourceCheck: item.item_check, policyKey,+ timeoutMs: policy.config.check.timeoutMs, runner: policy.config.affectedTests ?? '', required: [], files: [] }, item);+ });+}diff --git a/src/commands/add.js b/src/commands/add.jsindex df5b281d..8757930f 100644--- a/src/commands/add.js+++ b/src/commands/add.js@@ -1,3 +1,8 @@+import {+ confirmBarEffect,+ executingBarEffect,+ personBarMode,+} from '../person-bar-cli.js';/** The pullboard add command, in its own module so an item adding another command never edits these lines. */import * as store from '../board.js';import {@@ -30,7 +35,6 @@ import {idList,launchBaseline,ordered,- personMode,} from '../cli.js';/** Run `pullboard add` and return its exit code. */@@ -56,7 +60,7 @@ export async function run(io, args) {const parentId = values.parent ? idArg(values.parent, 'a parent item id') : null;const after = idList(values.after).map((text) => idArg(text, 'an item id after --after'));const title = [second, ...rest].filter(Boolean).join(' ');- const item = {+ let item = {by: io.personRequest?.phase === 'execute' ? store.PERSON : me.id,lane: first,title,@@ -68,11 +72,23 @@ export async function run(io, args) {route: values.route ?? 'strong',check: values.check,};- buildInFilelessLane(ctx.config, first, after);+ const sealed = executingBarEffect(ctx, board, 'add');+ if (sealed) item = { ...sealed };+ if (sealed) {+ const sealedProblems = idProblems(loadSpec(ctx.info.root, ctx.config), item.specIds, ctx.doctrine);+ if (sealedProblems.length) throw new Refused('UNKNOWN_SPEC', sealedProblems.join('; '));+ briefInLane(ctx, item.lane, item.brief);+ }+ const asPerson = personBarMode(ctx, board, me, values);+ const confirmed = await confirmBarEffect(ctx, board, me, { verb: 'add', args: {+ lane: item.lane, title: item.title, ...(values.wait ? { wait: true } : {}), as: 'person',+ } }, item, asPerson);+ if (confirmed !== null) return confirmed;+ buildInFilelessLane(ctx.config, item.lane, item.after);const { command } = store.validateItemAddition(board, item);if (command) refuseCheckSyntax(command);if (command) item.checkBaseline = values.wait ? checkBaseline(ctx.info.root, command) : prepareCheckBaseline(ctx.info.root, command);- item.barActor = barActorForCommand(ctx, board, { asPerson: personMode(ctx, me, values) });+ item.barActor = barActorForCommand(ctx, board, { asPerson });const id = await ordered(ctx, board, 'addItem', [item]);if (item.checkBaseline?.result === 'pending') await launchBaseline(ctx, board, id, item.checkBaseline);io.result?.({ item: store.getItem(board, id) });diff --git a/src/commands/bar.js b/src/commands/bar.jsindex 08ecf685..d5c31211 100644--- a/src/commands/bar.js+++ b/src/commands/bar.js@@ -1,4 +1,12 @@-import { prepareBarCoverage } from '../bar-coverage.js';+import {+ confirmBarEffect,+ executingBarEffect,+ personBarMode,+} from '../person-bar-cli.js';+import {+ barCoverageForPolicy,+ prepareBarCoverage,+} from '../bar-coverage.js';import { mainPolicy } from '../trusted-policy.js';/** Inspect, enable and independently sign acceptance bars [B4,V1,V2,H16]. */import { getItem } from '../board.js';@@ -11,7 +19,6 @@ import {barActorForCommand,idArg,ordered,- personMode,} from '../cli.js';import { Refused } from '../refused.js';@@ -36,8 +43,13 @@ export async function run(io, { first, second, rest, values }) {return 0;}io.say(`Sign-off asks: can the builder meet this bar, and would two reviewers grade it the same? Check the named baseline, every measurement method, coverage and reviewer edges in pullboard show ${id}.`);- const coverage = prepareBarCoverage(ctx.info.root, item, mainPolicy(ctx.info.root), values['coverage-file']);- const signed = await ordered(ctx, board, 'signBar', [id, { agentId: me.id, revision: status.revision?.revision, digest: status.revision?.digest, note: values.note, coverage, barActor: barActorForCommand(ctx, board, { asPerson: personMode(ctx, me, values) }) }]);+ const sealed = executingBarEffect(ctx, board, 'bar-sign', id);+ const coverage = sealed ? barCoverageForPolicy(ctx.info.root, item, sealed.coverage, mainPolicy(ctx.info.root)) : prepareBarCoverage(ctx.info.root, item, mainPolicy(ctx.info.root), values['coverage-file']);+ const asPerson = personBarMode(ctx, board, me, values);+ const effect = sealed ?? { revision: status.revision?.revision, digest: status.revision?.digest, note: values.note, coverage };+ const confirmed = await confirmBarEffect(ctx, board, me, { verb: 'bar-sign', item: id, args: { note: effect.note } }, effect, asPerson);+ if (confirmed !== null) return confirmed;+ const signed = await ordered(ctx, board, 'signBar', [id, { agentId: io.personRequest?.phase === 'execute' ? 'person' : me.id, ...effect, barActor: barActorForCommand(ctx, board, { asPerson }) }]);io.result?.({ signed });io.say(`signed #${id} revision ${signed.revision}; any bar edit needs a fresh signature`);return 0;diff --git a/src/commands/edit.js b/src/commands/edit.jsindex d41d081a..445f42d2 100644--- a/src/commands/edit.js+++ b/src/commands/edit.js@@ -1,3 +1,8 @@+import {+ confirmBarEffect,+ executingBarEffect,+ personBarMode,+} from '../person-bar-cli.js';import { barReadySetting } from '../bar-readiness.js';/** The pullboard edit command, in its own module so an item adding another command never edits these lines. */import * as store from '../board.js';@@ -20,7 +25,6 @@ import {idArg,launchBaseline,ordered,- personMode,} from '../cli.js';/** Run `pullboard edit` and return its exit code. */@@ -39,8 +43,9 @@ export async function run(io, args) {await relayCommandReceiptReported(ctx.info.root, recovered.move.id);return 0;}- const brief = briefArg(io, values);- const change = {+ const sealed = executingBarEffect(ctx, board, 'edit', id);+ const brief = sealed ? sealed.brief : briefArg(io, values);+ let change = {agentId: me.id,brief: brief === undefined ? undefined : briefInLane(ctx, store.getItem(board, id).item_lane, brief),route: values.route,@@ -49,10 +54,15 @@ export async function run(io, args) {after: editAfter(values.after),...(values.reason !== undefined ? { reason: values.reason } : {}),};+ if (sealed) change = { ...sealed };+ const asPerson = personBarMode(ctx, board, me, values);+ const confirmed = await confirmBarEffect(ctx, board, me, { verb: 'edit', item: id,+ args: { as: 'person', ...(values.wait ? { wait: true } : {}) } }, change, asPerson);+ if (confirmed !== null) return confirmed;const { item, command } = store.validateItemEdit(board, id, change);if (command && command !== item.item_check) refuseCheckSyntax(command);if (command && (command !== item.item_check || barReadySetting(board).enabled)) change.checkBaseline = values.wait ? checkBaseline(ctx.info.root, command) : prepareCheckBaseline(ctx.info.root, command);- change.barActor = barActorForCommand(ctx, board, { asPerson: personMode(ctx, me, values) });+ change.barActor = barActorForCommand(ctx, board, { asPerson });await ordered(ctx, board, 'editItem', [id, change]);if (change.checkBaseline?.result === 'pending') await launchBaseline(ctx, board, id, change.checkBaseline);io.result?.({ item: store.getItem(board, id) });diff --git a/src/person-bar-cli.js b/src/person-bar-cli.jsnew file mode 100644index 00000000..fc62ff4f--- /dev/null+++ b/src/person-bar-cli.js@@ -0,0 +1,51 @@+/** Native signed bar commands reuse sealed normalized values and recheck their displayed revision [E22,V1]. */+import { personMode } from './cli.js';+import { getItem } from './board.js';+import {+ barDigest,+ barReadiness,+} from './bar-readiness.js';+import { personRequestRecords } from './relay-requests.js';+import { requireSignedPerson } from './person-signing-cli.js';+import { personSigning } from './person-signing.js';+import {+ barEffectValues,+ normalizePersonBarEffect,+ sameBarEffect,+} from './person-bar-effect.js';+import { Refused } from './refused.js';++/** Capture the current author revision even for boards whose bar-ready setting is off. */+function beforeBar(board, id) {+ const item = getItem(board, id);+ return { revision: barReadiness(board, item, { signature: false }).revision?.revision ?? 0, digest: barDigest(item) };+}+/** Read only the exact current execution document; never accept caller-provided flags as signed provenance. */+export function executingBarEffect(ctx, board, verb, id) {+ if (!ctx.io.personRequest || !personSigning(board).signed) return null;+ const record = personRequestRecords(board).find(entry => entry.id === ctx.io.personRequest.id && !entry.duplicateOf);+ let document;+ try { document = JSON.parse(record?.encoded); } catch { /* Refuse malformed source below. */ }+ if (document?.move?.verb !== verb || (id !== undefined && document.move.item !== id) || !document.effect) {+ throw new Refused('PERSON_REQUEST_RECEIPT', 'this signed bar command has no exact normalized effect; show and confirm it again');+ }+ const effect = normalizePersonBarEffect(verb, document.effect);+ if (verb !== 'add' && !sameBarEffect(effect.before, beforeBar(board, id))) {+ throw new Refused('BAR_SIGN_STALE', 'the bar changed after it was shown; show and confirm its current revision again');+ }+ return effect.value;+}+/** Propose before any baseline runs; execution still goes through requireSignedPerson's strict presence check. */+export async function confirmBarEffect(ctx, board, me, intent, value, asPerson) {+ if (!personSigning(board).signed || !asPerson && !ctx.io.personRequest) return null;+ const author = !ctx.io.personRequest ? intent.verb === 'add' ? { by: 'coordinator' } : intent.verb === 'edit' ? { agentId: 'coordinator' } : {} : {};+ const effect = { version: 1, value: barEffectValues(intent.verb, { ...value, ...author }),+ ...(intent.verb === 'add' ? {} : { before: beforeBar(board, intent.item) }) };+ return requireSignedPerson(ctx, board, me, intent, undefined, effect);+}++/** Signed terminals propose from any checkout; the authenticated executor alone supplies person authority. */+export function personBarMode(ctx, board, me, values) {+ return personSigning(board).signed && (values.as === 'person' || ctx.io.personRequest?.phase === 'execute')+ ? true : personMode(ctx, me, values);+}diff --git a/src/person-bar-effect.js b/src/person-bar-effect.jsnew file mode 100644index 00000000..73efcbea--- /dev/null+++ b/src/person-bar-effect.js@@ -0,0 +1,67 @@+/** Signed bar intent binds normalized author fields, never local paths or generated baseline receipts [E22,V1]. */+import { Refused } from './refused.js';++const FIELDS = {+ add: ['by', 'lane', 'title', 'criterion', 'specIds', 'parentId', 'after', 'brief', 'route', 'check'],+ edit: ['agentId', 'brief', 'route', 'criterion', 'check', 'after', 'reason'],+ 'bar-sign': ['revision', 'digest', 'note', 'coverage'],+};+/** Select author-controlled fields with omission preserved; generated evidence and identity cannot ride along. */+export function barEffectValues(verb, value) {+ return Object.fromEntries(FIELDS[verb].filter(key => value[key] !== undefined).map(key => [key, structuredClone(value[key])]));+}+/** Validate the bounded signed envelope without reading local files during relay replay. */+export function normalizePersonBarEffect(verb, effect) {+ if (!FIELDS[verb] || !effect || effect.version !== 1 || !effect.value || typeof effect.value !== 'object' || Array.isArray(effect.value)+ || Object.keys(effect).some(key => !['version', 'value', 'before'].includes(key))+ || (verb === 'add' && !['coordinator', 'person'].includes(effect.value.by))+ || (verb === 'edit' && effect.value.agentId !== 'coordinator')+ || Object.keys(effect.value).some(key => !FIELDS[verb].includes(key))+ || ['lane', 'title', 'criterion', 'brief', 'route', 'check', 'reason', 'note', 'digest'].some(key => effect.value[key] !== undefined && typeof effect.value[key] !== 'string')+ || ['specIds', 'after'].some(key => effect.value[key] !== undefined && (!Array.isArray(effect.value[key])+ || effect.value[key].some(value => key === 'specIds' ? typeof value !== 'string' : !Number.isSafeInteger(value) || value < 1)))+ || (effect.value.parentId !== undefined && effect.value.parentId !== null && (!Number.isSafeInteger(effect.value.parentId) || effect.value.parentId < 1)) || JSON.stringify(effect).length > 524288+ || (verb === 'add' ? effect.before !== undefined : !effect.before || !Number.isSafeInteger(effect.before.revision)+ || effect.before.revision < 0 || !/^[a-f0-9]{64}$/u.test(effect.before.digest ?? '')+ || Object.keys(effect.before).sort().join() !== 'digest,revision')) {+ throw new Refused('PERSON_REQUEST_RECEIPT', 'this bar request needs its exact normalized fields and current revision; show and confirm it again');+ }+ return { version: 1, value: barEffectValues(verb, effect.value), ...(effect.before ? { before: { revision: effect.before.revision, digest: effect.before.digest } } : {}) };+}+/** Compare complete JSON structures independent of object insertion order, retaining array order and omissions. */+export function sameBarEffect(left, right) {+ const canonical = value => Array.isArray(value) ? value.map(canonical) : value && typeof value === 'object'+ ? Object.fromEntries(Object.keys(value).sort().map(key => [key, canonical(value[key])])) : value;+ return JSON.stringify(canonical(left)) === JSON.stringify(canonical(right));+}++/** Turn literal paired-browser fields into the exact displayed effect; native execution rechecks all policy. */+export function browserPersonBarEffect(state, move) {+ const args = move.args;+ const ids = text => text ? text.split(',').map(part => part.trim()).filter(Boolean) : [];+ const number = text => {+ if (!/^#?[1-9][0-9]*$/u.test(text ?? '')) throw new Refused('BAD_REQUEST', 'use an exact positive item id in this bar request');+ const value = Number(text.replace(/^#/u, ''));+ if (!Number.isSafeInteger(value)) throw new Refused('BAD_REQUEST', 'this item id is too large');+ return value;+ };+ let value;+ let before;+ if (move.verb === 'add') {+ value = { by: 'person', lane: args.lane, title: args.title, criterion: args.criterion ?? '', specIds: ids(args.specs),+ parentId: args.parent ? number(args.parent) : null, after: ids(args.after).map(number), brief: args.brief ?? '', route: args.route ?? 'strong',+ ...(args.check === undefined ? {} : { check: args.check }) };+ } else {+ const current = state.personBars?.find(entry => entry.id === move.item);+ if (!current) throw new Refused('BAR_SIGN_STALE', 'refresh this board to see its current bar revision before confirming');+ before = current.before;+ if (move.verb === 'edit') {+ value = { agentId: 'coordinator', ...Object.fromEntries(['brief', 'route', 'criterion', 'check', 'reason'].filter(key => args[key] !== undefined).map(key => [key, args[key]])),+ ...(args.after === undefined ? {} : { after: args.after.trim() === 'none' ? [] : ids(args.after).map(number) }) };+ } else {+ if (!current.coverage) throw new Refused('BAR_COVERAGE', 'prepare the required recorded coverage with pullboard bar sign --coverage-file from a terminal, then confirm its exact proposal here');+ value = { revision: before.revision, digest: before.digest, note: args.note, coverage: current.coverage };+ }+ }+ return normalizePersonBarEffect(move.verb, { version: 1, value, ...(before ? { before } : {}) });+}diff --git a/src/person-confirmation.js b/src/person-confirmation.jsindex b8411dd4..b2ca4cf8 100644--- a/src/person-confirmation.js+++ b/src/person-confirmation.js@@ -1,3 +1,4 @@+import { getItem } from './board.js';/** Wait for one passkey-confirmed terminal request to finish through the ordinary native executor [E22,H16]. */import { setTimeout as delay } from 'node:timers/promises';import { syncRelay } from './relay.js';@@ -7,8 +8,11 @@ import { Refused } from './refused.js';import { loadMachineSettings } from './settings.js';/** Preserve the ordinary command's required JSON fields while adding its confirmed request receipt. */-function confirmedResult(record) {+function confirmedResult(record, board) {switch (record.move.verb) {+ case 'add':+ case 'edit': return { item: getItem(board, record.move.verb === 'add' ? record.result : record.move.item) };+ case 'bar-sign': return { signed: record.result };case 'answer': return { id: record.result, answers: record.move.item };case 'spec-approve':case 'spec-decline':@@ -44,7 +48,7 @@ export async function awaitPersonConfirmation(ctx, board, request, where, { wait// Repo-changing spec decisions finish the native CLI stage by creating a coordinator request.// This reports that stage, never promises its eventual merge/landing outcome.if (record?.status === 'done' || record?.coordinatorRequest && Object.hasOwn(record, 'result')) {- const result = { ...confirmedResult(record), request: request.id, status: record.status,+ const result = { ...confirmedResult(record, board), request: request.id, status: record.status,...(record.coordinatorRequest ? { coordinatorRequest: record.coordinatorRequest } : {}) };ctx.io.personConfirmation = { request: result.request, status: result.status };ctx.io.result?.(result);diff --git a/src/person-request.js b/src/person-request.jsindex 639fb73a..dc8b4ce2 100644--- a/src/person-request.js+++ b/src/person-request.js@@ -1,9 +1,10 @@/** Browser-sealed person intent is CLI input, never an executable engine move [H12,H16]. */import { moveArgs } from './api-moves.js';+import { normalizePersonBarEffect } from './person-bar-effect.js';import { Refused } from './refused.js';export const PERSON_REQUEST_VERSION = 1;-const VERBS = Object.freeze(['add', 'shout', 'answer', 'hold', 'spec-approve', 'spec-decline', 'sentinel-approve', 'sentinel-decline', 'land-waive', 'signing', 'fact', 'spec-answer']);+const VERBS = Object.freeze(['add', 'shout', 'answer', 'hold', 'spec-approve', 'spec-decline', 'sentinel-approve', 'sentinel-decline', 'land-waive', 'signing', 'fact', 'spec-answer', 'edit', 'bar-sign']);/** Validate a narrow person intent while retaining literal arguments for the actual CLI parser. */export function personRequestMove(body) {@@ -29,8 +30,8 @@ export function personRequestMove(body) {* Create the distinct versioned request document before the browser seals it for request-kind AAD. A row decision on* a board that signs person moves also carries `rows`, the exact text of each row as the person saw it [E22].*/-export function preparePersonRequest(body, id = crypto.randomUUID(), rows) {- const document = { version: PERSON_REQUEST_VERSION, type: 'person-request', id, move: personRequestMove(body), ...(rows ? { rows } : {}) };+export function preparePersonRequest(body, id = crypto.randomUUID(), rows, effect) {+ const document = { version: PERSON_REQUEST_VERSION, type: 'person-request', id, move: personRequestMove(body), ...(rows ? { rows } : {}), ...(effect ? { effect } : {}) };return validatePersonRequest(document);}@@ -49,10 +50,11 @@ export function validatePersonRequest(document) {throw new Refused('PERSON_REQUEST_VERSION', 'this person request format is unsupported; upgrade Pullboard on the browser and linked machine');}if (typeof document.id !== 'string' || !/^[A-Za-z0-9_-]{1,80}$/u.test(document.id)- || Object.keys(document).some(key => !['version', 'type', 'id', 'move', 'rows'].includes(key))) {+ || Object.keys(document).some(key => !['version', 'type', 'id', 'move', 'rows', 'effect'].includes(key))) {throw new Refused('BAD_REQUEST', 'a sealed person request needs its stable id and literal move; reload the paired view and retry');}const move = personRequestMove(document.move);if (document.rows !== undefined && !['spec-approve', 'spec-decline', 'spec-answer'].includes(move.verb)) throw new Refused('BAD_REQUEST', 'only a row decision carries the rows it shows');- return { version: PERSON_REQUEST_VERSION, type: 'person-request', id: document.id, move, ...(document.rows === undefined ? {} : { rows: shownRows(document.rows) }) };+ return { version: PERSON_REQUEST_VERSION, type: 'person-request', id: document.id, move, ...(document.rows === undefined ? {} : { rows: shownRows(document.rows) }),+ ...(document.effect === undefined ? {} : { effect: normalizePersonBarEffect(move.verb, document.effect) }) };}diff --git a/src/person-signing-cli.js b/src/person-signing-cli.jsindex 9a46bc4a..0bc2f19c 100644--- a/src/person-signing-cli.js+++ b/src/person-signing-cli.js@@ -64,7 +64,7 @@ export async function pinRelayAuthority(root, board, io = {}) {* @param {{ id: string }} me* @param {{ verb: string, item?: number, args: any } | null} intent - the request the passkey device shows, or null when it cannot carry this move*/-export async function requireSignedPerson(ctx, board, me, intent, rows) {+export async function requireSignedPerson(ctx, board, me, intent, rows, effect) {if (!personSigning(board).signed) return null;// A board that has not pinned its relay key yet cannot check a passkey stamp, including an off it replayed: pin first.if (!localAuthority(board) && await pinRelayAuthority(ctx.info.root, board, ctx.io) && !personSigning(board).signed) return null;@@ -78,7 +78,7 @@ export async function requireSignedPerson(ctx, board, me, intent, rows) {const where = `${origin}/#board=${relay.board}`;let sent = '';if (intent && me.id !== store.PERSON) {- const request = preparePersonRequest(intent, undefined, rows);+ const request = preparePersonRequest(intent, undefined, rows, effect);try {await ordered(ctx, board, 'proposePersonMove', [{ agentId: me.id, request }]);sent = 'proposed';diff --git a/src/person-signing.js b/src/person-signing.jsindex d7454e6c..3a5fc3f6 100644--- a/src/person-signing.js+++ b/src/person-signing.js@@ -180,7 +180,7 @@ export function proposePersonMove(board, { agentId, request }) {const document = validatePersonRequest(request);return atomic(board, () => {const at = board.clock.now();- const entry = { id: document.id, move: document.move, ...(document.rows ? { rows: document.rows } : {}), by: agentId, at: at.toISOString(), expires: new Date(at.getTime() + PROPOSAL_MS).toISOString() };+ const entry = { id: document.id, move: document.move, ...(document.rows ? { rows: document.rows } : {}), ...(document.effect ? { effect: document.effect } : {}), by: agentId, at: at.toISOString(), expires: new Date(at.getTime() + PROPOSAL_MS).toISOString() };const kept = personProposals(board).filter((proposal) => proposal.id !== document.id);meta(board, PROPOSALS, JSON.stringify([...kept, entry].slice(-KEPT_PROPOSALS)));logEvent(board, agentId, 'person_proposal', null, { request: document.id, verb: document.move.verb });diff --git a/src/relay-presentation.js b/src/relay-presentation.jsindex dee23291..4a5939bb 100644--- a/src/relay-presentation.js+++ b/src/relay-presentation.js@@ -1,3 +1,9 @@+import { previewBarCoverage } from './bar-coverage.js';+import {+ barDigest,+ barReadiness,+} from './bar-readiness.js';+import { mainPolicy } from './trusted-policy.js';/** Device-sealed presentation uses the same API state as the local view [A4,H5,H15]. */import { createHash } from 'node:crypto';import { join } from 'node:path';@@ -55,8 +61,15 @@ function readRelayPresentation(root, providedBoard) {const signed = store.personSigning(board).signed;const ids = signed ? [...loadSpec(root, config).rows.map(row => row.id), ...loadDoctrine(root, config).repo.rows.map(row => `doctrine:${row.id}`)] : [];const personRows = signed ? shownDecisionRows(root, config, ids) : [];+ let personBars = [];+ if (signed) {+ const entries = store.listItems(board, { all: true }).map(item => ({ item, status: barReadiness(board, item, { signature: false }) }));+ const plans = previewBarCoverage(root, entries.map(({ item, status }) => ({ item, coverage: status.signed?.coverage })), mainPolicy(root));+ personBars = entries.map(({ item, status }, index) => ({ id: item.item_id,+ before: { revision: status.revision?.revision ?? 0, digest: barDigest(item) }, ...(plans[index] ? { coverage: plans[index] } : {}) }));+ }return { version: 1, state: { ...store.projectItemThreads(board, state), personRequests: personRequestStatuses(board),- personSigning: { signed }, personProposals, personRows }, config, shouts: store.allShouts(board) }; }+ personSigning: { signed }, personProposals, personRows, personBars }, config, shouts: store.allShouts(board) }; }finally { if (!providedBoard) store.closeBoard(board); }}/** Resolve one shout from the complete history carried only inside the sealed presentation. */diff --git a/src/relay-requests.js b/src/relay-requests.jsindex 68a1a5e6..762e44f5 100644--- a/src/relay-requests.js+++ b/src/relay-requests.js@@ -9,6 +9,15 @@ import { signedRowDecisionsMatch } from './person-row-proof.js';import { parseImplies } from './implies.js';import { validatePersonRequest } from './person-request.js';import { relayMoveActor } from './relay-sender.js';+import {+ barDigest,+ barReadiness,+ barReadySetting,+} from './bar-readiness.js';+import {+ barEffectValues,+ sameBarEffect,+} from './person-bar-effect.js';import { PEOPLE_ENGINE } from './people-engine.js';const INDEX = 'relay_person_requests';@@ -72,7 +81,7 @@ export function receivePersonRequest(board, document, { sequence, at, sender })if (sender?.kind !== 'person' || typeof sender.userId !== 'string' || !sender.userId || sender.userId.length > 256) throw new Refused('RELAY_PERSON_ONLY', 'only the authenticated person can send a relay request; use the paired view with the person session');request = validatePersonRequest(document);// On a board that names approvers, a phone request that acts as the person must come from one [E4].- if (sender.approver === false && ['answer', 'hold', 'spec-approve', 'spec-decline', 'spec-answer', 'fact', 'sentinel-approve', 'sentinel-decline'].includes(request.move?.verb)) {+ if (sender.approver === false && ['answer', 'hold', 'spec-approve', 'spec-decline', 'spec-answer', 'fact', 'sentinel-approve', 'sentinel-decline', 'add', 'edit', 'bar-sign'].includes(request.move?.verb)) {throw new Refused('NOT_APPROVER', `${sender.login ?? 'this person'} is not an approver of this board; ask an approver to answer, hold or decide rows and sentinels`);}} catch (cause) {@@ -108,6 +117,27 @@ function fulfilsIntent(record, move, board) {const args = intent.args;const value = move.args[0];const options = move.args[1];+ const document = JSON.parse(record.encoded);+ if (document.effect && ['add', 'edit', 'bar-sign'].includes(intent.verb)) {+ const verb = intent.verb;+ const effect = document.effect;+ const fields = verb === 'add' ? value : options;+ if (verb !== 'add') {+ if (value !== intent.item) return false;+ const item = store.getItem(board, value);+ const before = { revision: barReadiness(board, item, { signature: false }).revision?.revision ?? 0, digest: barDigest(item) };+ if (!sameBarEffect(effect.before, before)) return false;+ }+ const expectedActor = barReadySetting(board).enabled ? { authority: 'person', session: null, parent: null } : null;+ return move.args.length === (verb === 'add' ? 1 : 2) && fields+ && (verb === 'bar-sign' ? fields.agentId === 'person' : (verb === 'add' ? fields.by : fields.agentId) === (verb === 'add' ? effect.value.by : effect.value.agentId))+ && sameBarEffect(fields.barActor, expectedActor)+ && sameBarEffect(barEffectValues(verb, fields), effect.value)+ && (!args.wait || !fields.checkBaseline || fields.checkBaseline.result !== 'pending')+ && Object.keys(fields).every(key => Object.hasOwn(effect.value, key) || ['by', 'agentId', 'barActor', 'checkBaseline'].includes(key));+ }+ if (personSigning(board).signed && ['add', 'edit', 'bar-sign'].includes(intent.verb)) return false;+if (intent.verb === 'add') return value?.by === 'person' && value.lane === args.lane && value.title === args.title&& value.criterion === (args.criterion ?? '') && value.brief === (args.brief ?? '')&& value.route === (args.route ?? 'strong') && (value.check ?? '') === (args.check ?? '')@@ -229,7 +259,7 @@ export function requestMoveProblem(board, move, { checkExecutorLease = true } =const actor = relayMoveActor(move);if (!['coordinator', 'person'].includes(actor)) return new Refused('PERSON_REQUEST_RECEIPT', 'only the coordinator fulfils an authenticated person request');if (tag.phase === 'execute') {- const expected = { add: 'addItem', shout: 'shout', answer: 'answerDecision', hold: record.move.args.off ? 'releaseLane' : 'holdLane', 'spec-approve': 'recordRowDecisions', 'spec-decline': 'recordRowDecisions', 'spec-answer': 'recordRowDecisions', fact: 'appendFact', 'sentinel-approve': 'decideSentinel', 'sentinel-decline': 'decideSentinel', 'land-waive': 'recordLandingWaiver', signing: 'setPersonSigning' }[record.move.verb];+ const expected = { add: 'addItem', shout: 'shout', answer: 'answerDecision', hold: record.move.args.off ? 'releaseLane' : 'holdLane', 'spec-approve': 'recordRowDecisions', 'spec-decline': 'recordRowDecisions', 'spec-answer': 'recordRowDecisions', fact: 'appendFact', 'sentinel-approve': 'decideSentinel', 'sentinel-decline': 'decideSentinel', 'land-waive': 'recordLandingWaiver', signing: 'setPersonSigning', edit: 'editItem', 'bar-sign': 'signBar' }[record.move.verb];if (move.operation !== expected || !fulfilsIntent(record, move, board)) return new Refused('PERSON_REQUEST_RECEIPT', 'the ordinary move does not fulfil this request; execute its original CLI intent');}if (move.engine >= 6 && ['claim', 'repo-request', 'refuse'].includes(tag.phase) && !fulfilsStage(record, move, tag)) return new Refused('PERSON_REQUEST_RECEIPT', 'publish only the exact stage for this authenticated phone request');