Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.
JavaScript agentic-codingai-agentsai-governanceautonomous-agentsclaude-codeclicode-reviewcodexcoding-agentsdeveloper-toolsgit-hooksllmlocal-firstmulti-agentsoftware-factoryspec-driven-developmentverificationvibe-coding
refactor(cli): extract queued lease protocol [V4,H16]
Corey Olson1ed18af278fd
diff --git a/src/cli.js b/src/cli.jsindex d4d05a51..5e256f5f 100644--- a/src/cli.js+++ b/src/cli.js@@ -1,3 +1,4 @@+import { createQueuedItemLease } from "./queued-item-lease.js";import * as personIdentity from './person.js';import { dependencyValues } from './item-dependencies.js';import { computedReturnArgs } from './computed-conflict-return.js';@@ -1675,50 +1676,9 @@ export function resourceAgent(ctx) {return ctx.info.isMain ? COORDINATOR : withBoard(ctx, board => store.agentAt(board, ctx.info.root)?.agent_id);}-/** Keep only this queued command's live item lease, using ordinary ordered board moves. */+/** Keep the public queue adapter while its lease protocol lives in a bounded module. */export function queuedItemLease(ctx, initial, agentId, kind, admission = null) {- const report = gateWaitReporter(ctx.io);- // Naming somebody else's check remains read-only; it never extends their build claim.- if (kind === 'build' && (initial.item_status !== 'claimed' || initial.item_owner !== agentId)) return report;- const review = kind === 'review';- // Accepted items retain their former reviewer as history, not a renewable reservation.- if (review && (initial.item_status !== 'submitted' || initial.item_review_by !== agentId)) return report;- const field = review ? 'item_review_until' : 'item_lease_until';- const owner = review ? 'item_review_by' : 'item_owner';- const status = review ? 'submitted' : 'claimed';- const leaseMs = review ? ctx.config.reviewLeaseMs : ctx.config.leaseMs;- const expected = { digest: initial.item_frozen_digest, commit: initial.item_commit };- let confirmedLeaseUntil = '';- return async (state) => {- if (!state.admitted) report(state);- const now = ctx.clock.now().getTime();- // Queue polling is frequent; reopen the board only when renewal is due or admission starts.- if (!state.admitted && Date.parse(confirmedLeaseUntil) - now > leaseMs / 2) {- return { leaseUntil: confirmedLeaseUntil };- }- return await withBoard(ctx, async (board) => {- const current = store.getItem(board, initial.item_id);- const expires = Date.parse(current[field]);- if (current.item_status !== status || current[owner] !== agentId || !Number.isFinite(expires) || expires <= now- || current.item_frozen_digest !== expected.digest || current.item_commit !== expected.commit) {- throw new Refused('ITEM_LEASE_LOST', `the queued ${review ? 'review' : 'build'} lease for #${initial.item_id} changed or expired; claim or reserve the item again before retrying`);- }- if (state.admitted || expires - now <= leaseMs / 2) {- const witness = state.admitted && admission ? { id: randomUUID(), commit: admission.commit, tree: admission.tree } : null;- const result = await ordered(ctx, board, review ? 'reserveReview' : 'claim', [initial.item_id, {- agentId, leaseMs,- ...(witness ? { submitAdmission: witness } : {}),- ...(review ? { policy: ctx.config.verify.policy, familyPolicy: ctx.config.verify.family }- : { lane: current.item_lane, freeze: claimFreezer(ctx), head: headCommit(ctx.info.root) }),- }]);- confirmedLeaseUntil = review ? result.item_review_until : result.leaseUntil;- if (witness) admission.id = witness.id;- return { leaseUntil: confirmedLeaseUntil };- }- confirmedLeaseUntil = current[field];- return { leaseUntil: confirmedLeaseUntil };- });- };+ return createQueuedItemLease(ctx, initial, agentId, kind, admission, { ordered, withBoard, claimFreezer });}/** Print the file and reason when conservative uncertainty reserves browser capacity.diff --git a/src/queued-item-lease.js b/src/queued-item-lease.jsnew file mode 100644index 00000000..9516a357--- /dev/null+++ b/src/queued-item-lease.js@@ -0,0 +1,52 @@+import { randomUUID } from "node:crypto";+import * as store from "./board.js";+import { headCommit } from "./git.js";+import { gateWaitReporter } from "./gate-wait.js";+import { Refused } from "./refused.js";++/** Keep only this queued command's live item lease, using ordinary ordered board moves. */+export function createQueuedItemLease(ctx, initial, agentId, kind, admission, { ordered, withBoard, claimFreezer }) {+ const report = gateWaitReporter(ctx.io);+ // Naming somebody else's check remains read-only; it never extends their build claim.+ if (kind === 'build' && (initial.item_status !== 'claimed' || initial.item_owner !== agentId)) return report;+ const review = kind === 'review';+ // Accepted items retain their former reviewer as history, not a renewable reservation.+ if (review && (initial.item_status !== 'submitted' || initial.item_review_by !== agentId)) return report;+ const field = review ? 'item_review_until' : 'item_lease_until';+ const owner = review ? 'item_review_by' : 'item_owner';+ const status = review ? 'submitted' : 'claimed';+ const leaseMs = review ? ctx.config.reviewLeaseMs : ctx.config.leaseMs;+ const expected = { digest: initial.item_frozen_digest, commit: initial.item_commit };+ let confirmedLeaseUntil = '';+ return async (state) => {+ if (!state.admitted) report(state);+ const now = ctx.clock.now().getTime();+ // Queue polling is frequent; reopen the board only when renewal is due or admission starts.+ if (!state.admitted && Date.parse(confirmedLeaseUntil) - now > leaseMs / 2) {+ return { leaseUntil: confirmedLeaseUntil };+ }+ return await withBoard(ctx, async (board) => {+ const current = store.getItem(board, initial.item_id);+ const expires = Date.parse(current[field]);+ if (current.item_status !== status || current[owner] !== agentId || !Number.isFinite(expires) || expires <= now+ || current.item_frozen_digest !== expected.digest || current.item_commit !== expected.commit) {+ throw new Refused('ITEM_LEASE_LOST', `the queued ${review ? 'review' : 'build'} lease for #${initial.item_id} changed or expired; claim or reserve the item again before retrying`);+ }+ if (state.admitted || expires - now <= leaseMs / 2) {+ const witness = state.admitted && admission ? { id: randomUUID(), commit: admission.commit, tree: admission.tree } : null;+ const result = await ordered(ctx, board, review ? 'reserveReview' : 'claim', [initial.item_id, {+ agentId, leaseMs,+ ...(witness ? { submitAdmission: witness } : {}),+ ...(review ? { policy: ctx.config.verify.policy, familyPolicy: ctx.config.verify.family }+ : { lane: current.item_lane, freeze: claimFreezer(ctx), head: headCommit(ctx.info.root) }),+ }]);+ confirmedLeaseUntil = review ? result.item_review_until : result.leaseUntil;+ if (witness) admission.id = witness.id;+ return { leaseUntil: confirmedLeaseUntil };+ }+ confirmedLeaseUntil = current[field];+ return { leaseUntil: confirmedLeaseUntil };+ });+ };+}+