Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.
JavaScript agentic-codingai-agentsai-governanceautonomous-agentsclaude-codeclicode-reviewcodexcoding-agentsdeveloper-toolsgit-hooksllmlocal-firstmulti-agentsoftware-factoryspec-driven-developmentverificationvibe-coding
feat(view): shout feed names coordinator and item recipients [N26,A5]
Corey Olson381c49dda11c
diff --git a/src/cockpit.js b/src/cockpit.jsindex 1be631be..f7fceeaf 100644--- a/src/cockpit.js+++ b/src/cockpit.js@@ -1321,6 +1321,12 @@ function render() {// The coordinator's mark is the board's own: a square with the Pullboard logo, so it stands out from the agents.const LEAD = '<svg viewBox="0 0 64 64" aria-hidden="true"><path fill="currentColor" d="M8 7h35a6 6 0 0 1 6 6v7H8a5 5 0 0 1-5-5v-3a5 5 0 0 1 5-5Z"/><rect width="56" height="14" x="3" y="25" fill="var(--accent)" rx="5"/><path fill="currentColor" d="M8 43h35a6 6 0 0 1 6 6v8H8a5 5 0 0 1-5-5v-4a5 5 0 0 1 5-5Z"/></svg>';const lead = (from) => from === 'coordinator';+ // A shout's recipient in product words: the reserved coordinator+person address and item:<id> are internal.+ const shoutTo = (to) => {+ if (to === 'coordinator+person') return 'coordinator and you';+ const item = /^item:([1-9]\\d*)$/.exec(String(to));+ return item ? '<a class="ref" href="' + esc(itemAddress(item[1], view.root)) + '" data-go="item:' + item[1] + '">#' + item[1] + '</a>' : shoutAgentName(to);+ };// Opened from the status bar's unread, the feed is exactly those shouts, the ones after the mark the person had.const unread = view.unread?.root === view.root ? view.unread : null;const addressed = addressedShouts.get(JSON.stringify([view.root, view.shout]));@@ -1346,7 +1352,7 @@ function render() {// feed's copy carries the band and the id an answer's link lands on, so an ask shown twice never repeats an id.// The person's own shout is signed "you", plainly, never as the coordinator that ran it.const card = (x, tail = '', inFeed = true) => '<article class="shout h' + hue(x.shout_from) + (lead(x.shout_from) ? ' lead' : '') + (openShouts.has(x.shout_id) ? ' open' : '') + (inFeed && x.shout_id === view.shout ? ' found' : '') + '"' + (inFeed ? ' id="shout-' + x.shout_id + '"' : '') + ' data-shout-id="' + x.shout_id + '">'- + (lead(x.shout_from) ? '<span class="avatar">' + LEAD + '</span>' : '<span class="avatar' + (initials(x.shout_from).length > 3 ? ' wide' : '') + '" aria-hidden="true">' + esc(initials(x.shout_from)) + '</span>') + '<div class="shout-main">' + (inFeed && x.shout_id === view.shout ? '<h2 class="visually-hidden">Shout #' + x.shout_id + '</h2>' : '') + '<header><b class="who">' + (x.shout_from === 'person' ? 'you' : shoutAgentName(x.shout_from)) + '</b><span class="to">→ ' + shoutAgentName(x.shout_to) + '</span>'+ + (lead(x.shout_from) ? '<span class="avatar">' + LEAD + '</span>' : '<span class="avatar' + (initials(x.shout_from).length > 3 ? ' wide' : '') + '" aria-hidden="true">' + esc(initials(x.shout_from)) + '</span>') + '<div class="shout-main">' + (inFeed && x.shout_id === view.shout ? '<h2 class="visually-hidden">Shout #' + x.shout_id + '</h2>' : '') + '<header><b class="who">' + (x.shout_from === 'person' ? 'you' : shoutAgentName(x.shout_from)) + '</b><span class="to">→ ' + shoutTo(x.shout_to) + '</span>'+ (itemOf(x) ? '<span class="item">#' + esc(itemOf(x)) + '</span>' : '') + mark(x) + '<time class="long" data-ago="' + esc(x.shout_at) + '" title="' + esc(when(x.shout_at)) + '">' + agoLong(x.shout_at) + '</time></header>'+ '<div class="text">' + rich(x.shout_text, titles) + '</div><button class="more" data-more type="button">' + (openShouts.has(x.shout_id) ? 'less' : 'more') + '</button>' + (inFeed ? band(x) + heardBy(x) : '') + evidence(x) + tail + '</div></article>';$('feed').innerHTML = (view.shout !== null && !feedShouts.some((entry) => entry.shout_id === view.shout) ? '<p class="empty" id="shout-address-status" role="status">' + esc(addressed?.error || 'Loading shout #' + view.shout + '…') + '</p>' : '') + bar + (heard.length ? dayRules(heard, (x) => x.shout_at, card) : '<div class="empty">' + (unread ? 'No unread shouts.' : view.agent ? 'No shouts with ' + esc(agentName(view.agent)) + ' among the last forty.' : 'No shouts yet.') + '</div>');diff --git a/test/cockpit/agents.test.js b/test/cockpit/agents.test.jsindex 8fc7460b..9f4d40e7 100644--- a/test/cockpit/agents.test.js+++ b/test/cockpit/agents.test.js@@ -152,6 +152,43 @@ test('the agents panel is rows for work and pills for idle [N26]', { timeout: 12}});+test('the shout feed names a seat broadcast and an item shout in product words [N26,A5]', { timeout: 120_000 }, async (t) => {+ const executable = chromeExecutable();+ if (!executable) return t.skip('Install Chrome or set PULLBOARD_CHROME for rendered feed checks.');+ const box = machine();+ const alpha = project(box, 'recipients');+ box.run(alpha.repo, 'add', 'web', 'Header', '--specs', 'G1', '--criterion', 'renders');+ // A registered seat's shout to all is stored at coordinator+person; an item shout is stored at item:<id>.+ box.run(alpha.web, 'shout', 'all', 'Seat broadcast for the coordinator');+ box.run(alpha.web, 'shout', '--item', '1', 'Item shout for its audience');+ const view = await startView(box);+ const profile = mkdtempSync(join(tmpdir(), 'pullboard-recipients-chrome-'));+ let chrome;+ try {+ chrome = await openSnapshotChrome(executable, view.link.href, profile);+ await chrome.waitFor('typeof data !== "undefined" && data?.project?.shouts?.length >= 2');+ await chrome.click("document.querySelector('[data-tab=shouts]')");+ await chrome.waitFor('document.querySelectorAll("#feed .shout").length >= 2');+ for (const width of [1280, 375]) {+ await shoutsAt(chrome, width, 'light');+ const at = `${width}px`;+ const feed = JSON.parse(await chrome.stable(`JSON.stringify({+ tos: [...document.querySelectorAll('#feed .shout .to')].map((to) => to.textContent),+ link: document.querySelector('#feed .shout .to a.ref')?.dataset.go ?? null,+ text: document.querySelector('#feed').innerText }) `));+ assert.ok(feed.tos.includes('→ coordinator and you'), `${at}: a seat broadcast reads coordinator and you: ${JSON.stringify(feed.tos)}`);+ assert.ok(feed.tos.includes('→ #1'), `${at}: an item shout reads its id: ${JSON.stringify(feed.tos)}`);+ assert.equal(feed.link, 'item:1', `${at}: the item id links to the item`);+ assert.ok(!feed.text.includes('coordinator+person') && !feed.text.includes('item:'), `${at}: no card shows the internal address`);+ }+ assert.deepEqual(chrome.exceptions, [], 'the page raises no uncaught exception');+ } finally {+ if (chrome) await closeSnapshotChrome(chrome);+ rmSync(profile, { recursive: true, force: true });+ await view.stop();+ }+});+test('agent model display names follow the API on phone and desktop [O8,N26]', { timeout: 150_000 }, async (t) => {const executable = chromeExecutable();assert.ok(executable, 'Chrome is required for model-name viewport proof');