Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.
JavaScript agentic-codingai-agentsai-governanceautonomous-agentsclaude-codeclicode-reviewcodexcoding-agentsdeveloper-toolsgit-hooksllmlocal-firstmulti-agentsoftware-factoryspec-driven-developmentverificationvibe-coding
test(hosted): prove the WebKit local-page opening route [H5,N26]
Corey Olson677e8510e9b7
diff --git a/test/hosted-shapes-fixture.js b/test/hosted-shapes-fixture.jsindex dc68d853..2a4321eb 100644--- a/test/hosted-shapes-fixture.js+++ b/test/hosted-shapes-fixture.js@@ -270,16 +270,22 @@ export function judge(cell, seen, ineffective = []) {* Open one cell's page, wait for its screen and read it.** @param {{ newPage: Function }} context - the identity's browser context- * @param {object} options - route, phone, bootstrap+ * @param {object} options - route, phone, bootstrap, and the owned local view's document route when this cell has one* @param {boolean} wantsBoard - wait for the board rather than a settled blocker*/-export async function visit(context, { route, phone, bootstrap }, wantsBoard) {+export async function visit(context, { route, phone, bootstrap, localView = null }, wantsBoard) {const page = await context.newPage({ route, phone, bootstrap });try {const started = Date.now();await page.navigate(HOSTED + '/');if (wantsBoard) {- const shown = await page.poll(`(${READ_SCREEN}).board`, BOARD_MS + 2_000);+ let shown = await page.poll(`(${READ_SCREEN}).board || ${localView ? `((document.querySelector('#local-note')?.dataset.state === 'local-open' || document.querySelector('[data-part="local-command"]')?.hidden === false) && (${READ_SCREEN}).commands.includes('pullboard view'))` : 'false'}`, BOARD_MS + 2_000);+ if (shown && localView && !(await page.evaluate(READ_SCREEN)).board) {+ // The person follows the displayed pullboard view step. This fixture already owns that running view and its+ // printed address: open its authenticated document route, never inject a key or relax the board assertion.+ await page.navigate(localView);+ shown = await page.poll(`(${READ_SCREEN}).board`, BOARD_MS + 2_000);+ }const seen = await page.evaluate(READ_SCREEN);return { ...seen, ms: shown ? Date.now() - started : null, exceptions: page.exceptions.length };}diff --git a/test/hosted-shapes.test.js b/test/hosted-shapes.test.jsindex 359cb6cf..247108bf 100644--- a/test/hosted-shapes.test.js+++ b/test/hosted-shapes.test.js@@ -495,120 +495,6 @@ const CAUSES = ['webkit:phone/signed-in/paired/mixed/fresh',],},- {- item: 977,- cause: "WebKit blocks https://app.pullboard.dev from reaching http://127.0.0.1:4890 as mixed content, so the board computer's own view is never found",- cells: [- 'webkit:board-view/signed-in/paired/approval/fresh',- 'webkit:board-view/signed-in/paired/approval/stale-key',- 'webkit:board-view/signed-in/paired/approval/stale-pairing',- 'webkit:board-view/signed-in/paired/excluded/fresh',- 'webkit:board-view/signed-in/paired/excluded/stale-key',- 'webkit:board-view/signed-in/paired/excluded/stale-pairing',- 'webkit:board-view/signed-in/paired/healthy/fresh',- 'webkit:board-view/signed-in/paired/healthy/stale-key',- 'webkit:board-view/signed-in/paired/healthy/stale-pairing',- 'webkit:board-view/signed-in/paired/mixed/fresh',- 'webkit:board-view/signed-in/paired/mixed/stale-key',- 'webkit:board-view/signed-in/paired/mixed/stale-pairing',- 'webkit:board-view/signed-in/paired/none/fresh',- 'webkit:board-view/signed-in/paired/none/stale-key',- 'webkit:board-view/signed-in/paired/none/stale-pairing',- 'webkit:board-view/signed-in/paired/oversize/fresh',- 'webkit:board-view/signed-in/paired/oversize/stale-key',- 'webkit:board-view/signed-in/paired/oversize/stale-pairing',- 'webkit:board-view/signed-in/revoked/approval/fresh',- 'webkit:board-view/signed-in/revoked/approval/stale-key',- 'webkit:board-view/signed-in/revoked/approval/stale-pairing',- 'webkit:board-view/signed-in/revoked/excluded/fresh',- 'webkit:board-view/signed-in/revoked/excluded/stale-key',- 'webkit:board-view/signed-in/revoked/excluded/stale-pairing',- 'webkit:board-view/signed-in/revoked/healthy/fresh',- 'webkit:board-view/signed-in/revoked/healthy/stale-key',- 'webkit:board-view/signed-in/revoked/healthy/stale-pairing',- 'webkit:board-view/signed-in/revoked/mixed/fresh',- 'webkit:board-view/signed-in/revoked/mixed/stale-key',- 'webkit:board-view/signed-in/revoked/mixed/stale-pairing',- 'webkit:board-view/signed-in/revoked/none/fresh',- 'webkit:board-view/signed-in/revoked/none/stale-key',- 'webkit:board-view/signed-in/revoked/none/stale-pairing',- 'webkit:board-view/signed-in/revoked/oversize/fresh',- 'webkit:board-view/signed-in/revoked/oversize/stale-key',- 'webkit:board-view/signed-in/revoked/oversize/stale-pairing',- 'webkit:board-view/signed-in/unpaired/approval/fresh',- 'webkit:board-view/signed-in/unpaired/approval/stale-key',- 'webkit:board-view/signed-in/unpaired/approval/stale-pairing',- 'webkit:board-view/signed-in/unpaired/excluded/fresh',- 'webkit:board-view/signed-in/unpaired/excluded/stale-key',- 'webkit:board-view/signed-in/unpaired/excluded/stale-pairing',- 'webkit:board-view/signed-in/unpaired/healthy/fresh',- 'webkit:board-view/signed-in/unpaired/healthy/stale-key',- 'webkit:board-view/signed-in/unpaired/healthy/stale-pairing',- 'webkit:board-view/signed-in/unpaired/mixed/fresh',- 'webkit:board-view/signed-in/unpaired/mixed/stale-key',- 'webkit:board-view/signed-in/unpaired/mixed/stale-pairing',- 'webkit:board-view/signed-in/unpaired/none/fresh',- 'webkit:board-view/signed-in/unpaired/none/stale-key',- 'webkit:board-view/signed-in/unpaired/none/stale-pairing',- 'webkit:board-view/signed-in/unpaired/oversize/fresh',- 'webkit:board-view/signed-in/unpaired/oversize/stale-key',- 'webkit:board-view/signed-in/unpaired/oversize/stale-pairing',- 'webkit:board-view/signed-out/paired/approval/fresh',- 'webkit:board-view/signed-out/paired/approval/stale-key',- 'webkit:board-view/signed-out/paired/approval/stale-pairing',- 'webkit:board-view/signed-out/paired/excluded/fresh',- 'webkit:board-view/signed-out/paired/excluded/stale-key',- 'webkit:board-view/signed-out/paired/excluded/stale-pairing',- 'webkit:board-view/signed-out/paired/healthy/fresh',- 'webkit:board-view/signed-out/paired/healthy/stale-key',- 'webkit:board-view/signed-out/paired/healthy/stale-pairing',- 'webkit:board-view/signed-out/paired/mixed/fresh',- 'webkit:board-view/signed-out/paired/mixed/stale-key',- 'webkit:board-view/signed-out/paired/mixed/stale-pairing',- 'webkit:board-view/signed-out/paired/none/fresh',- 'webkit:board-view/signed-out/paired/none/stale-key',- 'webkit:board-view/signed-out/paired/none/stale-pairing',- 'webkit:board-view/signed-out/paired/oversize/fresh',- 'webkit:board-view/signed-out/paired/oversize/stale-key',- 'webkit:board-view/signed-out/paired/oversize/stale-pairing',- 'webkit:board-view/signed-out/revoked/approval/fresh',- 'webkit:board-view/signed-out/revoked/approval/stale-key',- 'webkit:board-view/signed-out/revoked/approval/stale-pairing',- 'webkit:board-view/signed-out/revoked/excluded/fresh',- 'webkit:board-view/signed-out/revoked/excluded/stale-key',- 'webkit:board-view/signed-out/revoked/excluded/stale-pairing',- 'webkit:board-view/signed-out/revoked/healthy/fresh',- 'webkit:board-view/signed-out/revoked/healthy/stale-key',- 'webkit:board-view/signed-out/revoked/healthy/stale-pairing',- 'webkit:board-view/signed-out/revoked/mixed/fresh',- 'webkit:board-view/signed-out/revoked/mixed/stale-key',- 'webkit:board-view/signed-out/revoked/mixed/stale-pairing',- 'webkit:board-view/signed-out/revoked/none/fresh',- 'webkit:board-view/signed-out/revoked/none/stale-key',- 'webkit:board-view/signed-out/revoked/none/stale-pairing',- 'webkit:board-view/signed-out/revoked/oversize/fresh',- 'webkit:board-view/signed-out/revoked/oversize/stale-key',- 'webkit:board-view/signed-out/revoked/oversize/stale-pairing',- 'webkit:board-view/signed-out/unpaired/approval/fresh',- 'webkit:board-view/signed-out/unpaired/approval/stale-key',- 'webkit:board-view/signed-out/unpaired/approval/stale-pairing',- 'webkit:board-view/signed-out/unpaired/excluded/fresh',- 'webkit:board-view/signed-out/unpaired/excluded/stale-key',- 'webkit:board-view/signed-out/unpaired/excluded/stale-pairing',- 'webkit:board-view/signed-out/unpaired/healthy/fresh',- 'webkit:board-view/signed-out/unpaired/healthy/stale-key',- 'webkit:board-view/signed-out/unpaired/healthy/stale-pairing',- 'webkit:board-view/signed-out/unpaired/mixed/fresh',- 'webkit:board-view/signed-out/unpaired/mixed/stale-key',- 'webkit:board-view/signed-out/unpaired/mixed/stale-pairing',- 'webkit:board-view/signed-out/unpaired/none/fresh',- 'webkit:board-view/signed-out/unpaired/none/stale-key',- 'webkit:board-view/signed-out/unpaired/none/stale-pairing',- 'webkit:board-view/signed-out/unpaired/oversize/fresh',- 'webkit:board-view/signed-out/unpaired/oversize/stale-key',- 'webkit:board-view/signed-out/unpaired/oversize/stale-pairing',- ],- },{item: 978,cause: "the page tells an unpaired browser to run pullboard relay pair, which does not pair it",@@ -1030,7 +916,8 @@ async function runCells(engine, built, boardCells, report, ineffective) {const bootstrap = storedScript(cell.stored, { keys: browser === 'paired' ? keys : null, boards: boardIds });const route = front.route(cell.account === 'signed-in' ? session : null, cell.where === 'board-view' ? view.base : null);let seen;- try { seen = await visit(context, { route, phone: cell.where === 'phone', bootstrap }, want.board); }+ try { seen = await visit(context, { route, phone: cell.where === 'phone', bootstrap,+ localView: cell.where === 'board-view' ? built.view.base + '/local/view' : null }, want.board); }catch (error) { seen = { board: false, approval: false, words: 'visit failed: ' + error.message, commands: [], signIn: false, ms: null }; }let problem = judge(cell, seen, ineffective);// A board that arrived but over the bar is measured once more: one slow sample on a loaded machine is noise, twodiff --git a/test/relay-local-origin.test.js b/test/relay-local-origin.test.jsnew file mode 100644index 00000000..fc5c3e0f--- /dev/null+++ b/test/relay-local-origin.test.js@@ -0,0 +1,103 @@+/** A hosted WebKit page opens an authenticated loopback board without a mixed-content fetch [H5,N26]. */+import assert from 'node:assert/strict';+import { test } from 'node:test';+import { createRelayBrowserHandler } from '../relay/browser-page.js';+import { Refused } from '../src/refused.js';+import { machine, project, startView } from './cockpit/fixture.js';+import { findWebkitExecutable, startWebkit } from './webkit-fixture.js';+import { BOARD_ITEM, visit } from './hosted-shapes-fixture.js';++const HOSTED = 'https://app.pullboard.dev';++test('the hosted page finds this computer\'s view in WebKit without an http request from https [H5,N26]', async (t) => {+ if (!findWebkitExecutable()) return t.skip('No Playwright WebKit build; set PULLBOARD_WEBKIT to exercise the real browser route.');+ const box = machine();+ const board = project(box, 'webkit-local');+ const title = 'Private board reached through the local page';+ box.run(board.repo, 'add', 'web', title, '--specs', 'G1');+ box.run(board.repo, 'add', 'web', BOARD_ITEM, '--specs', 'G1');+ const view = await startView(box);+ let webkit, page;+ t.after(async () => {+ try { await page?.close(); }+ finally { try { await webkit?.close(); } finally { await view.stop(); } }+ });+ const browserHandler = createRelayBrowserHandler({ authenticate: async () => { throw new Refused('AUTH_REQUIRED', 'sign in'); } });+ const failures = [];+ webkit = await startWebkit();+ const options = {+ prepare: async (target) => {+ await target('Network.enable');+ await target('Page.enable');+ await target('Runtime.enable');+ await target('Page.setTouchEmulationEnabled', { enabled: false });+ await target('Page.setBootstrapScript', { source: `if (location.origin === ${JSON.stringify(HOSTED)}) {+ window.localFetches = []; const nativeFetch = window.fetch.bind(window);+ window.fetch = (input, init) => { const url = String(typeof input === 'string' ? input : input.url);+ if (url.startsWith('http:')) window.localFetches.push(url); return nativeFetch(input, init); };+ }` });+ await target('Network.setInterceptionEnabled', { enabled: true });+ // Only the hosted HTTPS assets are supplied. The real browser talks directly to the owned loopback view.+ await target('Network.addInterception', { url: '^https://app\\.pullboard\\.dev/', isRegex: true, stage: 'request' });+ },+ onMessage: (message, target) => {+ if (message.method !== 'Network.requestIntercepted') return;+ const { requestId, request } = message.params;+ void (async () => {+ assert.equal(new URL(request.url).origin, HOSTED, 'loopback traffic is never intercepted or Node-forwarded');+ let status = 404, headers = { 'content-type': 'text/plain' }, body = '';+ await browserHandler({ method: request.method, url: request.url, headers: request.headers }, {+ /** Retain the production asset's status and security headers. */+ writeHead(code, values) { status = code; headers = values; },+ /** Retain the asset bytes without forwarding a network request. */+ end(value) { body = value ?? ''; },+ });+ await target('Network.interceptRequestWithResponse', { requestId, status, statusText: 'OK', headers,+ mimeType: headers['content-type'].split(';')[0], base64Encoded: true, content: Buffer.from(body).toString('base64') });+ })().catch(error => { failures.push(error.message); void target('Network.interceptRequestWithError', { requestId, errorType: 'General' }).catch(() => {}); });+ },+ };+ page = await webkit.newPage(options);+ // A genuine top-level round trip learns this fixture's arbitrary port and tab secret, without injecting a key.+ await page.navigate(view.base + '/local/connect');+ try {+ await page.waitFor(`location.origin === ${JSON.stringify(HOSTED)} && document.readyState === 'complete'+ && document.querySelector('#local-note')?.dataset.state !== 'looking' && !document.body.classList.contains('loading')`, 5000);+ } catch (error) {+ console.log(JSON.stringify({ failures, exceptions: page.exceptions,+ runtime: await page.evaluate('({ ready:document.readyState, live:document.querySelector("#live")?.textContent, state:document.querySelector("#local-note")?.dataset.state, loading:document.body.className, browser:hostedBrowser(navigator), phone:document.documentElement.dataset.relayDevice })') }));+ throw error;+ }+ const seen = await page.evaluate(`({ state: document.querySelector('#local-note').dataset.state,+ words: document.querySelector('#local-note').textContent.trim(),+ open: !document.querySelector('#local-note-view').parentElement.hidden,+ href: document.querySelector('#local-note-view').href,+ fetches: window.localFetches, fragment: location.hash })`);+ assert.notEqual(await page.evaluate('document.documentElement.dataset.relayDevice'), 'phone', 'the regression exercises a desktop WebKit page');+ assert.equal(seen.open, true, `the hosted page gives a visible local-board action: ${seen.words}`);+ assert.equal(seen.href, view.base + '/local/view', 'the action keeps the actual known loopback port');+ assert.deepEqual(seen.fetches, [], 'the HTTPS document never tries an HTTP subresource request');+ assert.equal(seen.fragment, '', 'the round-trip secret was removed before displaying the action');+ assert.equal(await page.evaluate('!document.querySelector("#local-note-go").parentElement.hidden'), true, 'opening a local board does not remove relay sign-in');+ await page.evaluate('document.querySelector("#local-note-view").click()');+ await page.waitFor(`location.origin === ${JSON.stringify(view.base)} && document.body.innerText.includes(${JSON.stringify(title)})`);+ assert.equal((await fetch(view.base + '/')).status, 403, 'the same local view still refuses an unauthenticated visit');+ await page.close();+ page = await webkit.newPage(options);+ await page.navigate(HOSTED + '/');+ await page.waitFor('document.querySelector("#local-note")?.dataset.state === "local-open" && document.readyState === "complete"');+ const fresh = await page.evaluate('({ command:document.querySelector("#local-note-code").textContent, commandVisible:!document.querySelector("[data-part=command]").hidden, signIn:!document.querySelector("#local-note-go").parentElement.hidden, fetches:window.localFetches })');+ assert.equal(fresh.command, 'pullboard view', 'a first visit without a known port gives the command that opens the actual view');+ assert.equal(fresh.commandVisible, true);+ assert.equal(fresh.signIn, true, 'a first-visit Safari user can still sign in for shared boards');+ assert.deepEqual(fresh.fetches, [], 'first visits do not probe a guessed port');+ await page.close();+ const journey = await visit({ newPage: async () => {+ page = await webkit.newPage(options);+ return { ...page, poll: (expression, timeout) => page.waitFor(expression, timeout) };+ } }, { phone: false, localView: view.base + '/local/view' }, true);+ page = null; // visit owns and closes this page.+ assert.equal(journey.board, true, 'the hosted matrix follows the shown local-opening step and still requires the real private board');+ assert.ok(journey.ms <= 3000, `the matrix local-opening journey took ${journey.ms}ms`);+ assert.deepEqual(failures, [], 'the production hosted assets were served without forwarding local traffic');+});