Skip to content

Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.

fix(hooks): use the refrozen sign-off recovery [C1,C7]

Corey Olson734cff25b50f
diff --git a/src/commit-signoff.js b/src/commit-signoff.js
index 99dc5cba..35ff6b91 100644
--- a/src/commit-signoff.js
+++ b/src/commit-signoff.js
@@ -52,12 +52,11 @@ function signedByAuthor(message, author) {
});
}
-/** Keep the missing-sign-off refusal to one line with the concrete fix and contributor guide. */
+/** Keep the missing-sign-off refusal to one line with the concrete fix [C1]. */
function signoffProblem(message, author, maintainers, commit = null) {
if (maintainers.includes(author.email) || signedByAuthor(message, author)) return null;
return 'pullboard sign-off: ' + (commit ? 'commit ' + commit.slice(0, 12) : 'this outside commit')
- + ' needs Signed-off-by matching its author; git commit --amend -s; see '
- + '[CONTRIBUTING: How to sign off](CONTRIBUTING.md#how-to-sign-off-step-by-step)';
+ + ' needs Signed-off-by matching its author; git commit --amend -s';
}
/** Check every new non-merge commit; a merge wrapper does not substitute for its parents. */
diff --git a/test/commit-msg.test.js b/test/commit-msg.test.js
index efd7d857..8813427c 100644
--- a/test/commit-msg.test.js
+++ b/test/commit-msg.test.js
@@ -40,7 +40,6 @@ test('an outside commit without a sign-off is refused with its fix [C1,C7]', ()
const missing = box.tryGit(repo, 'commit', '-q', '-m', 'chore: contribute outside work');
assert.notEqual(missing.status, 0, 'the installed commit-msg hook must refuse an unsigned outside author');
assert.match(missing.stderr, /git commit --amend -s/u);
- assert.match(missing.stderr, /CONTRIBUTING\.md#how-to-sign-off-step-by-step/u);
assert.equal(missing.stderr.trim().split('\n').length, 1, 'the refusal is one actionable line');
const wrong = box.tryGit(repo, 'commit', '-q', '-s', '-m', 'chore: contribute outside work');
assert.notEqual(wrong.status, 0, 'the member committer sign-off cannot stand in for the outside author');
@@ -82,7 +81,6 @@ test('an outside commit without a sign-off is refused with its fix [C1,C7]', ()
assert.equal(refused.status, 1, refused.failure || refused.stderr);
assert.ok(refused.stderr.includes(unsigned.slice(0, 12)), 'CI names the earlier unsigned commit, not just HEAD');
assert.match(refused.stderr, /git commit --amend -s/u);
- assert.match(refused.stderr, /CONTRIBUTING\.md#how-to-sign-off-step-by-step/u);
assert.equal(refused.stderr.trim().split('\n').length, 1);
box.git(incoming, 'reset', '--soft', base);
box.git(incoming, 'commit', '-q', '-m', 'chore: sign the whole contribution',