Skip to content

Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.

fix(core): reuse verdict rows during withdrawal projection [C7]

Corey Olson7657c5262da0
diff --git a/src/verdict-reviews.js b/src/verdict-reviews.js
index 52051848..ecc59578 100644
--- a/src/verdict-reviews.js
+++ b/src/verdict-reviews.js
@@ -25,8 +25,8 @@ export function verdictReviewProblem(review, commit, { checked } = {}) {
*/
export function verdictsFor(board, id) {
const verdicts = board.db.prepare('SELECT * FROM verdict WHERE item_id = ? ORDER BY verdict_id').all(id);
- const receipts = board.db.prepare("SELECT event_kind, event_detail FROM event WHERE item_id = ? AND event_kind IN ('accept', 'reject') ORDER BY event_id").all(id);
- const withdrawals = verdictWithdrawals(board, id);
+ const receipts = board.db.prepare("SELECT event_id, event_kind, event_detail FROM event WHERE item_id = ? AND event_kind IN ('accept', 'reject') ORDER BY event_id").all(id);
+ const withdrawals = verdictWithdrawals(board, id, verdicts.map((verdict, index) => ({ verdict, event: receipts[index] })));
return verdicts.map((verdict, index) => {
let detail = {};
try { detail = JSON.parse(receipts[index]?.event_detail ?? '{}'); } catch { /* Malformed legacy details remain unknown. */ }
diff --git a/src/verdict-withdrawal.js b/src/verdict-withdrawal.js
index a9002085..03af4183 100644
--- a/src/verdict-withdrawal.js
+++ b/src/verdict-withdrawal.js
@@ -9,9 +9,9 @@ function verdictPairs(board, id) {
return verdicts.map((verdict, index) => ({ verdict, event: events[index] }));
}
-/** Only a later reopen naming both exact immutable identities marks an acceptance withdrawn. */
-export function verdictWithdrawals(board, id) {
- const pairs = verdictPairs(board, id), result = new Map();
+/** Reuse an existing ordered read when supplied; standalone callers still load their own immutable pairs. */
+export function verdictWithdrawals(board, id, pairs = verdictPairs(board, id)) {
+ const result = new Map();
for (const row of board.db.prepare("SELECT * FROM event WHERE item_id = ? AND event_kind = 'reopen' ORDER BY event_id").all(id)) {
const detail = JSON.parse(row.event_detail), binding = detail.withdrawnVerdict;
if (!binding) continue;