Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.
JavaScript agentic-codingai-agentsai-governanceautonomous-agentsclaude-codeclicode-reviewcodexcoding-agentsdeveloper-toolsgit-hooksllmlocal-firstmulti-agentsoftware-factoryspec-driven-developmentverificationvibe-coding
test(core): reproduce membership revocation during handover [H15,E17]
Corey Olson99ad34470bf7
diff --git a/src/board-members.js b/src/board-members.jsindex d63a4e69..acb7e4d4 100644--- a/src/board-members.js+++ b/src/board-members.js@@ -1,7 +1,10 @@/** Signed membership travels inside the native sealed board state [E17,H16]. */import { Refused } from './refused.js';import { COORDINATOR } from './config.js';-import { atomic, logEvent } from './board-event-log.js';+import {+ atomic,+ logEvent,+} from './board-event-log.js';import { ENGINE_VERSION } from './machine.js';import { BOARD_MEMBERS_ENGINE } from './board-members-engine.js';diff --git a/src/relay-handover.js b/src/relay-handover.jsindex 69bba283..c4ea008c 100644--- a/src/relay-handover.js+++ b/src/relay-handover.js@@ -6,7 +6,10 @@ import {} from './relay-device-keys.js';import { ENGINE_VERSION } from './machine.js';import { Refused } from './refused.js';-import { signSshVouch, verifySshVouch } from './relay-ssh-proof.js';+import {+ signSshVouch,+ verifySshVouch,+} from './relay-ssh-proof.js';import { authorizeMember } from './relay-membership.js';import { readBoardMembers } from './board-members.js';import { localRecords } from './relay.js';diff --git a/src/relay-membership.js b/src/relay-membership.jsindex 27455121..be728e6f 100644--- a/src/relay-membership.js+++ b/src/relay-membership.js@@ -1,8 +1,14 @@/** Membership authority comes from committed policy or exact local SSH proofs, never a relay assertion [E17]. */import { mainPolicy } from './trusted-policy.js';import { Refused } from './refused.js';-import { boardMembersBytes, boardMembersDocument } from './board-members.js';-import { signSshVouch, verifySshVouch } from './relay-ssh-proof.js';+import {+ boardMembersBytes,+ boardMembersDocument,+} from './board-members.js';+import {+ signSshVouch,+ verifySshVouch,+} from './relay-ssh-proof.js';const NAMESPACE = 'pullboard-board-members';const sameLogin = (a, b) => typeof a === 'string' && typeof b === 'string' && a.toLowerCase() === b.toLowerCase();diff --git a/test/relay-membership.test.js b/test/relay-membership.test.jsindex ff85b4f8..a4471d7c 100644--- a/test/relay-membership.test.js+++ b/test/relay-membership.test.js@@ -9,6 +9,10 @@ import { exportBoard, importBoard } from '../src/exchange.js';import { applyEngineMove, prepareEngineMove } from '../src/engine.js';import { seal, unseal } from '../src/seal.js';import { prepareBoardMembers, authorizeMember } from '../src/relay-membership.js';+import { createDeviceKeys, unwrapDeviceBoardKey } from '../src/relay-device-keys.js';+import { handOverBoardKeys, statementBytes } from '../src/relay-handover.js';+import { signSshVouch } from '../src/relay-ssh-proof.js';+import { ENGINE_VERSION } from '../src/machine.js';import { runFixtureChild } from './fixture-child.js';import { createE2eHelpers } from './e2e-helpers.js';@@ -52,6 +56,42 @@ test('an approver signed member list survives sealed native replay and revokes bawait assert.rejects(authorizeMember(box.repo, { ...state, board: 'f'.repeat(32) }, document, 'bob', { githubKeys }),error => error.code === 'RELAY_NOT_MEMBER', 'the same signature authorizes no other board');const revoked = await prepareBoardMembers(box.repo, state, [], { githubKeys, revision: 2, signingKey });+ await t.test('a local revocation during GitHub proof lookup prevents key publication [H15,E17]', async () => {+ const bobKey = join(box.dir, 'bob');+ assert.equal(runFixtureChild('ssh-keygen', ['-q', '-t', 'ed25519', '-N', '', '-f', bobKey], { encoding: 'utf8' }).status, 0);+ const bobPublic = readFileSync(bobKey + '.pub', 'utf8').trim().split(' ').slice(0, 2).join(' ');+ const device = await createDeviceKeys();+ const statement = { v: 1, board: state.board, repository: state.repository, device: device.deviceId,+ publicKey: device.publicKey, login: 'bob', engine: ENGINE_VERSION, expires: Date.now() + 60_000 };+ const signature = signSshVouch(statementBytes(statement), 'pullboard-device-key', bobKey);+ const deliveries = [];+ let cleared = false;+ await handOverBoardKeys(state, key, { root: box.repo, document,+ currentDocument: () => store.readBoardMembers(board),+ async githubKeys(login) {+ if (login === 'bob') return [bobPublic];+ if (login === 'alice') {+ store.setBoardMembers(board, { agentId: 'coordinator', document: revoked });+ cleared = true;+ return [publicKey];+ }+ return [];+ },+ async send(_state, _path, options) {+ if (options.method === 'PUT') { deliveries.push(options.body); return {}; }+ return { requests: [{ id: 'race-bob', login: 'bob', statement, signature }] };+ },+ }, { err() {} });+ assert.equal(cleared, true, 'a real native clear commits while this handover awaits its proof');+ assert.equal(deliveries.length, 1);+ const delivered = deliveries[0];+ const opened = delivered.wrapped ? await unwrapDeviceBoardKey(device.privateKey,+ JSON.parse(Buffer.from(delivered.wrapped, 'base64url').toString('utf8')),+ { board: state.board, device: device.deviceId, engine: ENGINE_VERSION }) : null;+ assert.equal(opened !== null && Buffer.from(opened).equals(key), false, 'the revoked member cannot decrypt the actual board key');+ assert.equal(delivered.refused?.code, 'RELAY_NOT_MEMBER');+ });+assert.equal(applyEngineMove(board, prepareEngineMove(board, 'setBoardMembers', [{ agentId: 'coordinator', document: revoked }]), { sequence: 2, at: new Date().toISOString() }).error, undefined);await assert.rejects(authorizeMember(box.repo, state, store.readBoardMembers(board), 'bob', { githubKeys }),error => error.code === 'RELAY_NOT_MEMBER', 'the current empty revision revokes an additional member');