Skip to content

Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.

Merge branch 'main' into core/luna1163-bar-check

Corey Olsonaa290077ea94
diff --cc src/board.js
index dabcc1e4,d1d63bf1..9aaad78e
--- a/src/board.js
+++ b/src/board.js
@@@ -1871,7 -1887,8 +1888,8 @@@ export { itemThread } from './board-que
/** Append a typed fact atomically; a correction never edits the original event [B29,B30,B31,B32].
* The internal factId is set from a sealed move's identity during replay, rather than replica-local sequence ids; a never-again with its cause is the person's alone, and rigor lists it at once (#713) [D1].
*/
-export function appendFact(board, id, { agentId, kind, text, ref = null, supersedes = null, factId = randomUUID(), implies, cause = null, neverAgain = false, asPerson = false, channel = 'terminal' }) {
+export function appendFact(board, id, { agentId, kind, text, ref = null, supersedes = null, answers = null, factId = randomUUID(), implies, cause = null, neverAgain = false, asPerson = false, channel = 'terminal' }) {
+ if (board.readOnly) requireFactIdentityIndexes(board.db);
return atomic(board, () => {
const item = current(board, itemById(board, id));
if (!board.db.prepare('SELECT 1 FROM agent WHERE agent_id = ?').get(agentId)) throw new Refused('NO_AGENT', `no registered agent ${agentId}; join a worktree before appending a fact`);
diff --cc src/moves/setLineSetting.js
index 72bace03,bd33faa9..e2fec0bf
--- a/src/moves/setLineSetting.js
+++ b/src/moves/setLineSetting.js
@@@ -5,17 -6,20 +6,25 @@@ import { LANDING_LEASE_ENGINE } from '.
import { LINE_ORDER_ENGINE } from '../line-order-engine.js';
import { LINE_SETTINGS_ENGINE } from '../line-settings-engine.js';
import { BOARD_SENTINEL_ENGINE } from '../sentinel-engine.js';
+import { BAR_CHECK_ENGINE } from '../bar-check-engine.js';
/** Preserve this operation's historical first-matching engine conditions [H16]. */
+ function historicalMinimumEngine(args, board, at) {
+ if (typeof args[1]?.cause === 'string' && args[1].cause.startsWith('conflict:')) return RIGOR_AUTO_ENGINE;
+ if (args[0]?.key === 'collisionFreeBatch') return LAND_COLLISION_ENGINE;
+ if (args[0]?.key === 'order') return LINE_ORDER_ENGINE;
+ if (args[0]?.landingFence !== undefined) return LANDING_LEASE_ENGINE;
+ if (typeof args[1]?.cause === 'string' && args[1].cause.startsWith('sentinel:')) return BOARD_SENTINEL_ENGINE;
+ return LINE_SETTINGS_ENGINE;
+ }
+
+ /** The focus feature composes with every existing conditional floor rather than short-circuiting it. */
function minimumEngine(args, board, at) {
- const barCheck = args[0]?.key === 'bar.check' ? BAR_CHECK_ENGINE : 1;
- if (typeof args[1]?.cause === 'string' && args[1].cause.startsWith('conflict:')) return Math.max(barCheck, RIGOR_AUTO_ENGINE);
- if (args[0]?.key === 'collisionFreeBatch') return Math.max(barCheck, LAND_COLLISION_ENGINE);
- if (args[0]?.key === 'order') return Math.max(barCheck, LINE_ORDER_ENGINE);
- if (args[0]?.landingFence !== undefined) return Math.max(barCheck, LANDING_LEASE_ENGINE);
- if (typeof args[1]?.cause === 'string' && args[1].cause.startsWith('sentinel:')) return Math.max(barCheck, BOARD_SENTINEL_ENGINE);
- return Math.max(barCheck, LINE_SETTINGS_ENGINE);
- return Math.max(historicalMinimumEngine(args, board, at), args[0]?.key === 'focusMilestone' ? FOCUS_MILESTONE_ENGINE : 1);
++ return Math.max(
++ historicalMinimumEngine(args, board, at),
++ args[0]?.key === 'focusMilestone' ? FOCUS_MILESTONE_ENGINE : 1,
++ args[0]?.key === 'bar.check' ? BAR_CHECK_ENGINE : 1,
++ );
}
/** Read precisely the actor argument used by this operation [H2,H16]. */
diff --cc test/line-settings.test.js
index 769eefe4,efe539f8..debcfbbf
--- a/test/line-settings.test.js
+++ b/test/line-settings.test.js
@@@ -72,8 -71,8 +72,9 @@@ test('the settings inventory exposes bo
assert.deepEqual(rows.find(row => row.key === 'line.wipPerReviewer'), { key: 'line.wipPerReviewer', scope: 'board',
board: store.boardId(board), root: box.repo, value: 2, default: false,
source: join(box.repo, '.git', 'pullboard', 'board.sqlite'), origin: 'configured' });
+ assert.equal(rows.find(row => row.key === 'line.focusMilestone').value, false);
assert.equal(rows.find(row => row.key === 'line.reviewsFirst').value, false);
+ assert.equal(rows.find(row => row.key === 'line.bar.check').value, false);
assert.equal(rows.find(row => row.key === 'line.reviewsFirst').origin, 'default');
assert.doesNotMatch(JSON.stringify(rows), /PRIVATE_REASON_CANARY|activeReviewers|reviewMedianMinutes/u);
assert.equal(store.events(board).length, before, 'inventory is a read, not a line-setting change');
diff --cc test/settings.test.js
index 31e3472d,76c3cb6e..de1811bb
--- a/test/settings.test.js
+++ b/test/settings.test.js
@@@ -85,7 -85,7 +85,8 @@@ test('a line setting change is a record
'--window', JSON.stringify(numbers), '--json');
assert.equal(changed.code, 0, `a board setting change succeeds: ${changed.err}${changed.out}`);
assert.equal(initial.code, 0, initial.err);
- const defaults = { order: false, reviewsFirst: false, wipPerReviewer: false, barReady: false, 'bar.check': false, takeoverMinutes: false, collisionFreeBatch: false,
- const defaults = { order: false, focusMilestone: false, collisionFreeBatch: false, reviewsFirst: false, wipPerReviewer: false, barReady: false, takeoverMinutes: false,
++ const defaults = { order: false, focusMilestone: false, collisionFreeBatch: false, reviewsFirst: false, wipPerReviewer: false, barReady: false,
++ 'bar.check': false, takeoverMinutes: false,
landingBatchSize: false, landingCadenceMinutes: false };
assert.deepEqual(JSON.parse(initial.out).lineSettings, defaults, 'all line controls start off, not silently enabled by a machine file');
assert.equal(JSON.parse(changed.out).lineSettings.reviewsFirst, true);
@@@ -97,7 -97,7 +98,8 @@@
assert.deepEqual(JSON.parse(first.event_detail), { key: 'reviewsFirst', value: true,
reason: 'Review waiting exceeds the target', window: numbers, model: 'unknown' });
assert.equal(first.event_by, 'coordinator');
- const values = [['order', true], ['order', false], ['reviewsFirst', false], ['wipPerReviewer', 1.5], ['wipPerReviewer', 3], ['barReady', true], ['bar.check', true], ['collisionFreeBatch', true], ['collisionFreeBatch', false],
- const values = [['focusMilestone', '0.9.3'], ['focusMilestone', false], ['order', true], ['order', false], ['reviewsFirst', false], ['wipPerReviewer', 1.5], ['wipPerReviewer', 3], ['barReady', true],
++ const values = [['focusMilestone', '0.9.3'], ['focusMilestone', false], ['order', true], ['order', false], ['reviewsFirst', false], ['wipPerReviewer', 1.5], ['wipPerReviewer', 3],
++ ['barReady', true], ['bar.check', true], ['collisionFreeBatch', true], ['collisionFreeBatch', false],
['takeoverMinutes', 15], ['takeoverMinutes', 60], ['landingBatchSize', 1], ['landingBatchSize', 8],
['landingCadenceMinutes', 5], ['landingCadenceMinutes', 30]];
let sequence = appliedSequence(board);