Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.
JavaScript agentic-codingai-agentsai-governanceautonomous-agentsclaude-codeclicode-reviewcodexcoding-agentsdeveloper-toolsgit-hooksllmlocal-firstmulti-agentsoftware-factoryspec-driven-developmentverificationvibe-coding
fix(core): check every landed reference exactly [C7,N26]
Corey Olsonb543e8535012
diff --git a/src/reference-lines.js b/src/reference-lines.jsindex f5b52fa1..d5dc17b1 100644--- a/src/reference-lines.js+++ b/src/reference-lines.js@@ -11,7 +11,7 @@ export function handledReferences(brief) {/** Match the target and exact handle on one changelog line, allowing ordinary Markdown links. */export function referenceAcknowledged(reference, lines) {- return lines.some(line => line.includes(reference.target)+ return lines.some(line => line.split(reference.target).slice(1).some(tail => !tail || /^[\s)\]>.,;:!?]/u.test(tail))&& [...line.matchAll(/@([A-Za-z0-9][A-Za-z0-9-]{0,38})/gu)].some(match => match[1].toLowerCase() === reference.handle.toLowerCase()));}diff --git a/src/reference-release.js b/src/reference-release.jsindex 7ce37aa5..82242fe9 100644--- a/src/reference-release.js+++ b/src/reference-release.js@@ -27,7 +27,7 @@ export function checkReleaseReferences(root, board, name, commit) {if (typeof id !== 'number') continue;const item = store.getItem(board, id);if (item.item_status !== 'verified' || !item.item_merged_commit || !commit- || !contains(root, commit, item.item_merged_commit)) continue;+ || !contains(root, item.item_merged_commit, commit)) continue;for (const reference of handledReferences(item.item_brief)) {references.set(JSON.stringify([reference.target, reference.handle.toLowerCase()]), reference);}diff --git a/test/references.test.js b/test/references.test.jsindex 58a7372c..dff53bf2 100644--- a/test/references.test.js+++ b/test/references.test.js@@ -9,9 +9,17 @@ import * as store from '../src/board.js';import { minimumMoveEngine } from '../src/move-registry.js';import { REFERENCE_ENGINE } from '../src/reference-engine.js';import { createE2eHelpers } from './e2e-helpers.js';-import { referenceLines } from '../src/reference-lines.js';+import { referenceLines, referenceAcknowledged } from '../src/reference-lines.js';import { bridgeProject, bridgeProvider, landBridgeItems, runBridgeCLI } from './pr-bridge-fixture.js';+test('changelog matching distinguishes issue numbers and accepts Markdown acknowledgement links [C7]', () => {+ const reference = { target: 'https://github.com/example/project/issues/1', handle: 'Reporter' };+ assert.equal(referenceAcknowledged(reference, ['https://github.com/example/project/issues/10 @Reporter']), false);+ assert.equal(referenceAcknowledged(reference, ['https://github.com/example/project/issues/1/other @Reporter']), false);+ assert.equal(referenceAcknowledged(reference, ['[issue](https://github.com/example/project/issues/1), thanks @reporter.']), true);+ assert.equal(referenceAcknowledged(reference, ['https://github.com/example/project/issues/1 @ReporterOther']), false);+});+test('reference points 19 and 23: only explicitly labelled lines can acknowledge someone [C7]', () => {const brief = 'Reference: https://example.com/public @Reporter\nprivate unlabelled continuation @PrivatePerson\nReference: https://example.com/private';assert.deepEqual(referenceLines(brief), [