Skip to content

Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.

fix(ci): include sign-offs in required matrix gate [C7]

Corey Olsonb8888cf3df50
diff --git a/.github/workflows/gate.yml b/.github/workflows/gate.yml
index 49e24447..4f77684e 100644
--- a/.github/workflows/gate.yml
+++ b/.github/workflows/gate.yml
@@ -20,19 +20,6 @@ permissions:
contents: read
jobs:
- signoffs:
- name: contributor sign-offs
- if: github.event_name == 'push' || github.event_name == 'pull_request'
- runs-on: ubuntu-latest
- steps:
- - uses: actions/checkout@v4
- with:
- fetch-depth: 0
- - uses: actions/setup-node@v4
- with:
- node-version: '22.13'
- - run: node bin/check-signoffs.js
-
linux:
name: linux (${{ matrix.node }}) ${{ matrix.shard }}/${{ matrix.shards }}
runs-on: ubuntu-latest
@@ -49,6 +36,8 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
+ - if: github.event_name == 'push' || github.event_name == 'pull_request'
+ run: node bin/check-signoffs.js
- run: node bin/pullboard.js spec check
- run: npm test -- --shard=${{ matrix.shard }}/${{ matrix.shards }}
@@ -69,6 +58,8 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
+ - if: github.event_name == 'push' || github.event_name == 'pull_request'
+ run: node bin/check-signoffs.js
- run: node bin/pullboard.js spec check
- run: npm test -- --shard=${{ matrix.shard }}/${{ matrix.shards }}
diff --git a/test/ci.test.js b/test/ci.test.js
index 06e1b5f6..e41f6f54 100644
--- a/test/ci.test.js
+++ b/test/ci.test.js
@@ -91,15 +91,14 @@ function job(name) {
test('CI runs the gate on every push and pull request, Node 22.13 and 24, on Linux and, once public, macOS [C7]', () => {
assert.match(WORKFLOW, /\non:\n {2}push:\n {4}branches: \[main\]\n {2}pull_request:\n/, 'pushes to main and pull requests');
- assert.match(job('signoffs'), /if: github\.event_name == 'push' \|\| github\.event_name == 'pull_request'/u);
- assert.match(job('signoffs'), /fetch-depth: 0/u, 'the sign-off job can read every incoming commit');
- assert.match(job('signoffs'), /run: node bin\/check-signoffs\.js/u, 'CI runs the range checker against its structured event');
for (const [name, system] of [['linux', 'ubuntu-latest'], ['macos', 'macos-latest']]) {
const text = job(name);
assert.ok(text.includes(`\n runs-on: ${system}\n`), `${name} runs on ${system}`);
assert.match(text, /\n {8}node: \['22\.13', '24'\]\n/, `${name} runs Node 22.13 and 24`);
assert.match(text, /\n {10}node-version: \$\{\{ matrix\.node \}\}\n/, `${name} sets up the matrix's Node`);
assert.match(text, /\n {10}fetch-depth: 0\n/, `${name} checks out full history, which spec check reads`);
+ assert.match(text, /if: github\.event_name == 'push' \|\| github\.event_name == 'pull_request'\n\s+run: node bin\/check-signoffs\.js/u,
+ `${name} includes sign-offs in the matrix gate that publication requires`);
assert.equal([...text.matchAll(/\n {6}- run: node bin\/pullboard\.js spec check(?=\n)/gu)].length, 1,
`${name} checks the spec exactly once in every matrix job`);
assert.ok(text.includes('npm test -- --shard=${{ matrix.shard }}/${{ matrix.shards }}'),