Skip to content

Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.

refactor(next): skipIds needs no second engine gate in board.js [N2]

Corey Olsonde4abc4c3bf3
diff --git a/src/board.js b/src/board.js
index 1dbc3ea3..bec4fc89 100644
--- a/src/board.js
+++ b/src/board.js
@@ -54,7 +54,6 @@ import {
} from './machine.js';
import { LOCAL_LANDING_ENGINE } from './land-engine.js';
import { SPEC_APPROVAL_ENGINE } from './spec-approval-engine.js';
-import { REVIEW_SKIP_ENGINE } from './review-skip-engine.js';
import { Refused } from './refused.js';
import { refuseMaskedExit } from './check-mask.js';
import {
@@ -2300,8 +2299,7 @@ export function buildOrder(board, { warm = [] } = {}) {
* With `runnable`, only items that carry a check command, which an unattended runner needs; with
* `routes`, only items on those routes, the ones a runner has an agent command for. With `warm`, the
* files the agent worked in lately, an item that shares more of them comes first within its tier,
- * and `shared` names them (N20). A held lane offers nothing new (N22). With `skipIds`, a verifier is
- * never offered those items: the ones its own agent session built, which verify refuses anyway.
+ * and `shared` names them (N20). A held lane offers nothing new (N22). A verifier is never offered `skipIds` (#973; engine 69, so older replays carry none).
*
* @param {any} board
* @param {{ agentId: string, lane: string, verify?: boolean, policy?: string, familyPolicy?: string, runnable?: boolean, routes?: string[], warm?: string[], priority?: number[], lanes?: string[], skipIds?: number[] }} who
@@ -2319,9 +2317,7 @@ export function nextFor(board, { agentId, lane, verify = false, policy = 'any',
if (verify) {
const family = board.db.prepare('SELECT agent_family FROM agent WHERE agent_id = ?').get(agentId)?.agent_family ?? null;
const hasDifferentFamily = (entry) => Boolean(family && entry.item_builder_family && family !== entry.item_builder_family);
- // An older engine ignores skipIds, so a recorded move replays as it was first applied (#973).
- const skipped = (board.executionEngineVersion ?? ENGINE_VERSION) >= REVIEW_SKIP_ENGINE ? skipIds : [];
- const unrelated = items.filter((entry) => entry.item_status === 'submitted' && entry.item_built_by !== agentId && !skipped.includes(entry.item_id));
+ const unrelated = items.filter((entry) => entry.item_status === 'submitted' && entry.item_built_by !== agentId && !skipIds.includes(entry.item_id));
const standingRefusal = unrelated.map((entry) => standingProblem(board, agentId, entry.item_built_by, entry.item_id)).find(Boolean);
let reviewable = unrelated.filter((entry) => !standingProblem(board, agentId, entry.item_built_by, entry.item_id));
if (policy === COORDINATOR && agentId !== COORDINATOR) reviewable = reviewable.filter((entry) => entry.item_lane === COORDINATOR);