Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.
JavaScript agentic-codingai-agentsai-governanceautonomous-agentsclaude-codeclicode-reviewcodexcoding-agentsdeveloper-toolsgit-hooksllmlocal-firstmulti-agentsoftware-factoryspec-driven-developmentverificationvibe-coding
fix(grants): bind admitted submit completion [V4,H16]
Corey Olsone4b63c7987dd
diff --git a/src/agent-grant.js b/src/agent-grant.jsindex 17e7cfeb..e18f3626 100644--- a/src/agent-grant.js+++ b/src/agent-grant.js@@ -5,6 +5,7 @@ import { BAR_SIGN_GRANT_ENGINE } from './bar-sign-grant-engine.js';import { MOVE_REGISTRY } from './move-registry.js';import { Refused } from './refused.js';import { recordedGrantActivation } from './relay-activation.js';+import { completesAdmittedSubmit } from './submit-admission.js';// Attributed append-only findings never confer authority over item state.const ADMINISTRATIVE = new Set(['shout', 'claim', 'release', 'reserveReview', 'appendFact', 'recordAttempt']);@@ -67,7 +68,8 @@ export function requireAgentGrant(board, move, at = board.clock.now()) {const own = claims.find(claim => claim.item_id === item?.item_id);const live = claims.filter(claim => claim.item_lease_until > now);const previous = board.db.prepare("SELECT event_id FROM event WHERE event_by=? AND event_kind IN ('claim','renew') ORDER BY event_id DESC LIMIT 1").get(actor);- if ((own && !(own.item_lease_until > now)) || (previous && !live.length)) {+ if (((own && !(own.item_lease_until > now)) || (previous && !live.length))+ && !completesAdmittedSubmit(board, move, item, actor)) {throw new Refused('AGENT_GRANT_EXPIRED', `${actor} has no live item claim; claim work before changing an item`,'claim the intended item, or shout the coordinator if its claim is unavailable');}diff --git a/src/board.js b/src/board.jsindex 5369edfe..8e9aecf3 100644--- a/src/board.js+++ b/src/board.js@@ -7,6 +7,7 @@ import {import { foreignBlockers } from './cross-repo-dependencies.js';import * as itemDependencies from './item-dependencies.js';import { AGENT_GRANT_ENGINE } from './agent-grant-engine.js';+import { submitAdmission as checkedSubmitAdmission } from './submit-admission.js';import * as computedConflictEvidence from './computed-conflict-receipt.js';import { reopenAuthority } from './reopen-authority.js';import { applyLaneLead } from './lane-lead-policy.js';@@ -979,8 +980,9 @@ export function recordAttempt(board, id, { agentId, n, seconds, result }) {* @param {{ agentId: string, lane: string, leaseMs: number, freeze: (item: any) => { text: string, digest: string }, head?: string | null, reviewSkipped?: object | null }} who* @returns {{ leaseUntil: string, digest: string, renewed: boolean }}*/-export function claim(board, id, { agentId, lane, leaseMs, freeze, head = null, reviewSkipped = null, reviewPolicy = 'any', familyPolicy = 'off' }) {+export function claim(board, id, { agentId, lane, leaseMs, freeze, head = null, reviewSkipped = null, reviewPolicy = 'any', familyPolicy = 'off', submitAdmission = null }) {return atomic(board, () => {+ const admission = checkedSubmitAdmission(board, id, agentId, submitAdmission);const leaseUntil = new Date(board.clock.now().getTime() + leaseMs).toISOString();const isRenewal = (item) => item.item_owner === agentId && isHeld(board, item);// Reworking your own rejected item is a claim of its own, beside the one live claim (B5): the@@ -1076,6 +1078,7 @@ export function claim(board, id, { agentId, lane, leaseMs, freeze, head = null,if (board.verifierStanding.lineage) board.db.prepare('INSERT INTO board_meta (meta_key, meta_value) VALUES (?, ?)').run(`item_lineage:${id}`, board.verifierStanding.lineage);}logEvent(board, agentId, renewed ? 'renew' : 'claim', id, { leaseUntil, digest, ...(!renewed && reviewSkipped ? { reviewSkipped } : {}),+ ...(admission ? { submitAdmission: admission } : {}),...((board.executionEngineVersion ?? ENGINE_VERSION) >= AGENT_GRANT_ENGINE ? { grantEngine: AGENT_GRANT_ENGINE } : {}) });return { leaseUntil, digest, renewed };});diff --git a/src/cli.js b/src/cli.jsindex 4bd31361..d4d05a51 100644--- a/src/cli.js+++ b/src/cli.js@@ -1676,7 +1676,7 @@ export function resourceAgent(ctx) {}/** Keep only this queued command's live item lease, using ordinary ordered board moves. */-export function queuedItemLease(ctx, initial, agentId, kind) {+export function queuedItemLease(ctx, initial, agentId, kind, admission = null) {const report = gateWaitReporter(ctx.io);// Naming somebody else's check remains read-only; it never extends their build claim.if (kind === 'build' && (initial.item_status !== 'claimed' || initial.item_owner !== agentId)) return report;@@ -1704,12 +1704,15 @@ export function queuedItemLease(ctx, initial, agentId, kind) {throw new Refused('ITEM_LEASE_LOST', `the queued ${review ? 'review' : 'build'} lease for #${initial.item_id} changed or expired; claim or reserve the item again before retrying`);}if (state.admitted || expires - now <= leaseMs / 2) {+ const witness = state.admitted && admission ? { id: randomUUID(), commit: admission.commit, tree: admission.tree } : null;const result = await ordered(ctx, board, review ? 'reserveReview' : 'claim', [initial.item_id, {agentId, leaseMs,+ ...(witness ? { submitAdmission: witness } : {}),...(review ? { policy: ctx.config.verify.policy, familyPolicy: ctx.config.verify.family }: { lane: current.item_lane, freeze: claimFreezer(ctx), head: headCommit(ctx.info.root) }),}]);confirmedLeaseUntil = review ? result.item_review_until : result.leaseUntil;+ if (witness) admission.id = witness.id;return { leaseUntil: confirmedLeaseUntil };}confirmedLeaseUntil = current[field];diff --git a/src/commands/submit.js b/src/commands/submit.jsindex 4ea3d0e1..c30afc5c 100644--- a/src/commands/submit.js+++ b/src/commands/submit.js@@ -201,8 +201,9 @@ export async function submitHere(ctx, id, infra) {registryGuards: acceptedMain.config.registryGuards,// The accepted project runner interprets its current invariant files; candidate config cannot replace it....(acceptedMain.config.submitInvariants.length || acceptedMain.config.registryGuards.length ? { affectedTests: acceptedMain.config.affectedTests } : {}) };- const gate = await runSubmitGate(root, submitConfig, { base: claimHead, trunk: acceptedMain.commit, check: frozenCheck(held), agent: me.id, item: String(id), onWait: queuedItemLease(ctx, held, me.id, 'build'), onBrowserFallback: browserAdmissionReporter(ctx.io, ctx.io.relayJson),- proofContext: { item: id, frozenDigest: held.item_frozen_digest ?? null, seat: me.id },+ const admission = { commit, tree: headTree(root) };+ const gate = await runSubmitGate(root, submitConfig, { base: claimHead, trunk: acceptedMain.commit, check: frozenCheck(held), agent: me.id, item: String(id), onWait: queuedItemLease(ctx, held, me.id, 'build', admission), onBrowserFallback: browserAdmissionReporter(ctx.io, ctx.io.relayJson),+ proofContext: { item: id, frozenDigest: held.item_frozen_digest ?? null, seat: me.id, admission },onFailure: nativeFlakes.observer(ctx, { kind: 'submit', main: acceptedMain.commit, config: submitConfig }, { ordered, withBoard, resourceAgent }) });for (const proofReceiptId of gate.proofReceiptIds ?? []) {await recordNativeProof(ctx, held, { proofReceiptId }, { ordered, withBoard, resourceAgent });diff --git a/src/gate.js b/src/gate.jsindex ae469a34..57408a05 100644--- a/src/gate.js+++ b/src/gate.js@@ -308,7 +308,8 @@ function leaveProofReceipt(root, command, run, before, context, lease) {environment, testRuntimes, runner: remote ?? (lease?.runner ? null: run.profile?.receipt?.runner?.id ?? lease?.receipt?.runner?.id ?? lease?.localDescriptor?.id ?? null), exitCode: run.exitCode,counts: run.proofCounts ?? proofCounts(run.outputPath ? logLines(run.outputPath) : run.output ?? ''),- durationMs: Math.max(0, Math.round(run.remoteWallMs ?? run.profile?.wallMs ?? run.seconds * 1000)), sourceClean } });+ durationMs: Math.max(0, Math.round(run.remoteWallMs ?? run.profile?.wallMs ?? run.seconds * 1000)), sourceClean,+ ...(context.submitAdmission ? { submitAdmission: context.submitAdmission } : {}) } });if (!receipt) return null;mkdirSync(store, { recursive: true, mode: 0o700 });writeFileSync(join(store, `${receipt.id}.json`), receiptBody(receipt), { flag: 'wx', mode: 0o600 });@@ -725,7 +726,9 @@ export async function runSubmitGate(root, config, { base, trunk, changed, check,const gui = (check ? await checkNeedsGui(root, check) : false)|| ((selection.full && !deferFullFallback && !deferSelection) && projectNeedsGui(root)) || testsNeedGui(root, proofFiles);return await withGateSlot(root, async (lease) => {- if (proofContext) lease.proof = { ...proofContext, kind: 'submit' };+ const hasFinalProof = !deferFullFallback && !deferSelection && selection.full || proofFiles.length > 0;+ if (proofContext) lease.proof = { ...proofContext, kind: 'submit',+ ...(!hasFinalProof && proofContext.admission?.id ? { submitAdmission: proofContext.admission.id } : {}) };pinRunMain(lease, onFailure);const startedAt = Date.now();const log = gitPath(root, 'pullboard-submit.log');@@ -763,6 +766,7 @@ export async function runSubmitGate(root, config, { base, trunk, changed, check,return finish({ isGreen: false, sandboxBlocked: criterion.sandboxBlocked, isCached: false, output: criterion.output, seconds: 0, log: '' });}// The proof already owns this lease: its phase profile has no additional queue wait.+ if (hasFinalProof && proofContext?.admission?.id) lease.proof.submitAdmission = proofContext.admission.id;const proofWait = check ? 0 : lease.waitMs;let proof;// The proof keeps each stage's status, so a person's waiver can only ever explain named test failures.diff --git a/src/moves/claim.js b/src/moves/claim.jsindex fd7d5957..bb23160a 100644--- a/src/moves/claim.js+++ b/src/moves/claim.js@@ -1,4 +1,5 @@import { CROSS_REPO_DEPENDENCY_ENGINE } from '../cross-repo-dependency-engine.js';+import { SUBMIT_ADMISSION_ENGINE } from '../submit-admission-engine.js';import { hasForeignDependencies } from '../item-dependencies.js';import { LINE_CAPACITY_ENGINE } from '../line-capacity-engine.js';import { RIGOR_AUTO_ENGINE } from '../rigor-auto-engine.js';@@ -29,7 +30,8 @@ function minimumEngine(args, board, at) {const validId = ['number', 'string'].includes(typeof id) && Number.isSafeInteger(Number(id)) && Number(id) > 0;const item = board && validId ? board.db.prepare('SELECT item_after FROM item WHERE item_id=?').get(id) : null;const foreign = item && hasForeignDependencies(item);- return Math.max(foreign ? CROSS_REPO_DEPENDENCY_ENGINE : 1, outside ? OUTSIDE_INTAKE_ENGINE : 1, capacity ? LINE_CAPACITY_ENGINE : 1, existingEngine(args, board, at));+ return Math.max(args[1]?.submitAdmission != null ? SUBMIT_ADMISSION_ENGINE : 1,+ foreign ? CROSS_REPO_DEPENDENCY_ENGINE : 1, outside ? OUTSIDE_INTAKE_ENGINE : 1, capacity ? LINE_CAPACITY_ENGINE : 1, existingEngine(args, board, at));}/** Read precisely the actor argument used by this operation [H2,H16]. */diff --git a/src/moves/recordProofRun.js b/src/moves/recordProofRun.jsindex caa90433..f0def994 100644--- a/src/moves/recordProofRun.js+++ b/src/moves/recordProofRun.js@@ -1,8 +1,9 @@/** Native proof receipt routing is pure; origin binding belongs to the engine adapter [C7,H16]. */import { PROOF_RUN_ENGINE } from '../proof-run-engine.js';+import { SUBMIT_ADMISSION_ENGINE } from '../submit-admission-engine.js';/** Proof provenance always requires its own replay floor, regardless of optional metadata. */-function minimumEngine() { return PROOF_RUN_ENGINE; }+function minimumEngine(args) { return args[0]?.receipt?.proof?.submitAdmission ? SUBMIT_ADMISSION_ENGINE : PROOF_RUN_ENGINE; }/** Attribute a recorded proof to its declared native seat. */function actor(move) { return move.args[0]?.agentId ?? null; }diff --git a/src/proof-provenance.js b/src/proof-provenance.jsindex 672e60fe..54105fbd 100644--- a/src/proof-provenance.js+++ b/src/proof-provenance.js@@ -11,6 +11,8 @@ function identity(value, limit = 512) {/** Validate the native facts attached to a version-two gate receipt. */export function proofFields(value) {+ const hasAdmission = Object.hasOwn(value ?? {}, 'submitAdmission');+ if (hasAdmission && !/^[a-f0-9-]{36}$/u.test(value.submitAdmission ?? '')) return null;if (!value || !Number.isSafeInteger(value.item) || value.item < 1|| value.frozenDigest !== null && !/^[a-f0-9]{64}$/u.test(value.frozenDigest ?? '')|| !identity(value.seat, 256) || value.runner !== null && !identity(value.runner)@@ -30,7 +32,7 @@ export function proofFields(value) {environment: actualEnvironment === null ? null : { node: actualEnvironment.node, platform: actualEnvironment.platform, arch: actualEnvironment.arch },seat: value.seat, runner: value.runner, exitCode: value.exitCode,counts: Object.fromEntries(names.map(name => [name, value.counts[name]])), durationMs: value.durationMs, sourceClean: value.sourceClean,- ...(hasTestRuntimes ? { testRuntimes } : {}) };+ ...(hasTestRuntimes ? { testRuntimes } : {}), ...(hasAdmission ? { submitAdmission: value.submitAdmission } : {}) };}/** Read explicit TAP or Node reporter totals; absent counters stay unknown rather than becoming zero. */diff --git a/src/proof-receipts.js b/src/proof-receipts.jsindex b2a9b273..d1b58e59 100644--- a/src/proof-receipts.js+++ b/src/proof-receipts.js@@ -44,6 +44,7 @@ export function proofRunReceipt(board, request) {seat: agentId, parentSession: seats.agentParent?.(board, agentId) ?? null, exitCode: run.proof.exitCode,counts: run.proof.counts, durationMs: run.proof.durationMs, sourceClean: run.proof.sourceClean, at: run.at,...(Object.hasOwn(run.proof, 'testRuntimes') ? { testRuntimes: run.proof.testRuntimes } : {}) };+ if (Object.hasOwn(run.proof, 'submitAdmission')) receipt.submitAdmission = run.proof.submitAdmission;const existing = proofReceipts(board, itemId).find(value => value.id === receipt.id);if (existing) {const { eventId, ...fields } = existing;diff --git a/src/submit-admission-engine.js b/src/submit-admission-engine.jsnew file mode 100644index 00000000..af0a7fb2--- /dev/null+++ b/src/submit-admission-engine.js@@ -0,0 +1,3 @@+/** Admitted submit completion retains its bounded grant without extending its build lease [V4,H16]. */+import { unassignedEngine } from './engine-next.js';+export const SUBMIT_ADMISSION_ENGINE = unassignedEngine();diff --git a/src/submit-admission.js b/src/submit-admission.jsnew file mode 100644index 00000000..21c7ff86--- /dev/null+++ b/src/submit-admission.js@@ -0,0 +1,37 @@+/** A native proof can finish its admitted claim; it never grants new work after expiry [V4,H16]. */+import { Refused } from './refused.js';+import { SUBMIT_ADMISSION_ENGINE } from './submit-admission-engine.js';++/** Validate an admission while its ordinary claim is still live, before recording the renewal. */+export function submitAdmission(board, itemId, actor, value) {+ if (value === null || value === undefined) return null;+ if (!/^[a-f0-9-]{36}$/u.test(value?.id ?? '')+ || !/^(?:[a-f0-9]{40}|[a-f0-9]{64})$/u.test(value?.commit ?? '')+ || !/^(?:[a-f0-9]{40}|[a-f0-9]{64})$/u.test(value?.tree ?? '')) {+ throw new Refused('USAGE', 'a submit admission names its native id and exact committed source');+ }+ const item = board.db.prepare('SELECT * FROM item WHERE item_id=?').get(itemId);+ if (item?.item_status !== 'claimed' || item.item_owner !== actor || !(item.item_lease_until > board.clock.now().toISOString())) {+ throw new Refused('ITEM_LEASE_LOST', 'the submit admission needs the same live claim; claim the item before starting a new submit');+ }+ return { id: value.id, commit: value.commit, tree: value.tree };+}++/** Only a matching final native proof recorded after the latest claim can finish expired work. */+export function completesAdmittedSubmit(board, move, item, actor) {+ if (move.engine < SUBMIT_ADMISSION_ENGINE || move.operation !== 'submit'+ || item.item_status !== 'claimed' || item.item_owner !== actor) return false;+ const claim = board.db.prepare("SELECT * FROM event WHERE event_by=? AND event_kind IN ('claim','renew') ORDER BY event_id DESC LIMIT 1").get(actor);+ if (claim?.item_id !== item.item_id) return false;+ const detail = JSON.parse(claim.event_detail);+ const admission = detail.submitAdmission;+ const source = move.args[1];+ if (!admission || admission.commit !== source?.commit || admission.tree !== source?.tree+ || detail.digest !== item.item_frozen_digest) return false;+ const receipts = board.db.prepare("SELECT event_detail FROM event WHERE item_id=? AND event_by=? AND event_kind='proof-run' AND event_id>? ORDER BY event_id")+ .all(item.item_id, actor, claim.event_id).map(row => JSON.parse(row.event_detail).receipt)+ .filter(receipt => receipt?.submitAdmission === admission.id);+ return receipts.length > 0 && receipts.every(receipt => receipt.kind === 'submit' && receipt.item === item.item_id+ && receipt.seat === actor && receipt.commit === admission.commit && receipt.tree === admission.tree+ && receipt.frozenDigest === item.item_frozen_digest && receipt.sourceClean === true && receipt.exitCode === 0);+}diff --git a/test/resources-lease-fixture.js b/test/resources-lease-fixture.jsindex d9e3d98b..0b878f9a 100644--- a/test/resources-lease-fixture.js+++ b/test/resources-lease-fixture.js@@ -6,6 +6,8 @@ import { pathToFileURL } from 'node:url';import { createInterface } from 'node:readline';import { DatabaseSync } from 'node:sqlite';import * as store from '../src/board.js';+import { exportBoard, importBoard } from '../src/exchange.js';+import { appliedSequence, applyEngineMove, prepareEngineMove } from '../src/engine.js';import { registerProject } from '../src/projects.js';import { serveView } from '../src/serve.js';import { runFixtureChild } from './fixture-child.js';@@ -190,6 +192,25 @@ function itemLeaseFixture(t, helpers) {return box;}+/** Neither a fresh CLI submit nor an unwitnessed receiver move inherits a running command's admission. */+function refuseFreshExpiredSubmit(box, id) {+ const late = runFixtureChild(process.execPath, ['--input-type=module', '-e', CLOCKED_CLI, 'submit', String(id), '--json'],+ { cwd: box.web, env: box.env, encoding: 'utf8' });+ assert.equal(late.status, 1, late.stdout);+ assert.equal(JSON.parse(late.stdout).error.code, 'NOT_YOURS', 'a new submit cannot start on an expired claim');+ const replica = store.openBoard(join(box.dir, 'expired-submit-receiver.sqlite'), box.clock);+ try {+ importBoard(replica, exportBoard(box.board));+ const before = store.itemById(replica, id);+ const move = prepareEngineMove(replica, 'submit', [id, { agentId: before.item_owner,+ commit: box.git(box.web, 'rev-parse', 'HEAD'), tree: box.git(box.web, 'rev-parse', 'HEAD^{tree}'),+ submissionProof: { version: 1, files: [], full: false, deferred: true, reason: 'receiver negative control; no completed proof' } }]);+ const result = applyEngineMove(replica, move, { sequence: appliedSequence(replica) + 1, at: box.clock.now().toISOString() });+ assert.equal(result.error?.code, 'AGENT_GRANT_EXPIRED', 'even a real admission nonce grants no receiver completion without its native final proof');+ assert.deepEqual(store.itemById(replica, id), before, 'the refused receiver leaves the claimed item unchanged');+ } finally { store.closeBoard(replica); }+}+/*** Run the queued-lease scenario against the resource suite's private pool helpers.*@@ -278,6 +299,7 @@ export async function queuedLeaseProof(t, deps) {clockedCli(box, box.repo, 'resources', '--json');assert.equal(end(buildId, 'check'), runningBuildEnd, 'admission ends build item renewals');assert.ok(runningBuildEnd < box.clock.now().toISOString(), 'the running build resumes ordinary lease expiry');+ refuseFreshExpiredSubmit(box, buildId);writeFileSync(buildGate.release, 'release');assert.equal((await build.finished).code, 0, `${build.stdoutText}\n${build.stderrText}`);assert.equal(item(buildId).item_status, 'submitted', 'the actual queued submit completes its ordinary board move');