Skip to content

Autonomous development for real products. Governed agents build from specs you approve, follow the rules you set, and nothing merges until another agent proves it. Your decisions, judgement and taste are the bar that work must clear. Declare your vision and let agents build it.

feat(next): prefer the recorded focus milestone [N2,B16,H16]

Corey Olsonf9f33b56c6cc
diff --git a/src/board.js b/src/board.js
index 79f49d64..f6afb9cd 100644
--- a/src/board.js
+++ b/src/board.js
@@ -1,3 +1,7 @@
+import {
+ focusOrder,
+ focusReasons,
+} from './focus-milestone.js';
import { ensureProofCounters } from './proof-counters.js';
import { correctedNoVerdictReopen } from './reopen-history.js';
import {
@@ -1311,7 +1315,7 @@ export function reserveReview(board, id, who) {
export function reserveNextReview(board, { agentId, lane, leaseMs, policy, familyPolicy = 'off', runnable, routes, skipIds = [] }) {
return atomic(board, () => {
const { item, reasons } = nextFor(board, { agentId, lane, verify: true, familyPolicy, runnable, routes, skipIds });
- return item ? { item: reserveWithin(board, item.item_id, { agentId, leaseMs, policy, familyPolicy }), reasons: [] } : { item: null, reasons };
+ return item ? { item: reserveWithin(board, item.item_id, { agentId, leaseMs, policy, familyPolicy }), reasons } : { item: null, reasons };
});
}
@@ -1931,7 +1935,7 @@ export function buildOrder(board, { warm = [], agentId, readiness = barReadyForO
|| rank(first) - rank(second)
|| ROUTES.indexOf(second.item_route) - ROUTES.indexOf(first.item_route)
|| shared(second) - shared(first) || first.item_id - second.item_id;
- return lineOrderEnabled(board) ? lineBuildOrder({ agentId, release: milestonePriority, rank, items: listItems(board, { all: true }), ready: item => readiness(board, item), fallback }) : fallback;
+ return focusOrder(board, lineOrderEnabled(board) ? lineBuildOrder({ agentId, release: milestonePriority, rank, items: listItems(board, { all: true }), ready: item => readiness(board, item), fallback }) : fallback);
}
/**
@@ -1951,6 +1955,7 @@ export function buildOrder(board, { warm = [], agentId, readiness = barReadyForO
* @returns {{ item: any | null, reasons: string[], shared?: string[] }}
*/
export function nextFor(board, { agentId, lane, verify = false, policy = 'any', familyPolicy = 'off', runnable = false, routes = ROUTES, warm = [], priority = [], lanes, skipIds = [] }) {
+ const focusCompare = focusOrder(board, () => 0);
const route = routeOf(board, agentId);
const tier = (entry) => ROUTES.indexOf(entry.item_route);
const allItems = listItems(board).reverse();
@@ -1983,8 +1988,9 @@ export function nextFor(board, { agentId, lane, verify = false, policy = 'any',
candidates.sort((first, second) => (scarcity ? scarcity.get(first.entry.item_id) - scarcity.get(second.entry.item_id)
|| lineCompare(first.entry, second.entry) : milestonePriority(first.entry) - milestonePriority(second.entry)
|| rank(first.entry) - rank(second.entry)));
+ candidates.sort((a, b) => focusCompare(a.entry, b.entry));
const item = candidates.find((candidate) => !candidate.holder && !candidate.cooldown)?.entry;
- if (item) return { item, reasons: [] };
+ if (item) return { item, reasons: focusReasons(board, item) };
const held = candidates.filter((candidate) => candidate.holder && candidate.holder !== agentId)
.map(({ entry, holder: reviewer }) => `${reviewer} holds the review of #${entry.item_id} until ${entry.item_review_until}`);
const cooling = candidates.filter((candidate) => candidate.cooldown)
@@ -2030,6 +2036,7 @@ export function nextFor(board, { agentId, lane, verify = false, policy = 'any',
mine.splice(firstTierItem, 0, rework);
}
}
+ mine.sort((a, b) => focusCompare(a.entry, b.entry));
for (const { entry, shared } of mine) {
const waiting = (entry.item_after ? entry.item_after.split(',').map(Number) : [])
.map((id) => current(board, itemById(board, id)))
@@ -2038,7 +2045,7 @@ export function nextFor(board, { agentId, lane, verify = false, policy = 'any',
if (reserved) { reasons.push(reserved); continue; }
const collisions = itemFileCollisions(entry, inFlight);
if (collisions.length) { reasons.push(...collisions); continue; }
- if (!waiting.length) return { item: entry, reasons, shared };
+ if (!waiting.length) return { item: entry, reasons: focusReasons(board, entry, reasons), shared };
reasons.push(`#${entry.item_id} waits on ${waiting.map(waitingOn).join(', ')}`);
}
if (!mine.length && !reasons.length) reasons.push(idleReason(items, lane, routed));
diff --git a/src/cli.js b/src/cli.js
index 6a572f5a..1abe1ddc 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -1,3 +1,7 @@
+import {
+ focusReviewFirst,
+ focusReasons,
+} from './focus-milestone.js';
import { requireHandoffActive } from './handoff-state.js';
import { requestedCommandMove } from './recorded-move.js';
export { barActorForCommand } from './bar-actor.js';
@@ -1543,7 +1547,7 @@ function nextPick(ctx, board, values) {
const findOffer = () => store.reviewOffer(board, { agentId: me.id, lane: me.lane, policy: ctx.config.verify.policy,
familyPolicy: ctx.config.verify.family, ratio: ctx.config.verify.reviewRatio, runnable: values.runnable, routes: values.routes });
const offer = held ? null : relayLinked(ctx.info.root) ? store.withVerifierStanding(board, { root: true }, findOffer) : findOffer();
- if (offer && !values.build) return { item: offer.item, offer, build: item ?? null };
+ if (offer && !values.build && focusReviewFirst(board, offer.item, item)) return { item: offer.item, offer, build: item ?? null, reasons: focusReasons(board, offer.item) };
if (!item) return { reasons, laneWork: ctx.info.isMain ? mainLaneWork(store.listItems(board)) : null };
const reviewSkipped = values.build && !held
? { offeredItem: offer?.item.item_id ?? null, ratio: offer?.ratio ?? ctx.config.verify.reviewRatio, ...store.reviewQueue(board) } : null;
diff --git a/src/commands/next.js b/src/commands/next.js
index 42891115..a612bc60 100644
--- a/src/commands/next.js
+++ b/src/commands/next.js
@@ -58,7 +58,10 @@ export async function nextHere(io, values) {
continue;
}
if (found.item) {
- if (found.offer) { sayReviewOffer(ctx, found); return 0; }
+ if (found.offer) {
+ for (const reason of found.reasons ?? []) io.say(reason);
+ sayReviewOffer(ctx, found); return 0;
+ }
const item = found.item;
const agents = withBoardRead(ctx, (board) => store.listAgents(board));
io.result?.({ item, review: Boolean(values.verify), held: Boolean(found.held), shared: found.shared ?? [], reasons: found.reasons ?? [], ...(found.seat ? { seat: found.seat } : {}) });
diff --git a/src/focus-milestone-engine.js b/src/focus-milestone-engine.js
new file mode 100644
index 00000000..045beaea
--- /dev/null
+++ b/src/focus-milestone-engine.js
@@ -0,0 +1,3 @@
+/** Named focus ordering receives its permanent replay version at landing [N2,H16]. */
+import { unassignedEngine } from './engine-next.js';
+export const FOCUS_MILESTONE_ENGINE = unassignedEngine();
diff --git a/src/focus-milestone.js b/src/focus-milestone.js
new file mode 100644
index 00000000..dffb590f
--- /dev/null
+++ b/src/focus-milestone.js
@@ -0,0 +1,33 @@
+/** Named milestone preference reads only recorded board policy and preserves each group's existing order [N2,B16,H16]. */
+import { ENGINE_VERSION } from './machine.js';
+import { FOCUS_MILESTONE_ENGINE } from './focus-milestone-engine.js';
+import { lineSettings } from './line-settings.js';
+import { milestones } from './board-read-auxiliary.js';
+
+/** Historical moves never gain a preference from policy written by a later engine. */
+export function milestoneFocus(board) {
+ if ((board.executionEngineVersion ?? ENGINE_VERSION) < FOCUS_MILESTONE_ENGINE) return null;
+ const name = lineSettings(board).focusMilestone;
+ if (typeof name !== 'string') return null;
+ return { name, ids: new Set(milestones(board).find(milestone => milestone.name === name)?.items ?? []) };
+}
+
+/** Add a leading preference while leaving the caller's established comparison intact within each group. */
+export function focusOrder(board, compare) {
+ const focus = milestoneFocus(board);
+ return focus ? (a, b) => Number(focus.ids.has(b.item_id)) - Number(focus.ids.has(a.item_id)) || compare(a, b) : compare;
+}
+
+/** Only a selected outside item earns this note; existing held work is resumed without a new offer. */
+export function focusReasons(board, item, reasons = []) {
+ const focus = milestoneFocus(board);
+ return focus && item && !focus.ids.has(item.item_id)
+ ? [...reasons, `no claimable work in focus milestone ${focus.name}; offering outside it`]
+ : reasons;
+}
+
+/** The default command compares already eligible offers, never bypassing their normal claim or review guards. */
+export function focusReviewFirst(board, review, build) {
+ const focus = milestoneFocus(board);
+ return !focus || focus.ids.has(review.item_id) || !build || !focus.ids.has(build.item_id);
+}
diff --git a/src/line-settings-cli.js b/src/line-settings-cli.js
index d8ffa171..77a5a756 100644
--- a/src/line-settings-cli.js
+++ b/src/line-settings-cli.js
@@ -24,8 +24,8 @@ export function lineSettingsCommand(io, { second, rest, values = {} }) {
for (const [key, value] of Object.entries(settings)) io.say(`${key}: ${value === false ? 'off' : value}`);
return 0;
}
- if (!second || rest.length !== 1) throw new Refused('USAGE', 'pullboard settings line <name> <on|off|number> --reason "why" --window \'{"windowMinutes":60}\'');
- const value = rest[0] === 'on' ? true : rest[0] === 'off' ? false : Number(rest[0]);
+ if (!second || rest.length !== 1) throw new Refused('USAGE', 'pullboard settings line <name> <value> --reason "why" --window \'{"windowMinutes":60}\'');
+ const value = second === 'focusMilestone' ? (rest[0] === 'off' ? false : rest[0]) : rest[0] === 'on' ? true : rest[0] === 'off' ? false : Number(rest[0]);
return actOn(io, async (ctx, board, me) => {
const change = await ordered(ctx, board, 'setLineSetting', [{ agentId: me.id, key: second, value,
reason: values.reason, window: parseWindow(values.window) }]);
diff --git a/src/line-settings.js b/src/line-settings.js
index dda06cb6..ac6288a8 100644
--- a/src/line-settings.js
+++ b/src/line-settings.js
@@ -6,6 +6,7 @@ import {
validateLineSetting,
validateKnownLineSetting,
} from './queue-settings.js';
+import { FOCUS_MILESTONE_ENGINE } from './focus-milestone-engine.js';
import { LINE_ORDER_ENGINE } from './line-order-engine.js';
import { LINE_SETTINGS_ENGINE } from './line-settings-engine.js';
import { LAND_COLLISION_ENGINE } from './landing-collision-engine.js';
@@ -41,7 +42,7 @@ function windowNumbers(value) {
/** Change one board input atomically with its reason and measured window, so ordered replay makes the same event. */
export function setLineSetting(board, { agentId, key, value, reason, window } = {}) {
if (agentId !== 'coordinator') throw new Refused('COORDINATOR_ONLY', 'ask the coordinator to record a line setting with its reason and window numbers');
- const required = key === 'collisionFreeBatch' ? LAND_COLLISION_ENGINE : key === 'order' ? LINE_ORDER_ENGINE : LINE_SETTINGS_ENGINE;
+ const required = key === 'focusMilestone' ? FOCUS_MILESTONE_ENGINE : key === 'collisionFreeBatch' ? LAND_COLLISION_ENGINE : key === 'order' ? LINE_ORDER_ENGINE : LINE_SETTINGS_ENGINE;
if ((board.executionEngineVersion ?? required) < required) throw new Refused('ENGINE_VERSION', 'upgrade Pullboard before recording or replaying board line settings');
validateLineSetting(key, value);
if (typeof reason !== 'string' || !reason.trim()) throw new Refused('LINE_SETTING_REASON', 'give the reason for this change with --reason "what the measured window shows"');
diff --git a/src/moves/setLineSetting.js b/src/moves/setLineSetting.js
index 7fd79e72..bd33faa9 100644
--- a/src/moves/setLineSetting.js
+++ b/src/moves/setLineSetting.js
@@ -1,3 +1,4 @@
+import { FOCUS_MILESTONE_ENGINE } from '../focus-milestone-engine.js';
import { LAND_COLLISION_ENGINE } from '../landing-collision-engine.js';
import { RIGOR_AUTO_ENGINE } from '../rigor-auto-engine.js';
/** Routing metadata owned by setLineSetting, discovered without a shared registry edit [C7,V4,H16]. */
@@ -7,7 +8,7 @@ import { LINE_SETTINGS_ENGINE } from '../line-settings-engine.js';
import { BOARD_SENTINEL_ENGINE } from '../sentinel-engine.js';
/** Preserve this operation's historical first-matching engine conditions [H16]. */
-function minimumEngine(args, board, at) {
+function historicalMinimumEngine(args, board, at) {
if (typeof args[1]?.cause === 'string' && args[1].cause.startsWith('conflict:')) return RIGOR_AUTO_ENGINE;
if (args[0]?.key === 'collisionFreeBatch') return LAND_COLLISION_ENGINE;
if (args[0]?.key === 'order') return LINE_ORDER_ENGINE;
@@ -16,6 +17,11 @@ function minimumEngine(args, board, at) {
return LINE_SETTINGS_ENGINE;
}
+/** The focus feature composes with every existing conditional floor rather than short-circuiting it. */
+function minimumEngine(args, board, at) {
+ return Math.max(historicalMinimumEngine(args, board, at), args[0]?.key === 'focusMilestone' ? FOCUS_MILESTONE_ENGINE : 1);
+}
+
/** Read precisely the actor argument used by this operation [H2,H16]. */
function actor(move) { return move.args[0]?.agentId ?? null; }
diff --git a/src/queue-settings.js b/src/queue-settings.js
index 535a8370..f6ea8034 100644
--- a/src/queue-settings.js
+++ b/src/queue-settings.js
@@ -89,6 +89,7 @@ export function gateQueueSettings() {
/** Board-owned controller inputs; false means off, independently of machine gate settings. */
export const LINE_SETTING_DEFINITIONS = Object.freeze({
order: Object.freeze({ type: 'boolean' }),
+ focusMilestone: Object.freeze({ type: 'milestone' }),
reviewsFirst: Object.freeze({ type: 'boolean' }),
wipPerReviewer: Object.freeze({ type: 'number', min: 1.5, max: 3, integer: false }),
barReady: Object.freeze({ type: 'boolean' }),
@@ -108,7 +109,8 @@ export function validateLineSetting(key, value) {
export function validateKnownLineSetting(key, value) {
const definition = LINE_SETTING_DEFINITIONS[key];
if (value === false || definition.type === 'boolean' && value === true) return;
+ if (definition.type === 'milestone' && typeof value === 'string' && value.trim() === value && value.length > 0 && !/[\r\n]/u.test(value)) return;
if (definition.type === 'number' && typeof value === 'number' && Number.isFinite(value)
&& value >= definition.min && value <= definition.max && (!definition.integer || Number.isSafeInteger(value))) return;
- throw new Refused('LINE_SETTING_RANGE', `${key} accepts off or ${definition.type === 'boolean' ? 'on' : `${definition.integer ? 'whole numbers ' : 'numbers '}${definition.min} to ${definition.max}`}; read pullboard settings line`);
+ throw new Refused('LINE_SETTING_RANGE', `${key} accepts off or ${definition.type === 'boolean' ? 'on' : definition.type === 'milestone' ? 'a milestone name' : `${definition.integer ? 'whole numbers ' : 'numbers '}${definition.min} to ${definition.max}`}; read pullboard settings line`);
}
diff --git a/test/next-order.test.js b/test/next-order.test.js
index fdfb9f3b..9d5f521a 100644
--- a/test/next-order.test.js
+++ b/test/next-order.test.js
@@ -8,6 +8,7 @@ import { applyEngineMove, applyRelayMove, prepareEngineMove } from '../src/engin
import { ENGINE_VERSION, MILESTONE_RANK_ENGINE } from '../src/machine.js';
import { LINE_ORDER_ENGINE } from '../src/line-order-engine.js';
import { setLineSetting } from '../src/line-settings.js';
+import { FOCUS_MILESTONE_ENGINE } from '../src/focus-milestone-engine.js';
import { exportBoard, importBoard } from '../src/exchange.js';
import { createE2eHelpers } from './e2e-helpers.js';
import { existsSync, mkdirSync, readFileSync } from 'node:fs';
@@ -880,7 +881,78 @@ test('next offers the focus milestone first for eligible reviews without taking
const peer = store.register(board, { lane: 'review', path: '/focus-review-peer', route: 'strong' });
const fallback = store.reserveNextReview(board, { agentId: peer, lane: 'review', leaseMs: HOUR, policy: 'any' });
assert.equal(fallback.item.item_id, outside, 'an unavailable focused review permits eligible outside work');
+ assert.equal(fallback.reasons.filter(reason => /focus.*0\.9\.3|0\.9\.3.*focus/iu.test(reason)).length, 1,
+ 'review-only fallback carries the same one-line explanation');
assert.equal(store.getItem(board, focused).item_verified_by, null, 'a reservation is not a verdict');
assert.equal(store.nextFor(board, { agentId: reviewer, lane: 'review', verify: true, policy: 'any' }).item.item_id,
focused, 'the original reviewer retains its own reservation');
});
+
+/** Native offers are observed against real private Git and SQLite, with synthetic lifecycle records explicitly not gate proofs. */
+test('next offers the focus milestone first across review and build modes [N2,B16]', t => {
+ const box = crossLaneFixture(t);
+ const owner = box.seat('mixed-owner', 'web', box.session);
+ const author = box.seat('mixed-author', 'api', 'mixed-author-session');
+ const outside = box.add('api', 'Outside review');
+ const moreOutside = [box.add('api', 'Outside review two'), box.add('api', 'Outside review three')];
+ const focused = box.add('web', 'Focused build');
+ box.milestone('0.9.4', outside);
+ box.milestone('0.9.3', focused);
+ const board = store.openBoard(join(box.repo, '.git', 'pullboard', 'board.sqlite'));
+ try {
+ for (const id of [outside, ...moreOutside]) {
+ store.claim(board, id, { agentId: author.agent, lane: 'api', leaseMs: HOUR, freeze: FREEZE });
+ submitFixture(board, id, { agentId: author.agent, commit: box.git(box.repo, 'rev-parse', 'HEAD'),
+ tree: box.git(box.repo, 'rev-parse', 'HEAD^{tree}') });
+ }
+ } finally { store.closeBoard(board); }
+ const ordinary = box.json(box.runAs(box.session, owner.root, 'next', '--json'));
+ assert.equal(ordinary.review, true, 'three waiting reviews meet the unchanged offer threshold');
+ assert.equal(ordinary.item.item_id, outside);
+ box.json(box.run(box.repo, 'settings', 'line', 'focusMilestone', '0.9.3',
+ '--reason', 'Focus across both kinds of next work', '--window', '{"activeItems":2}', '--json'));
+ const picked = box.json(box.runAs(box.session, owner.root, 'next', '--json'));
+ assert.equal(picked.item.item_id, focused, 'a focused build outranks an outside review');
+ assert.equal(picked.review, false);
+ box.json(box.runAs(box.session, owner.root, 'release', String(focused), '--json'));
+ const review = box.json(box.runAs(box.session, owner.root, 'next', '--verify', '--json'));
+ assert.equal(review.item.item_id, outside, 'review-only next never silently claims the focused build');
+ assert.equal(review.review, true);
+ box.json(box.runAs(box.session, owner.root, 'release', String(outside), '--json'));
+ const focusedReview = box.add('api', 'Focused review before focused build');
+ const updated = store.openBoard(join(box.repo, '.git', 'pullboard', 'board.sqlite'));
+ try {
+ store.editMilestoneItems(updated, '0.9.3', { agentId: 'coordinator', add: [focusedReview] });
+ store.claim(updated, focusedReview, { agentId: author.agent, lane: 'api', leaseMs: HOUR, freeze: FREEZE });
+ submitFixture(updated, focusedReview, { agentId: author.agent, commit: box.git(box.repo, 'rev-parse', 'HEAD'),
+ tree: box.git(box.repo, 'rev-parse', 'HEAD^{tree}') });
+ } finally { store.closeBoard(updated); }
+ const preferredReview = box.json(box.runAs(box.session, owner.root, 'next', '--json'));
+ assert.equal(preferredReview.item.item_id, focusedReview, 'an eligible focused review precedes the focused build');
+ assert.equal(preferredReview.review, true);
+});
+
+/** A newer recorded control must not alter historical selection when replaying an older move. */
+test('focus milestone policy survives export while old reserve-next retains its ordering [N2,B16,H16]', t => {
+ const { board, builder, reviewer } = boardFixture();
+ t.after(() => store.closeBoard(board));
+ const outside = submitted(board, builder, 'Old roadmap review', 'strong', 1);
+ const focused = submitted(board, builder, 'New focus review', 'strong', 2);
+ store.addMilestone(board, { agentId: 'coordinator', name: 'outside', items: [outside] });
+ store.addMilestone(board, { agentId: 'coordinator', name: 'focus', items: [focused] });
+ const change = { agentId: 'coordinator', key: 'focusMilestone', value: 'focus',
+ reason: 'Recorded focus for replay', window: { activeReviews: 2 } };
+ const settingMove = prepareEngineMove(board, 'setLineSetting', [change]);
+ assert.throws(() => applyEngineMove(board, { ...settingMove, engine: FOCUS_MILESTONE_ENGINE - 1 },
+ { sequence: 1, at: '2026-10-24T00:00:00Z' }), { code: 'RELAY_MOVE' }, 'older engines cannot claim to write the new policy');
+ setLineSetting(board, change);
+ const replica = store.openBoard(':memory:');
+ t.after(() => store.closeBoard(replica));
+ importBoard(replica, exportBoard(board));
+ assert.equal(store.nextFor(replica, { agentId: reviewer, lane: 'review', verify: true }).item.item_id,
+ focused, 'the policy is board data and travels with export');
+ const move = prepareEngineMove(replica, 'reserveNextReview', [{ agentId: reviewer, lane: 'review', leaseMs: HOUR, policy: 'any' }]);
+ const historical = applyEngineMove(replica, { ...move, engine: FOCUS_MILESTONE_ENGINE - 1 },
+ { sequence: 1, at: '2026-10-24T00:00:00Z' });
+ assert.equal(historical.result.item.item_id, outside, 'a historical reservation keeps its previous roadmap order');
+});
diff --git a/test/settings.test.js b/test/settings.test.js
index b7cab7d7..76c3cb6e 100644
--- a/test/settings.test.js
+++ b/test/settings.test.js
@@ -85,7 +85,7 @@ test('a line setting change is a recorded move with its reason and its range [R1
'--window', JSON.stringify(numbers), '--json');
assert.equal(changed.code, 0, `a board setting change succeeds: ${changed.err}${changed.out}`);
assert.equal(initial.code, 0, initial.err);
- const defaults = { order: false, reviewsFirst: false, wipPerReviewer: false, barReady: false, takeoverMinutes: false,
+ const defaults = { order: false, focusMilestone: false, collisionFreeBatch: false, reviewsFirst: false, wipPerReviewer: false, barReady: false, takeoverMinutes: false,
landingBatchSize: false, landingCadenceMinutes: false };
assert.deepEqual(JSON.parse(initial.out).lineSettings, defaults, 'all line controls start off, not silently enabled by a machine file');
assert.equal(JSON.parse(changed.out).lineSettings.reviewsFirst, true);
@@ -97,7 +97,7 @@ test('a line setting change is a recorded move with its reason and its range [R1
assert.deepEqual(JSON.parse(first.event_detail), { key: 'reviewsFirst', value: true,
reason: 'Review waiting exceeds the target', window: numbers, model: 'unknown' });
assert.equal(first.event_by, 'coordinator');
- const values = [['order', true], ['order', false], ['reviewsFirst', false], ['wipPerReviewer', 1.5], ['wipPerReviewer', 3], ['barReady', true],
+ const values = [['focusMilestone', '0.9.3'], ['focusMilestone', false], ['order', true], ['order', false], ['reviewsFirst', false], ['wipPerReviewer', 1.5], ['wipPerReviewer', 3], ['barReady', true],
['takeoverMinutes', 15], ['takeoverMinutes', 60], ['landingBatchSize', 1], ['landingBatchSize', 8],
['landingCadenceMinutes', 5], ['landingCadenceMinutes', 30]];
let sequence = appliedSequence(board);
@@ -114,7 +114,7 @@ test('a line setting change is a recorded move with its reason and its range [R1
}
for (const [key, value] of [['wipPerReviewer', 1.49], ['wipPerReviewer', 3.01], ['takeoverMinutes', 14],
['takeoverMinutes', 61], ['landingBatchSize', 0], ['landingBatchSize', 9], ['landingBatchSize', 1.5],
- ['landingCadenceMinutes', 4], ['landingCadenceMinutes', 31], ['reviewsFirst', 1], ['order', 1]]) {
+ ['focusMilestone', ''], ['focusMilestone', 'two\nlines'], ['focusMilestone', true], ['landingCadenceMinutes', 4], ['landingCadenceMinutes', 31], ['reviewsFirst', 1], ['order', 1]]) {
const before = store.events(board).length;
assert.throws(() => store.setLineSetting(board, { agentId: 'coordinator', key, value, reason: 'Invalid limit', window: numbers }), /LINE_SETTING_RANGE/u);
assert.equal(store.events(board).length, before, 'a refused value appends no successful setting event');