Skip to content

armgit / qm

Public Imported from GitHub
0

Multiplayer agent harness for work.

Fix admin feature flag layout (#1577)

Joshua France4df6e1b1db11
diff --git a/plugins/admin/public/index.html b/plugins/admin/public/index.html
index c0de41de1..a99ace36d 100644
--- a/plugins/admin/public/index.html
+++ b/plugins/admin/public/index.html
@@ -5603,6 +5603,25 @@
#view-governance .sv-customize > .head {
row-gap: 0;
}
+ #feature-flag-list {
+ display: grid;
+ gap: 10px;
+ }
+ #feature-flag-list .feature-flag-row {
+ display: grid;
+ grid-template-columns: minmax(0, 1fr) auto;
+ gap: 12px;
+ align-items: center;
+ }
+ #feature-flag-list .feature-flag-row code {
+ min-width: 0;
+ overflow-wrap: anywhere;
+ }
+ #card-feature-flags .feature-flag-editor {
+ display: grid;
+ gap: 12px;
+ margin-top: 16px;
+ }
#view-governance .sv-customize .body label:not(.setting-toggle) {
margin-bottom: 4px;
font-size: 13px;
diff --git a/plugins/admin/test/settings-lit.test.ts b/plugins/admin/test/settings-lit.test.ts
index cd19c2181..631eaccdf 100644
--- a/plugins/admin/test/settings-lit.test.ts
+++ b/plugins/admin/test/settings-lit.test.ts
@@ -64,6 +64,31 @@ test("model chips add and remove with stable keyed rendering", () => {
dom.window.close();
}
});
+test("feature flag entries use a compact row that cannot inherit the card grid", async () => {
+ const dom = setup();
+ try {
+ dom.window.eval(`settingsUI.configureFlags({
+ loadChoices: async () => [],
+ buildSelector: () => document.createElement("button"),
+ save: async () => ({ ok: true }),
+ })`);
+ await dom.window.eval(`settingsUI.loadFlags(
+ { featureFlags: [{ featureName: "persistent_subagents", enabledScopes: ["personal:[email protected]"] }] },
+ "org:test",
+ )`);
+ await new Promise((resolve) => dom.window.setTimeout(resolve, 0));
+ const list = dom.window.document.getElementById("feature-flag-list")!;
+ assert.equal(list.querySelectorAll(".feature-flag-row").length, 1);
+ assert.equal(list.querySelector(".setting-row"), null);
+ assert.equal(dom.window.getComputedStyle(list.querySelector(".feature-flag-row")!).display, "grid");
+ const editor = dom.window.document.querySelector("#card-feature-flags .feature-flag-editor")!;
+ assert.ok(editor);
+ assert.equal(editor.classList.contains("editor-grid"), false);
+ } finally {
+ dom.window.close();
+ }
+});
+
test("SOUL conflict keeps draft while replacing saved revision and version", () => {
const dom = setup();
try {
diff --git a/plugins/admin/ui/settings-flags.ts b/plugins/admin/ui/settings-flags.ts
index 32d6acf4d..99d1a9dac 100644
--- a/plugins/admin/ui/settings-flags.ts
+++ b/plugins/admin/ui/settings-flags.ts
@@ -112,7 +112,7 @@ function template() {
enabled,
(r) => r.featureName + ":" + r.scopeId,
(r) =>
- html`<div class="setting-row">
+ html`<div class="feature-flag-row">
<code>${r.featureName + ": " + r.scopeId}</code
><button class="danger" ?disabled=${state.saving} @click=${() => remove(r.scopeId, r.featureName)}>
Disable
@@ -122,7 +122,7 @@ function template() {
: "No enabled scopes."
}
</div>
- <div class="editor-grid" style="margin-top: 16px">
+ <div class="feature-flag-editor">
<label
>Feature<select
id="feature-flag-name"