Multiplayer agent harness for work.
Start retention cohort weeks on Monday instead of Thursday (#1928)
Regan Bell722d79adad5f
diff --git a/src/admin/retention.ts b/src/admin/retention.tsindex 0e14045f5..77f88b4e8 100644--- a/src/admin/retention.ts+++ b/src/admin/retention.ts@@ -1,6 +1,7 @@import { forEachAttributedTurn, type AttributionInput } from "./attribution.ts";const DAY = 86_400_000;+const EPOCH_DAY_TO_MONDAY = 3;export interface RetentionInput extends AttributionInput {sessionCount: number;@@ -78,7 +79,7 @@ export function computeRetention(input: RetentionInput): RetentionReport {else returning++;}- const weekOf = (d: number) => Math.floor(d / 7);+ const weekOf = (d: number) => Math.floor((d + EPOCH_DAY_TO_MONDAY) / 7);const weeksActive = new Map<string, Set<number>>();const cohortMembers = new Map<number, string[]>();for (const [u, set] of activeDays) {@@ -99,7 +100,11 @@ export function computeRetention(input: RetentionInput): RetentionReport {const active = members.filter((u) => weeksActive.get(u)!.has(cw + off)).length;return members.length ? Math.round((active / members.length) * 100) : 0;});- return { week: new Date(cw * 7 * DAY).toISOString().slice(0, 10), size: members.length, retained };+ return {+ week: new Date((cw * 7 - EPOCH_DAY_TO_MONDAY) * DAY).toISOString().slice(0, 10),+ size: members.length,+ retained,+ };});const sessionCounts = users.map((u) => sessionsByUser.get(u)?.size ?? 0).sort((a, b) => a - b);diff --git a/test/admin-retention.test.ts b/test/admin-retention.test.tsindex 58f19f14c..67959308e 100644--- a/test/admin-retention.test.ts+++ b/test/admin-retention.test.ts@@ -47,6 +47,8 @@ test("computeRetention: DAU/WAU/MAU, cohorts, new-vs-returning, and channel apprassert.deepEqual(report.perUser.turns, { p50: 1, p95: 4 });assert.equal(report.cohorts.length, 3);+ for (const cohort of report.cohorts) assert.equal(new Date(`${cohort.week}T00:00:00Z`).getUTCDay(), 1);+ assert.equal(report.cohorts[2]!.week, "1972-09-25");assert.deepEqual(report.cohorts[1]!.retained, [100, 0, 0, 0, 100]);assert.equal(report.cohorts[1]!.size, 1);assert.equal(report.cohorts[2]!.size, 3);