Skip to content

armgit / qm

Public Imported from GitHub
0

Multiplayer agent harness for work.

$fix: keep tab widths stable on hover\n\nCo-Authored-By: QM <[email protected]>

Joshua France855cfe54a53f
diff --git a/plugins/web-ui/src/shell.css b/plugins/web-ui/src/shell.css
index 08e458f58..109768e8a 100644
--- a/plugins/web-ui/src/shell.css
+++ b/plugins/web-ui/src/shell.css
@@ -6870,13 +6870,11 @@ h3.ambient-field-label {
background: var(--secondary);
}
-/* Per-tab close: an 18px slot, revealed on hover — the cron-row actions pattern. The tab
- the user is in always reserves it; the rest hand those pixels to their label until
- hovered, which in a narrow strip is the difference between a title and a syllable. Tab
- widths come off a fixed basis, so the slot opening resizes nothing but its own label.
- `margin-left: auto` parks the slot against the chip's trailing edge: a tab is sized by
- that basis, not by its title, so anchoring the close to the end of the text strands it
- mid-chip on every title shorter than the tab. */
+/* Per-tab close: an 18px slot, revealed on hover — the cron-row actions pattern. Every
+ tab reserves the slot even while it is transparent, so hovering never changes intrinsic
+ tab width or makes dockview reflow the strip. `margin-left: auto` parks the slot against
+ the chip's trailing edge: a tab is sized by its basis, not by its title, so anchoring the
+ close to the end of the text strands it mid-chip on every short title. */
.split-tab-close {
width: 18px;
height: 18px;
@@ -6884,10 +6882,7 @@ h3.ambient-field-label {
margin-left: auto;
border-radius: 5px;
opacity: 0;
- transition:
- opacity 0.12s ease,
- width 0.12s ease,
- min-width 0.12s ease;
+ transition: opacity 0.12s ease;
}
/* When the archive button is present it takes the auto margin; the close button that
@@ -6896,11 +6891,6 @@ h3.ambient-field-label {
margin-left: 2px;
}
-.dv-tab:not(.dv-active-tab):not(:hover):not(:focus-within) .split-tab-close {
- width: 0;
- min-width: 0;
-}
-
.dv-tab.dv-active-tab .split-tab-close {
opacity: 0.55;
}
diff --git a/plugins/web-ui/test/split-tiles-and-titles.test.ts b/plugins/web-ui/test/split-tiles-and-titles.test.ts
index e56420370..0cdabb145 100644
--- a/plugins/web-ui/test/split-tiles-and-titles.test.ts
+++ b/plugins/web-ui/test/split-tiles-and-titles.test.ts
@@ -88,14 +88,17 @@ test("tabs share the strip evenly down to a legible floor", () => {
assert.match(multi, /max-width: 220px;/);
});
+test("hovering a tab does not change its action-slot width", () => {
+ const close = css.match(/^\.split-tab-close \{[^}]*\}/m)?.[0] ?? "";
+ assert.doesNotMatch(close, /transition:[^}]*\b(?:width|min-width)\b/s);
+ assert.doesNotMatch(css, /:not\(:hover\):not\(:focus-within\) \.split-tab-close \{[^}]*(?:width|min-width): 0;/);
+});
+
test("the per-tab close floats to the end of the tab", () => {
const close = css.match(/^\.split-tab-close \{[^}]*\}/m)?.[0] ?? "";
assert.match(close, /margin-left: auto;/);
assert.match(css, /\.dv-tab \.split-pane-title \{[^}]*flex: 1 1 auto;/);
assert.match(css, /\.split-pane-title-text \{[^}]*margin-right: 6px;/);
- const collapsed = css.match(/:not\(:hover\):not\(:focus-within\) \.split-tab-close \{[^}]*\}/)?.[0] ?? "";
- assert.ok(collapsed, "the collapsed-slot rule not found");
- assert.doesNotMatch(collapsed, /margin-left:/);
});
test("the tab overflow menu is lifted above the panes and styled", () => {