Skip to content

armgit / qm

Public Imported from GitHub
0

Multiplayer agent harness for work.

fix: clarify agent computer egress warning

Josh Francec7236f3797ad
diff --git a/plugins/admin/public/index.html b/plugins/admin/public/index.html
index 87463177e..290b8f31e 100644
--- a/plugins/admin/public/index.html
+++ b/plugins/admin/public/index.html
@@ -5370,8 +5370,10 @@
<div class="body">
<div class="governance-capability" id="egress-capability" role="status">
<div>
- <strong>Egress policy unavailable</strong
- ><span>The deployment backend cannot enforce outbound host policy.</span>
+ <strong>Agent computer egress policy unavailable</strong
+ ><span
+ >The agent computer provider cannot enforce host restrictions on all outbound traffic.</span
+ >
</div>
</div>
<div class="egress-empty-state">
@@ -7681,13 +7683,15 @@
);
const capability = $("egress-capability");
capability.classList.toggle("hidden", !!enforcement.active);
- let enforcementTitle = "Egress policy unavailable";
+ let enforcementTitle = "Agent computer egress policy unavailable";
if (enforcement.reason === "control_plane_unconfigured") enforcementTitle = "Enforcement is not activated";
capability.querySelector("strong").textContent = enforcementTitle;
let enforcementSummary =
- "This deployment’s " + titleCase(enforcement.backend) + " backend cannot enforce outbound host policy.";
+ "Agent computers use " +
+ titleCase(enforcement.backend) +
+ ", which cannot enforce host restrictions on all outbound traffic. A configured egress proxy still applies policy to traffic sent through it.";
if (enforcement.reason === "control_plane_unconfigured") {
- enforcementSummary = "Egress enforcement has not been activated for this deployment.";
+ enforcementSummary = "Egress enforcement has not been activated for agent computers.";
}
capability.querySelector("span").textContent = enforcementSummary;
const egressCard = $("card-egress");
diff --git a/plugins/admin/test/default-view.test.ts b/plugins/admin/test/default-view.test.ts
index 9ea7c6162..fe7cce21f 100644
--- a/plugins/admin/test/default-view.test.ts
+++ b/plugins/admin/test/default-view.test.ts
@@ -285,7 +285,7 @@ test("governance reviews high-impact changes in product and preserves drafts", (
assert.doesNotMatch(html, /confirm\("Enable Dangerous/);
});
-test("governance disables egress controls when the deployment cannot enforce them", () => {
+test("governance disables egress controls when agent computers cannot enforce them", () => {
assert.match(html, /id="egress-capability"/);
assert.doesNotMatch(html, /View deployment/);
assert.match(html, /id="egress-deny-editor"/);
@@ -298,11 +298,16 @@ test("governance disables egress controls when the deployment cannot enforce the
assert.match(html, /capability\.classList\.toggle\("hidden", !!enforcement\.active\)/);
assert.match(html, /control\.disabled = !enforcement\.active/);
assert.match(html, /enforcement\.reason === "control_plane_unconfigured"/);
- assert.match(html, /Egress enforcement has not been activated for this deployment/);
+ assert.match(html, /Egress enforcement has not been activated for agent computers/);
assert.match(html, /Backend supports policy; control plane inactive/);
assert.match(html, /Backend cannot enforce host policy/);
assert.doesNotMatch(html, /fidelity, which cannot enforce outbound host policy/);
assert.doesNotMatch(html, /Agents still have open outbound access/);
+ assert.match(html, /Agent computer egress policy unavailable/);
+ assert.match(html, /"Agent computers use "\s*\+\s*titleCase\(enforcement.backend\)/);
+ assert.match(html, /cannot enforce host restrictions on all outbound traffic/);
+ assert.match(html, /A configured egress proxy still applies policy to traffic sent through it/);
+ assert.doesNotMatch(html, /This deployment’s|The deployment backend cannot enforce/);
});
test("governance keeps effective-state summaries synchronized after focused saves", () => {