Multiplayer agent harness for work.
logs: never pass a raw error object to console.* (#408)
Regan Bellcb29020f30e3
diff --git a/eslint.config.mjs b/eslint.config.mjsindex 8283c57fd..4567fd9c3 100644--- a/eslint.config.mjs+++ b/eslint.config.mjs@@ -58,6 +58,14 @@ export default tseslint.config(message:"Read configuration through loadConfig() (src/config.ts) and pass it down — process.env is parsed exactly once at the boundary.",},+ {+ // Never dump a raw error object to the console: an error can carry HTTP+ // response bodies, connection strings, or credential material. Wrap it in+ // errMessage(...) (src/util/errors.ts) so only the message is logged.+ selector: "CallExpression[callee.object.name='console'] > Identifier.arguments[name=/^(e|err|error)$/]",+ message:+ "Pass errMessage(e), not the raw error object, to console.* — raw errors can leak response bodies or secrets into logs.",+ },{selector: "VariableDeclarator[init.name='process'] ObjectPattern Property[key.name='env']",message:@@ -85,4 +93,19 @@ export default tseslint.config(],},},+ {+ // Same raw-error rule for plugin server code and the src files the env-boundary+ // block above deliberately skips (local scripts/ and test/ CLIs keep full stacks).+ files: ["plugins/**/*.ts", "src/config.ts", "src/index.ts", "src/runs/worker-main.ts", "src/egress-authz-main.ts"],+ rules: {+ "no-restricted-syntax": [+ "error",+ {+ selector: "CallExpression[callee.object.name='console'] > Identifier.arguments[name=/^(e|err|error)$/]",+ message:+ "Pass errMessage(e), not the raw error object, to console.* — raw errors can leak response bodies or secrets into logs.",+ },+ ],+ },+ },);diff --git a/plugins/admin/src/index.ts b/plugins/admin/src/index.tsindex 25106783a..31b62cb25 100644--- a/plugins/admin/src/index.ts+++ b/plugins/admin/src/index.ts@@ -141,7 +141,7 @@ async function forward(res.writeHead(r.status, { "content-type": "application/json" });pipeBody(res, r.body);} catch (err) {- console.error("[admin] core request failed:", err);+ console.error("[admin] core request failed:", String(err));json(res, 502, { error: "core_unreachable", message: "core unavailable" });}}@@ -176,7 +176,7 @@ async function forwardDownload(res: ServerResponse, principal: string, corePath:res.writeHead(r.status, headers);pipeBody(res, r.body);} catch (err) {- console.error("[admin] core download failed:", err);+ console.error("[admin] core download failed:", String(err));json(res, 502, { error: "core_unreachable", message: "core unavailable" });}}@@ -236,7 +236,7 @@ async function uploadFileFromRequest(});return forward(req, res, principal, "POST", corePath, body);} catch (err) {- console.error("[admin] upload failed:", err);+ console.error("[admin] upload failed:", String(err));return json(res, 502, { error: "core_unreachable", message: "core unavailable" });}}@@ -301,7 +301,7 @@ const server = createServer((req, res) => {void portalTokenStore.run(token, () => handle(req, res)).catch((err: unknown) => {- console.error("[admin] unhandled request error:", err);+ console.error("[admin] unhandled request error:", String(err));json(res, 500, { error: "internal_error", message: "internal server error" });});});@@ -402,7 +402,7 @@ async function handle(req: IncomingMessage, res: ServerResponse): Promise<void>res.writeHead(r.status, { "content-type": "application/json" });res.end(text);} catch (err) {- console.error("[admin] core request failed:", err);+ console.error("[admin] core request failed:", String(err));json(res, 502, { error: "core_unreachable", message: "core unavailable" });}return;diff --git a/plugins/auth/src/index.ts b/plugins/auth/src/index.tsindex ee2533206..b63ba85a3 100644--- a/plugins/auth/src/index.ts+++ b/plugins/auth/src/index.ts@@ -32,7 +32,7 @@ export async function startServer(): Promise<void> {});const server = createServer((req, res) => {void handle(req, res).catch((err: unknown) => {- console.error(`[auth] 500 ${req.method ?? "?"} ${(req.url ?? "?").split("?")[0]}:`, err);+ console.error("[auth] 500 %s %s: %s", req.method ?? "?", (req.url ?? "?").split("?")[0], String(err));if (!res.headersSent) json(res, 500, { error: "internal_error" });else res.end();});diff --git a/plugins/chassis/src/branding.ts b/plugins/chassis/src/branding.tsindex 82ccb7e9e..3ba6758de 100644--- a/plugins/chassis/src/branding.ts+++ b/plugins/chassis/src/branding.ts@@ -29,7 +29,7 @@ export function createBrandingCache(fetchBranding: () => Promise<OrgBranding>):warmed = true;nextAt = Date.now() + REFRESH_MS;} catch (err) {- if (process.env.BRANDING_DEBUG) console.error("[branding] fetch failed:", err);+ if (process.env.BRANDING_DEBUG) console.error("[branding] fetch failed:", String(err));nextAt = Date.now() + RETRY_MS;} finally {inflight = null;diff --git a/plugins/portal/src/index.ts b/plugins/portal/src/index.tsindex 2ecde29cd..395064e37 100644--- a/plugins/portal/src/index.ts+++ b/plugins/portal/src/index.ts@@ -812,7 +812,7 @@ function renewSessionCookie(req: IncomingMessage, res: ServerResponse): void {const server = createServer((req, res) => {void handle(req, res).catch((err: unknown) => {- console.error(`[portal] 500 ${req.method ?? "?"} ${(req.url ?? "?").split("?")[0]}:`, err);+ console.error("[portal] 500 %s %s: %s", req.method ?? "?", (req.url ?? "?").split("?")[0], String(err));if (!res.headersSent) json(res, 500, { error: "internal_error" });else res.end();});diff --git a/plugins/web-ui/server/index.ts b/plugins/web-ui/server/index.tsindex 58478e1b5..b3aff0ee9 100644--- a/plugins/web-ui/server/index.ts+++ b/plugins/web-ui/server/index.ts@@ -1976,7 +1976,7 @@ export const handler = async (req: IncomingMessage, res: ServerResponse) => {const server = createServer((req, res) => {void handler(req, res).catch((err: unknown) => {- console.error(`[web-ui] 502 ${req.method ?? "?"} ${req.url ?? "?"}:`, err);+ console.error("[web-ui] 502 %s %s: %s", req.method ?? "?", req.url ?? "?", String(err));if (!res.headersSent) json(res, 502, { error: "bad_gateway", message: "upstream error" });else res.end();});@@ -2000,7 +2000,7 @@ if (process.argv[1] && fileURLToPath(import.meta.url) === process.argv[1]) {});}).catch((err: unknown) => {- console.error("[web-ui] failed to start:", err);+ console.error("[web-ui] failed to start:", String(err));process.exit(1);});}diff --git a/src/admin/postgres-audit-log.ts b/src/admin/postgres-audit-log.tsindex 8a6023056..fda9e3ddd 100644--- a/src/admin/postgres-audit-log.ts+++ b/src/admin/postgres-audit-log.ts@@ -1,6 +1,7 @@import { createPgPool } from "../persistence/pg-pool.ts";import type { ScopeId } from "../types.ts";import type { AuditEvent, AuditLog } from "../audit/audit-log.ts";+import { errMessage } from "../util/errors.ts";function rowToEvent(r: Record<string, unknown>): AuditEvent {return {@@ -61,7 +62,7 @@ export function createPostgresAuditLog(connectionString: string): AuditLog {e.detail ?? null,]).then(() => undefined)- .catch((err) => console.error("[audit] failed to persist event to durable store:", err));+ .catch((err) => console.error("[audit] failed to persist event to durable store:", errMessage(err)));pendingWrites.add(write);void write.finally(() => pendingWrites.delete(write));},diff --git a/src/admin/postgres-metrics-sink.ts b/src/admin/postgres-metrics-sink.tsindex 0fbdf1f03..29187f828 100644--- a/src/admin/postgres-metrics-sink.ts+++ b/src/admin/postgres-metrics-sink.ts@@ -1,5 +1,6 @@import { createPostgresEventSink, type EventColumn } from "./scoped-event-sink.ts";import type { MetricsSink, TurnMetricSample } from "./metrics-sink.ts";+import { errMessage } from "../util/errors.ts";const COLUMNS: readonly EventColumn<keyof TurnMetricSample & string>[] = [["ts", "ts", "BIGINT", "number", true],@@ -76,7 +77,7 @@ export function createPostgresMetricsSink(connectionString: string): MetricsSinkparams.push(runId);await sink.q(`UPDATE turn_metrics SET ${sets.join(", ")} WHERE run_id = $${params.length}`, params)- .catch((err) => console.error("[metrics] failed to patch turn metric:", err));+ .catch((err) => console.error("[metrics] failed to patch turn metric:", errMessage(err)));},list: (opts = {}) => sink.list(opts),};diff --git a/src/admin/scoped-event-sink.ts b/src/admin/scoped-event-sink.tsindex 25f1dc3ac..48eff01f0 100644--- a/src/admin/scoped-event-sink.ts+++ b/src/admin/scoped-event-sink.ts@@ -1,5 +1,6 @@import type { ScopeId } from "../types.ts";import { createPgPool, type PgPool } from "../persistence/pg-pool.ts";+import { errMessage } from "../util/errors.ts";export interface ScopedEvent {scopeLabel: ScopeId;@@ -162,7 +163,7 @@ export function createPostgresEventSink<E>(cfg: PostgresEventSinkConfig<E>): Posconst s = input as Record<string, unknown>;const values = cfg.columns.map(([, js]) => (js === "ts" ? Date.now() : (s[js] ?? null)));const write = q(insertSql, values)- .catch((err) => console.error(cfg.persistErrorMessage, err))+ .catch((err) => console.error(cfg.persistErrorMessage, errMessage(err))).finally(() => pendingWrites.delete(write));pendingWrites.add(write);},diff --git a/src/api/server.ts b/src/api/server.tsindex 8b82a11fb..7cd533842 100644--- a/src/api/server.ts+++ b/src/api/server.ts@@ -299,7 +299,7 @@ function respondError(req: IncomingMessage, res: ServerResponse, err: unknown):else res.destroy();return;}- console.error(`[server] 500 ${req.method ?? "?"} ${req.url ?? "?"}:`, err);+ console.error("[server] 500 %s %s: %s", req.method ?? "?", req.url ?? "?", errMessage(err));if (!res.headersSent) sendJson(res, 500, { error: "internal_error", message: "internal server error" });else res.destroy();}@@ -368,7 +368,7 @@ function buildFastify(wiring: Wiring, server: Server): { fastify: FastifyInstancfastify.decorateRequest("gate", undefined);fastify.setErrorHandler((err, request, reply) => {- console.error(`[server] 500 ${request.raw.method ?? "?"} ${request.raw.url ?? "?"}:`, err);+ console.error(`[server] 500 ${request.raw.method ?? "?"} ${request.raw.url ?? "?"}:`, errMessage(err));return reply.code(500).send({ error: "internal_error", message: "internal server error" });});@@ -451,7 +451,7 @@ function buildServer(app: App, deps: ServerOptions, allowUnsignedSourceAuth: boo});const { fastify, routing } = buildFastify(wiring, server);const ready = Promise.resolve(fastify.ready());- ready.catch((err: unknown) => console.error("[server] fastify initialization failed:", err));+ ready.catch((err: unknown) => console.error("[server] fastify initialization failed:", errMessage(err)));server.requestTimeout = 30_000;server.headersTimeout = 10_000;server.keepAliveTimeout = 5_000;diff --git a/src/core/orchestrator.ts b/src/core/orchestrator.tsindex e391d9ce6..7429839b2 100644--- a/src/core/orchestrator.ts+++ b/src/core/orchestrator.ts@@ -514,7 +514,7 @@ export function createOrchestrator(deps: OrchestratorDeps): Orchestrator {try {await deps.sessions.recordLlmRequest(screenSession.id, { ...rec, scopeLabel: scopeId });} catch (err) {- console.error("[orchestrator] failed to persist security screen request snapshot:", err);+ console.error("[orchestrator] failed to persist security screen request snapshot:", errMessage(err));}};let screenedOverheard: OverheardEntryPayload[] = [];@@ -2442,7 +2442,7 @@ export function createOrchestrator(deps: OrchestratorDeps): Orchestrator {try {await deps.sessions.recordLlmRequest(session.id, { ...rec, scopeLabel: scopeId });} catch (err) {- console.error("[orchestrator] failed to persist LLM request snapshot:", err);+ console.error("[orchestrator] failed to persist LLM request snapshot:", errMessage(err));}},});diff --git a/src/cron/scheduler.ts b/src/cron/scheduler.tsindex 9e437e382..cfb935069 100644--- a/src/cron/scheduler.ts+++ b/src/cron/scheduler.ts@@ -205,12 +205,12 @@ export function createScheduler(deps: SchedulerDeps): Scheduler {const t = nowArg ?? now();await leaderLease.hold(TICK_LEASE_KEY, async () => {await fireDue(t);- await deps.sweepAsks?.(t).catch((e: unknown) => console.error("[scheduler] ask sweep failed:", e));+ await deps.sweepAsks?.(t).catch((e: unknown) => console.error("[scheduler] ask sweep failed:", errMessage(e)));});};const sweeper = createSweeper(- () => tick().catch((e: unknown) => console.error("[scheduler] tick failed:", e)),+ () => tick().catch((e: unknown) => console.error("[scheduler] tick failed:", errMessage(e))),1000,{ label: "scheduler" },);@@ -244,7 +244,7 @@ export function createScheduler(deps: SchedulerDeps): Scheduler {return;}} catch (e) {- console.error("[scheduler] fire failed:", e);+ console.error("[scheduler] fire failed:", errMessage(e));await deps.crons.unclaimSlot(job.cronId, slot, t, cron.lastFiredAt);return;}@@ -259,9 +259,9 @@ export function createScheduler(deps: SchedulerDeps): Scheduler {if (slot !== undefined) await deps.jobQueue!.enqueueFire({ cronId: cron.id, scheduledAt: slot });}} catch (e) {- console.error("[scheduler] tick failed:", e);+ console.error("[scheduler] tick failed:", errMessage(e));}- await deps.sweepAsks?.(now()).catch((e: unknown) => console.error("[scheduler] ask sweep failed:", e));+ await deps.sweepAsks?.(now()).catch((e: unknown) => console.error("[scheduler] ask sweep failed:", errMessage(e)));}const leaseGuard = createSweeper(diff --git a/src/delivery/run-result-delivery.ts b/src/delivery/run-result-delivery.tsindex 4f8c3959e..588655a10 100644--- a/src/delivery/run-result-delivery.ts+++ b/src/delivery/run-result-delivery.ts@@ -4,6 +4,7 @@ import type { DeliveryStore } from "./delivery-store.ts";import type { Task, TaskStore } from "../tasks/task-store.ts";import { SECURITY_QUARANTINE_REFUSAL_TEXT } from "../../plugins/chassis/src/security-quarantine.ts";import { resolveTurnOrigin } from "../core/turn-origin.ts";+import { errMessage } from "../util/errors.ts";export interface RunResultDelivery {destination: Destination;@@ -56,6 +57,8 @@ export function wireRunResultDeliveries(runs: RunStore, deliveries: DeliveryStorconst delivery = runResultDelivery(run, taskList);if (!delivery) return;await deliveries.enqueue(delivery);- })().catch((err) => console.error(`[delivery] failed to enqueue recovery delivery for run ${run.id}:`, err));+ })().catch((err) =>+ console.error(`[delivery] failed to enqueue recovery delivery for run ${run.id}:`, errMessage(err)),+ );});}diff --git a/src/harness/pi-harness.ts b/src/harness/pi-harness.tsindex 5355a8f32..6f7410c9e 100644--- a/src/harness/pi-harness.ts+++ b/src/harness/pi-harness.ts@@ -76,6 +76,7 @@ import { ELIDED_IMAGE_TEXT, planTapeSeed } from "./tape-fold.ts";import { compactTranscript, deterministicCompactSummary, estimateHistoryTokens } from "./context-compaction.ts";import { countTokens } from "../util/tokens.ts";import { parseSecurityScreenVerdict, SECURITY_SCREEN_SYSTEM_PROMPT } from "../security/security-posture.ts";+import { errMessage } from "../util/errors.ts";export interface PiHarnessOptions {modelId?: string | ((scope?: ScopeId) => string | undefined);@@ -1272,7 +1273,7 @@ export function createPiHarness(opts?: PiHarnessOptions): Harness {try {reconstructed = reconstructMessagesFromHistory(history);} catch (err) {- console.error("[pi-harness] history reconstruction failed; will fall back:", err);+ console.error("[pi-harness] history reconstruction failed; will fall back:", errMessage(err));reconstructed = null;}let foldSeed: PiReplayMessage[] | null = null;@@ -1291,7 +1292,7 @@ export function createPiHarness(opts?: PiHarnessOptions): Harness {);}} catch (err) {- console.error(`${tag} fold threw:`, err);+ console.error(`${tag} fold threw:`, errMessage(err));}}const seedSource = foldSeed ?? reconstructed;@@ -1339,7 +1340,7 @@ export function createPiHarness(opts?: PiHarnessOptions): Harness {try {seedRawMessagesIntoSession(session, seedSource!);} catch (err) {- console.error("[pi-harness] failed to seed reconstructed history (continuing without it):", err);+ console.error("[pi-harness] failed to seed reconstructed history (continuing without it):", errMessage(err));}} else if (seedPlan === "priorTurns") {try {@@ -1358,7 +1359,7 @@ export function createPiHarness(opts?: PiHarnessOptions): Harness {}}} catch (err) {- console.error("[pi-harness] failed to seed prior turns (continuing without them):", err);+ console.error("[pi-harness] failed to seed prior turns (continuing without them):", errMessage(err));}}diff --git a/src/idempotency/idempotency-store.ts b/src/idempotency/idempotency-store.tsindex 012931ee7..f700b64bc 100644--- a/src/idempotency/idempotency-store.ts+++ b/src/idempotency/idempotency-store.ts@@ -1,4 +1,5 @@import type { DurableMap } from "../persistence/durable-map.ts";+import { errMessage } from "../util/errors.ts";export interface IdempotencyRecord {key: string;@@ -41,7 +42,7 @@ export function createIdempotencyStore(if (r.at < cutoff) await backing.delete(r.key);}})().catch((e: unknown) => {- console.error("[idempotency] retention prune failed:", e);+ console.error("[idempotency] retention prune failed:", errMessage(e));});}diff --git a/src/monitors/monitor-poller.ts b/src/monitors/monitor-poller.tsindex 57b1580c7..62efcad67 100644--- a/src/monitors/monitor-poller.ts+++ b/src/monitors/monitor-poller.ts@@ -266,13 +266,13 @@ export function createMonitorPoller(deps: MonitorPollerDeps): MonitorPoller {if (await poll(sandbox, handle, m, t)) fires++;} catch (e) {await deps.monitors.recordError(m.id, errMessage(e));- console.error(`[monitor] poll failed for ${m.id}:`, e);+ console.error(`[monitor] poll failed for ${m.id}:`, errMessage(e));}}} finally {for (const handle of handles.values()) {await sandbox.teardown(handle, { keepWarm: true }).catch((e: unknown) => {- console.error("[monitor] teardown failed:", e);+ console.error("[monitor] teardown failed:", errMessage(e));});}}@@ -284,7 +284,7 @@ export function createMonitorPoller(deps: MonitorPollerDeps): MonitorPoller {};const sweeper = createSweeper(- () => tick().catch((e: unknown) => console.error("[monitor] tick failed:", e)),+ () => tick().catch((e: unknown) => console.error("[monitor] tick failed:", errMessage(e))),10_000,{ label: "monitor" },);diff --git a/src/persistence/pg-pool.ts b/src/persistence/pg-pool.tsindex 976bd8e14..d2ed10295 100644--- a/src/persistence/pg-pool.ts+++ b/src/persistence/pg-pool.ts@@ -1,5 +1,6 @@import type { Pool, PoolClient } from "pg";import { swallowAs } from "../util/errors.ts";+import { errMessage } from "../util/errors.ts";export type { Pool, PoolClient };@@ -63,7 +64,7 @@ export function createPgPool(connectionString: string, statements: string[]): PgpoolP = (async () => {const pg = (await import("pg")).default;const p = new pg.Pool({ connectionString });- p.on("error", (err) => console.error("[pg] idle client error:", err));+ p.on("error", (err) => console.error("[pg] idle client error:", errMessage(err)));try {await applyDdl(p, schema);} catch (e) {diff --git a/src/processes/process-reaper.ts b/src/processes/process-reaper.tsindex 3f8ad1b21..51fb3341a 100644--- a/src/processes/process-reaper.ts+++ b/src/processes/process-reaper.ts@@ -4,6 +4,7 @@ import { createNoopLeaderLease, type LeaderLease } from "../persistence/leader-limport { awaitProcessExit } from "../sandbox/await-process-exit.ts";import { processIsGone } from "../sandbox/process-poll.ts";import type { ProcessSandbox } from "../sandbox/sandbox.ts";+import { errMessage } from "../util/errors.ts";const PROCESS_REAPER_LEASE_KEY = "processes:reaper";@@ -66,7 +67,9 @@ export function createProcessReaper(registry: ProcessRegistry, opts: ProcessReapif (!flipped) continue;reaped++;if (opts.onReaped)- await opts.onReaped(rec).catch((err) => console.error("[process-reaper] onReaped hook failed:", err));+ await opts+ .onReaped(rec)+ .catch((err) => console.error("[process-reaper] onReaped hook failed:", errMessage(err)));}return { reaped };}diff --git a/src/ratelimit/postgres-budget.ts b/src/ratelimit/postgres-budget.tsindex dde1f32ce..d09c8409e 100644--- a/src/ratelimit/postgres-budget.ts+++ b/src/ratelimit/postgres-budget.ts@@ -1,6 +1,7 @@import { createPgPool } from "../persistence/pg-pool.ts";import type { BudgetTracker } from "./budget.ts";import { DEFAULT_BUDGET_WINDOW_MS } from "./budget.ts";+import { errMessage } from "../util/errors.ts";export function createPostgresBudgetTracker(connectionString: string,@@ -45,7 +46,7 @@ export function createPostgresBudgetTracker();}} catch (err) {- console.error("[budget] failed to persist spend:", err);+ console.error("[budget] failed to persist spend:", errMessage(err));}},};diff --git a/src/resolution/config-store.ts b/src/resolution/config-store.tsindex 754afd0b7..66e029c72 100644--- a/src/resolution/config-store.ts+++ b/src/resolution/config-store.ts@@ -19,6 +19,7 @@ import {type PublicConnectorClient,type DecryptedConnectorClient,} from "../connectors/connector-client-store.ts";+import { errMessage } from "../util/errors.ts";export interface PersistedSoul {scopeId: ScopeId;@@ -267,7 +268,8 @@ export function createMemoryConfigStore(const browseModelStore = opts.browseModels ?? createMemoryMap<PersistedBrowseModel>();const turnWallClockStore = opts.turnWallClocks ?? createMemoryMap<PersistedTurnWallClock>();const deploymentIdentity = opts.deploymentIdentity ?? createMemoryMap<PersistedDeploymentIdentity>();- const persistWarn = (what: string) => (e: unknown) => console.error(`[config] failed to persist ${what}:`, e);+ const persistWarn = (what: string) => (e: unknown) =>+ console.error(`[config] failed to persist ${what}:`, errMessage(e));const writeQueue = createKeyedQueue();const pendingWrites = new Map<string, Promise<void>>();const persist = (key: string, what: string, op: () => Promise<unknown>): void => {@@ -285,7 +287,7 @@ export function createMemoryConfigStore(try {listener(id);} catch (e) {- console.error("[config] runtime-selection listener failed:", e);+ console.error("[config] runtime-selection listener failed:", errMessage(e));}}};diff --git a/src/wiring.ts b/src/wiring.tsindex 4e86e18ba..5c8604e75 100644--- a/src/wiring.ts+++ b/src/wiring.ts@@ -514,13 +514,13 @@ export function buildApp(}};skillsReady = Promise.all([- installCatalogs().catch((e) => console.error("[seed] failed to install seed skills:", e)),- deploymentLayerReady.catch((e) => console.error("[seed] deployment layer not ready:", e)),+ installCatalogs().catch((e) => console.error("[seed] failed to install seed skills:", errMessage(e))),+ deploymentLayerReady.catch((e) => console.error("[seed] deployment layer not ready:", errMessage(e))),]).then(() => undefined);} else {skillsReady = deploymentLayerReady.then(() => undefined,- (e) => console.error("[seed] deployment layer not ready:", e),+ (e) => console.error("[seed] deployment layer not ready:", errMessage(e)),);}const rateLimitOpts = { maxPerWindow: config.rateLimitPerWindow, windowMs: config.rateLimitWindowMs };