Skip to content

armgit / qm

Public Imported from GitHub
0

Multiplayer agent harness for work.

Polish sidebar conversation styling (#1434)

Eve Bouffardd76d1b86a342
diff --git a/plugins/web-ui/src/shell.css b/plugins/web-ui/src/shell.css
index a95da344e..d4b6699b2 100644
--- a/plugins/web-ui/src/shell.css
+++ b/plugins/web-ui/src/shell.css
@@ -678,7 +678,7 @@ a.chat-row-open {
align-items: center;
gap: 5px;
min-height: 30px;
- margin: 3px 0 5px 4px;
+ margin: 3px 0 0 4px;
padding: 4px 3px 4px 2px;
color: var(--foreground);
font-size: 12.5px;
@@ -708,41 +708,31 @@ a.chat-row-open {
--session-action-hover: color-mix(in srgb, var(--session-color) 24%, var(--secondary));
--session-action-foreground: color-mix(in srgb, var(--session-color) 68%, var(--foreground));
}
+.session-row:is(.colored, .active, .menu-open, .selected, .read-only, :hover) .session {
+ width: calc(100% + 4px);
+ margin-left: -4px;
+ padding-left: 15px;
+}
.session-row.colored .session {
- background: linear-gradient(
- 110deg,
- color-mix(in srgb, var(--session-color) 22%, transparent),
- color-mix(in srgb, var(--session-color) 10%, transparent)
- );
+ background: color-mix(in srgb, var(--session-color) 16%, transparent);
+}
+.recent-project-children .session-row:is(.colored, .active, .menu-open, .selected, .read-only, :hover) .session,
+.archived-children .session-row:is(.colored, .active, .menu-open, .selected, .read-only, :hover) .session,
+.pinned-children .session-row:is(.colored, .active, .menu-open, .selected, .read-only, :hover) .session {
+ padding-left: 10px;
}
.session-row.colored .session:hover,
.session-row.colored.menu-open .session {
- background: linear-gradient(
- 110deg,
- color-mix(in srgb, var(--session-color) 30%, transparent),
- color-mix(in srgb, var(--session-color) 16%, transparent)
- );
+ background: color-mix(in srgb, var(--session-color) 23%, transparent);
}
.session-row.colored.active .session {
- background: linear-gradient(
- 110deg,
- color-mix(in srgb, var(--session-color) 34%, var(--secondary)),
- color-mix(in srgb, var(--session-color) 20%, var(--secondary))
- );
+ background: color-mix(in srgb, var(--session-color) 27%, var(--secondary));
}
.list-row.chat-row.colored {
- background: linear-gradient(
- 110deg,
- color-mix(in srgb, var(--session-color) 20%, transparent),
- color-mix(in srgb, var(--session-color) 8%, transparent)
- );
+ background: color-mix(in srgb, var(--session-color) 14%, transparent);
}
.list-row.chat-row.colored:hover {
- background: linear-gradient(
- 110deg,
- color-mix(in srgb, var(--session-color) 28%, transparent),
- color-mix(in srgb, var(--session-color) 14%, transparent)
- );
+ background: color-mix(in srgb, var(--session-color) 21%, transparent);
}
.session-menu-colors {
diff --git a/plugins/web-ui/test/css-vars.test.ts b/plugins/web-ui/test/css-vars.test.ts
index 9c9ab435d..be87db656 100644
--- a/plugins/web-ui/test/css-vars.test.ts
+++ b/plugins/web-ui/test/css-vars.test.ts
@@ -35,22 +35,57 @@ test("colored session actions keep their row hue at rest and on hover", () => {
);
});
-test("conversation colors use the refined spectrum palette on every list surface", () => {
+test("conversation colors use solid fills from the refined spectrum palette on every list surface", () => {
assert.match(tsSource, /const SESSION_COLORS = \["#f43f5e", "#f59e0b", "#10b981", "#3b82f6", "#8b5cf6", "#ec4899"\]/);
assert.equal(tsSource.match(/const color = displaySessionColor\(s\.color\);/g)?.length, 2);
assert.match(tsSource, /const current = displaySessionColor\(s\.color\);/);
assert.doesNotMatch(tsSource, /#d2664d|#b98a52|#7d884f|#5f8b83|#527d99|#8b5d52/);
assert.match(shellCss, /conic-gradient\(#f43f5e, #f59e0b, #10b981, #3b82f6, #8b5cf6, #ec4899, #f43f5e\)/);
- assert.match(shellCss, /\.session-row\.colored \.session \{[\s\S]*?linear-gradient\(/);
+ for (const rule of [
+ shellCss.match(/\.session-row\.colored \.session \{[^}]+\}/)?.[0] ?? "",
+ shellCss.match(
+ /\.session-row\.colored \.session:hover,\s*\.session-row\.colored\.menu-open \.session \{[^}]+\}/,
+ )?.[0] ?? "",
+ shellCss.match(/\.session-row\.colored\.active \.session \{[^}]+\}/)?.[0] ?? "",
+ shellCss.match(/\.list-row\.chat-row\.colored \{[^}]+\}/)?.[0] ?? "",
+ shellCss.match(/\.list-row\.chat-row\.colored:hover \{[^}]+\}/)?.[0] ?? "",
+ ]) {
+ assert.match(rule, /background:\s*color-mix\(/);
+ assert.doesNotMatch(rule, /gradient\(/);
+ }
assert.doesNotMatch(shellCss, /\.session-row\.colored \.session::before/);
});
-test("pinned conversations use the same header and child alignment as project conversations", () => {
+test("painted sidebar backgrounds align without moving conversation text", () => {
+ const extended =
+ shellCss.match(
+ /\.session-row:is\(\.colored, \.active, \.menu-open, \.selected, \.read-only, :hover\) \.session \{[^}]+\}/,
+ )?.[0] ?? "";
+ assert.match(extended, /width:\s*calc\(100% \+ 4px\);/);
+ assert.match(extended, /margin-left:\s*-4px;/);
+ assert.match(extended, /padding-left:\s*15px;/);
+ const nested =
+ shellCss.match(
+ /\.recent-project-children \.session-row:is\(\.colored, \.active, \.menu-open, \.selected, \.read-only, :hover\) \.session,[\s\S]*?\{[^}]+\}/,
+ )?.[0] ?? "";
+ assert.match(
+ nested,
+ /\.archived-children \.session-row:is\(\.colored, \.active, \.menu-open, \.selected, \.read-only, :hover\) \.session,/,
+ );
+ assert.match(
+ nested,
+ /\.pinned-children \.session-row:is\(\.colored, \.active, \.menu-open, \.selected, \.read-only, :hover\) \.session \{/,
+ );
+ assert.match(nested, /padding-left:\s*10px;/);
+});
+
+test("pinned conversations align with project conversations without a header-to-child gap", () => {
assert.match(tsSource, /class="pinned-head-glyph"/);
assert.match(tsSource, /class="pinned-children"/);
+ assert.match(shellCss, /\.recent-project \{[\s\S]*?margin:\s*3px 0 5px 4px;/);
const header = shellCss.match(/\.recents-group\.pinned-head \{[^}]+\}/)?.[0] ?? "";
assert.match(header, /min-height:\s*30px;/);
- assert.match(header, /margin:\s*3px 0 5px 4px;/);
+ assert.match(header, /margin:\s*3px 0 0 4px;/);
assert.match(header, /padding:\s*4px 3px 4px 2px;/);
assert.match(header, /font-size:\s*12\.5px;/);
assert.match(shellCss, /\.pinned-head-glyph \{[\s\S]*?flex: 0 0 14px;/);