Skip to content

armgit / qm

Public Imported from GitHub
0

Multiplayer agent harness for work.

Pad the inbox assistant panel and let people hide it (#2555)

Regan Belle28af006aaff
diff --git a/plugins/web-ui/src/inbox.ts b/plugins/web-ui/src/inbox.ts
index c90394be3..59e567fbe 100644
--- a/plugins/web-ui/src/inbox.ts
+++ b/plugins/web-ui/src/inbox.ts
@@ -25,6 +25,8 @@ import {
ChevronRight,
Inbox as InboxGlyph,
MoreHorizontal,
+ PanelRightClose,
+ PanelRightOpen,
Plus,
RefreshCw,
Undo2,
@@ -1750,6 +1752,37 @@ function syncLoops(viewId: string) {
);
}
+const ASSISTANT_HIDDEN_KEY = "web-ui:inbox-assistant-hidden";
+let assistantHidden = ((): boolean => {
+ try {
+ return localStorage.getItem(ASSISTANT_HIDDEN_KEY) === "1";
+ } catch {
+ return false;
+ }
+})();
+
+function assistantToggleTpl(): TemplateResult {
+ const label = assistantHidden ? "Show assistant" : "Hide assistant";
+ return html`<button
+ class="icon-btn compact subtle inbox-assistant-toggle"
+ type="button"
+ aria-label=${label}
+ aria-expanded=${String(!assistantHidden)}
+ ${tip(label)}
+ @click=${() => {
+ assistantHidden = !assistantHidden;
+ try {
+ localStorage.setItem(ASSISTANT_HIDDEN_KEY, assistantHidden ? "1" : "0");
+ } catch {
+ void 0;
+ }
+ drawAll();
+ }}
+ >
+ ${icon(assistantHidden ? PanelRightOpen : PanelRightClose, 17)}
+ </button>`;
+}
+
function syncLineTpl(surface: InboxSurface): TemplateResult | typeof nothing {
if (surface.viewId === "sent") {
const busy = isSentMailLoading();
@@ -2082,7 +2115,7 @@ function itemPageTpl(item: InboxItem): TemplateResult {
</h1>
${sub ? html`<div class="pane-subtitle">${sub}</div>` : nothing}
</div>
- ${triageControlsTpl(item)} ${dismissItemTpl(item)}
+ ${triageControlsTpl(item)} ${dismissItemTpl(item)} ${item.detailLoaded ? assistantToggleTpl() : nothing}
</div>
<div class="inbox-surface inbox-item-surface">
<div class="inbox-scroll inbox-item-thread">
@@ -2090,7 +2123,11 @@ function itemPageTpl(item: InboxItem): TemplateResult {
${detail}
</div>
</div>
- ${item.detailLoaded ? html`<aside class="inbox-item-aside" aria-label="Conversation assistant">${chatTpl(item)}</aside>` : nothing}
+ ${
+ item.detailLoaded && !assistantHidden
+ ? html`<aside class="inbox-item-aside" aria-label="Conversation assistant">${chatTpl(item)}</aside>`
+ : nothing
+ }
`;
}
@@ -2175,7 +2212,7 @@ function drawFull(): void {
}
syncInboxUrl(openSentEmail?.id ?? fullSurface.selectedId);
const host = fullSurface.host;
- host.classList.toggle("inbox-thread-page", Boolean(openItem?.detailLoaded));
+ host.classList.toggle("inbox-thread-page", Boolean(openItem?.detailLoaded) && !assistantHidden);
const surface = fullSurface;
let page: TemplateResult | typeof nothing;
if (openItem) page = itemPageTpl(openItem);
@@ -2192,16 +2229,24 @@ function drawFull(): void {
<div class="inbox-index-feed">
<div class="pane-head">
<h1 class="pane-title">Inbox</h1>
- <div class="pane-head-actions">${syncLineTpl(surface)}</div>
+ <div class="pane-head-actions">${syncLineTpl(surface)} ${assistantToggleTpl()}</div>
</div>
${surfaceTpl(surface)}
</div>
- ${inboxChat({
- kind: "inbox",
- hasEmail: inboxState.selected.some((loop) => loop.sources?.includes("gmail") || loop.source === "gmail"),
- hasSlack: inboxState.selected.some((loop) => loop.sources?.includes("slack") || loop.source === "slack"),
- hasDrafts: inboxState.items.some((item) => Boolean(item.draft) && item.status === "open"),
- })}
+ ${
+ assistantHidden
+ ? nothing
+ : inboxChat({
+ kind: "inbox",
+ hasEmail: inboxState.selected.some(
+ (loop) => loop.sources?.includes("gmail") || loop.source === "gmail",
+ ),
+ hasSlack: inboxState.selected.some(
+ (loop) => loop.sources?.includes("slack") || loop.source === "slack",
+ ),
+ hasDrafts: inboxState.items.some((item) => Boolean(item.draft) && item.status === "open"),
+ })
+ }
</div>
`;
keepingChatLogsPinned(host, () => render(page, host));
diff --git a/plugins/web-ui/src/shell.css b/plugins/web-ui/src/shell.css
index 4943ac15b..7dd2aa83b 100644
--- a/plugins/web-ui/src/shell.css
+++ b/plugins/web-ui/src/shell.css
@@ -8267,7 +8267,7 @@ h3.ambient-field-label {
}
.inbox-index-layout {
display: grid;
- grid-template-columns: minmax(0, 1fr) minmax(300px, var(--content-aside-width));
+ grid-template-columns: minmax(0, 1fr);
gap: var(--content-gap);
width: min(var(--content-wide-width), 100%);
margin: 0 auto;
@@ -8280,11 +8280,7 @@ h3.ambient-field-label {
.inbox-index-chat {
display: flex;
min-width: 0;
- min-height: 480px;
- height: calc(100dvh - 68px);
- position: sticky;
- top: 0;
- align-self: start;
+ height: 520px;
}
.inbox-index-conversation {
display: flex;
@@ -8337,15 +8333,6 @@ h3.ambient-field-label {
gap: 0;
margin: 0;
}
-@media (max-width: 1099px) {
- .inbox-index-layout {
- grid-template-columns: minmax(0, 1fr);
- }
- .inbox-index-chat {
- position: static;
- height: 520px;
- }
-}
.inbox-page .inbox-toolbar {
padding: 0;
}
@@ -9017,7 +9004,8 @@ h3.ambient-field-label {
padding-right: 0;
scrollbar-gutter: auto;
}
- .inbox-index-layout {
+ .inbox-index-layout:has(> .inbox-index-chat) {
+ grid-template-columns: minmax(0, 1fr) minmax(300px, var(--content-aside-width));
width: 100%;
}
.inbox-thread-page > .pane-head,
@@ -9036,18 +9024,17 @@ h3.ambient-field-label {
}
.inbox-item-aside {
grid-area: 1 / 2 / span 2;
- position: sticky;
- align-self: start;
width: 100%;
}
.inbox-index-chat,
.inbox-item-aside {
+ position: sticky;
top: -28px;
+ align-self: start;
box-sizing: border-box;
- min-height: 0;
height: 100dvh;
margin: -28px 0 -40px;
- padding: 0;
+ padding: 28px 0 0;
border-left: 1px solid var(--border);
}
.inbox-item-aside > .inbox-chat {
diff --git a/plugins/web-ui/test/inbox-index-chat.test.ts b/plugins/web-ui/test/inbox-index-chat.test.ts
index 985c350ac..319c615ce 100644
--- a/plugins/web-ui/test/inbox-index-chat.test.ts
+++ b/plugins/web-ui/test/inbox-index-chat.test.ts
@@ -150,3 +150,31 @@ test("shared sidebar prompts follow thread state and whole inbox context", async
await close();
}
});
+
+test("inbox assistant panel hides, reopens, and remembers the choice", async () => {
+ const { dom, vite, host, close } = await createInboxFixture();
+ try {
+ globalThis.fetch = async (url) =>
+ Response.json(String(url).includes("runtime-config") ? inboxRuntime : { items: [], selected: [], available: [] });
+ await vite.ssrLoadModule("/src/shell.ts");
+ const { appState } = await vite.ssrLoadModule("/src/shell-state.ts");
+ appState.me = { user: "[email protected]", permissions: ["inbox"] };
+ appState.currentView = "inbox";
+ appState.mainEl = host;
+ const { drawAll } = await vite.ssrLoadModule("/src/inbox.ts");
+ drawAll();
+ const toggle = () => host.querySelector<HTMLButtonElement>(".inbox-assistant-toggle")!;
+ assert.ok(host.querySelector("qm-inbox-chat"));
+ assert.equal(toggle().getAttribute("aria-label"), "Hide assistant");
+ toggle().click();
+ assert.equal(host.querySelector("qm-inbox-chat"), null);
+ assert.equal(toggle().getAttribute("aria-label"), "Show assistant");
+ assert.equal(dom.window.localStorage.getItem("web-ui:inbox-assistant-hidden"), "1");
+ toggle().click();
+ assert.ok(host.querySelector("qm-inbox-chat"));
+ assert.equal(dom.window.localStorage.getItem("web-ui:inbox-assistant-hidden"), "0");
+ } finally {
+ host.replaceChildren();
+ await close();
+ }
+});