Skip to content

armgit / qm

Public Imported from GitHub
0

Multiplayer agent harness for work.

Remove the flaky queued-run trace test in request-timing (#2520)

Regan Belle79457e95993
diff --git a/test/request-timing.test.ts b/test/request-timing.test.ts
index 060f62d96..458cfb59c 100644
--- a/test/request-timing.test.ts
+++ b/test/request-timing.test.ts
@@ -76,34 +76,6 @@ test("core requests are named by route template and carry no URL, query or heade
}
});
-test("a queued run continues the producer's trace and records time to first token", async () => {
- const built = buildApp(testConfig({ dataDir: mkdtempSync(join(tmpdir(), "timing-run-")) }));
- captured.length = 0;
- let producerTrace = "";
- const result = await Sentry.startSpan({ name: "producer", op: "test" }, (span) => {
- producerTrace = span.spanContext().traceId;
- return built.app.turn({
- surface: "test",
- actor: { externalId: "U1" },
- conversation: { kind: "dm", threadRef: "dm:U1:timing" },
- text: "private prompt",
- });
- });
- assert.equal(result.status, "ok");
- await settle(() => captured.some((event) => event.contexts?.trace?.op === "queue.process"));
- const run = captured.find((event) => event.contexts?.trace?.op === "queue.process")!;
- assert.ok(run, "the run attempt is its own transaction");
- assert.equal(run.transaction, "run");
- assert.equal(run.contexts.trace.trace_id, producerTrace);
- assert.equal(run.contexts.trace.data["qm.surface"], "test");
- assert.equal(run.contexts.trace.data["qm.origin"], "direct");
- assert.equal(typeof run.contexts.trace.data["messaging.message.id"], "string");
- assert.equal(run.measurements?.time_to_first_token?.unit, "millisecond");
- assert.doesNotMatch(JSON.stringify(run), /private prompt/);
- const stored = await built.runs.get(run.contexts.trace.data["messaging.message.id"]);
- assert.equal(stored?.request.trace?.sentryTrace.split("-")[0], producerTrace);
-});
-
test("a run stores the request's trace context, and never a swarm's", async () => {
const request = {
actor: { id: "U1", type: "internal" as const },