Skip to content

armgit / qm

Public Imported from GitHub
0

Multiplayer agent harness for work.

memory: coerce miscalled remember calls into facts (#394)

Regan Bellf8728a190652
diff --git a/src/harness/pi-tools.ts b/src/harness/pi-tools.ts
index 0e5988994..5a6094809 100644
--- a/src/harness/pi-tools.ts
+++ b/src/harness/pi-tools.ts
@@ -121,6 +121,44 @@ function capText(t: string): string {
return t.length > MAX_TOOL_RESULT_CHARS ? `${t.slice(0, MAX_TOOL_RESULT_CHARS)}…[truncated]` : t;
}
+function contentFactLines(content: string): string[] {
+ return content
+ .split(/\r?\n/)
+ .map((line) =>
+ line
+ .trim()
+ .replace(/^[-*]\s+/, "")
+ .trim(),
+ )
+ .filter(Boolean);
+}
+
+function passedRememberFields(params: { facts?: unknown; content?: unknown; query?: unknown }): string {
+ const fields = ["facts", "content", "query"].filter((field) => params[field as keyof typeof params] !== undefined);
+ return fields.length ? fields.join(", ") : "none";
+}
+
+function rememberFacts(params: { facts?: unknown; content?: unknown; query?: unknown }): {
+ facts: string[];
+ coercedFrom?: "facts" | "content" | "query";
+} {
+ if (typeof params.facts === "string") {
+ const fact = params.facts.trim();
+ if (fact) return { facts: [fact], coercedFrom: "facts" };
+ }
+ const facts = Array.isArray(params.facts) ? params.facts.map((fact) => String(fact).trim()).filter(Boolean) : [];
+ if (facts.length) return { facts };
+ if (typeof params.content === "string") {
+ const contentFacts = contentFactLines(params.content);
+ if (contentFacts.length) return { facts: contentFacts, coercedFrom: "content" };
+ }
+ if (typeof params.query === "string") {
+ const fact = params.query.trim();
+ if (fact) return { facts: [fact], coercedFrom: "query" };
+ }
+ return { facts: [] };
+}
+
function fmtStatus(s: { state: "running" } | { state: "exited"; code: number }): string {
return s.state === "exited" ? `exited ${s.code}` : "running";
}
@@ -892,7 +930,7 @@ export function createPiTools(ref: ToolContextRef, opts?: PiToolsOptions): ToolD
...(params.query !== undefined ? { query: params.query } : {}),
...(params.limit !== undefined ? { limit: params.limit } : {}),
...(params.facts !== undefined ? { facts: params.facts } : {}),
- ...(params.content !== undefined ? { chars: params.content.length } : {}),
+ ...(typeof params.content === "string" ? { chars: params.content.length } : {}),
});
const unavailable = () =>
recordResult(
@@ -937,19 +975,24 @@ export function createPiTools(ref: ToolContextRef, opts?: PiToolsOptions): ToolD
);
}
case "remember": {
- const facts = (params.facts ?? []).map((f) => f.trim()).filter(Boolean);
+ const resolved = rememberFacts(params);
+ const { facts } = resolved;
if (!facts.length)
return recordResult(
callId,
{ tool: "memory", action, error: "facts required" },
- text("[error] memory remember requires `facts` (a non-empty list)."),
+ text(
+ `[error] memory remember requires \`facts\` (a non-empty list). Received: ${passedRememberFields(
+ params,
+ )} (use facts instead).`,
+ ),
true,
);
const added = await tc.memoryRemember(facts);
if (added === null) return unavailable();
return recordResult(
callId,
- { tool: "memory", action, added },
+ { tool: "memory", action, added, ...(resolved.coercedFrom ? { coercedFrom: resolved.coercedFrom } : {}) },
text(
added
? `Remembered ${added} fact${added === 1 ? "" : "s"}.`
diff --git a/test/pi-tools.test.ts b/test/pi-tools.test.ts
index a3fca52ad..a26ea3d54 100644
--- a/test/pi-tools.test.ts
+++ b/test/pi-tools.test.ts
@@ -1104,6 +1104,134 @@ test("tool entries carry the call id + faithful model-facing result (WAL replay
assert.match(result("call-exec").result, /\[exit 0\]/);
});
+test("memory remember accepts facts as a single string and records coercion", async () => {
+ const emitted: Emitted[] = [];
+ const remembered: string[][] = [];
+ const ref: ToolContextRef = {
+ current: {
+ ...fakeToolContext(),
+ async memoryRemember(facts) {
+ remembered.push(facts);
+ return facts.length;
+ },
+ },
+ emit: (e) => {
+ emitted.push(e as Emitted);
+ },
+ scopeLabel: "personal:U1",
+ };
+ const memory = createPiTools(ref).find((tool) => tool.name === "memory");
+
+ await call(memory, { action: "remember", facts: "Owns billing." });
+
+ assert.deepEqual(remembered, [["Owns billing."]]);
+ const result = emitted.find((e) => e.type === "tool_result" && e.payload.tool === "memory")!.payload;
+ assert.equal(result.coercedFrom, "facts");
+ assert.equal(result.added, 1);
+});
+
+test("memory remember falls back to content lines with bullets", async () => {
+ const emitted: Emitted[] = [];
+ const remembered: string[][] = [];
+ const ref: ToolContextRef = {
+ current: {
+ ...fakeToolContext(),
+ async memoryRemember(facts) {
+ remembered.push(facts);
+ return facts.length;
+ },
+ },
+ emit: (e) => {
+ emitted.push(e as Emitted);
+ },
+ scopeLabel: "personal:U1",
+ };
+ const memory = createPiTools(ref).find((tool) => tool.name === "memory");
+
+ await call(memory, { action: "remember", facts: [], content: "\n- Owns billing.\n- Likes short updates.\n\n" });
+
+ assert.deepEqual(remembered, [["Owns billing.", "Likes short updates."]]);
+ const result = emitted.find((e) => e.type === "tool_result" && e.payload.tool === "memory")!.payload;
+ assert.equal(result.coercedFrom, "content");
+ assert.equal(result.added, 2);
+});
+
+test("memory remember falls back to query when facts and content are empty", async () => {
+ const emitted: Emitted[] = [];
+ const remembered: string[][] = [];
+ const ref: ToolContextRef = {
+ current: {
+ ...fakeToolContext(),
+ async memoryRemember(facts) {
+ remembered.push(facts);
+ return facts.length;
+ },
+ },
+ emit: (e) => {
+ emitted.push(e as Emitted);
+ },
+ scopeLabel: "personal:U1",
+ };
+ const memory = createPiTools(ref).find((tool) => tool.name === "memory");
+
+ await call(memory, { action: "remember", facts: [], content: " ", query: "Prefers email summaries." });
+
+ assert.deepEqual(remembered, [["Prefers email summaries."]]);
+ const result = emitted.find((e) => e.type === "tool_result" && e.payload.tool === "memory")!.payload;
+ assert.equal(result.coercedFrom, "query");
+ assert.equal(result.added, 1);
+});
+
+test("memory remember keeps normal facts arrays unchanged", async () => {
+ const emitted: Emitted[] = [];
+ const remembered: string[][] = [];
+ const ref: ToolContextRef = {
+ current: {
+ ...fakeToolContext(),
+ async memoryRemember(facts) {
+ remembered.push(facts);
+ return facts.length;
+ },
+ },
+ emit: (e) => {
+ emitted.push(e as Emitted);
+ },
+ scopeLabel: "personal:U1",
+ };
+ const memory = createPiTools(ref).find((tool) => tool.name === "memory");
+
+ await call(memory, { action: "remember", facts: ["Owns billing.", "Likes short updates."] });
+
+ assert.deepEqual(remembered, [["Owns billing.", "Likes short updates."]]);
+ const result = emitted.find((e) => e.type === "tool_result" && e.payload.tool === "memory")!.payload;
+ assert.equal(result.coercedFrom, undefined);
+ assert.equal(result.added, 2);
+});
+
+test("memory remember all-empty error names the supplied fields", async () => {
+ const emitted: Emitted[] = [];
+ const ref: ToolContextRef = {
+ current: fakeToolContext(),
+ emit: (e) => {
+ emitted.push(e as Emitted);
+ },
+ scopeLabel: "personal:U1",
+ };
+ const memory = createPiTools(ref).find((tool) => tool.name === "memory");
+
+ const ret = (await call(memory, { action: "remember", facts: [], content: "", query: "" })) as {
+ content: Array<{ text: string }>;
+ };
+
+ assert.equal(
+ ret.content[0]!.text,
+ "[error] memory remember requires `facts` (a non-empty list). Received: facts, content, query (use facts instead).",
+ );
+ const result = emitted.find((e) => e.type === "tool_result" && e.payload.tool === "memory")!.payload;
+ assert.equal(result.isError, true);
+ assert.equal(result.error, "facts required");
+});
+
test("not-found read and denied command record isError + the faithful error text", async () => {
const emitted: Emitted[] = [];
const denyTC: ToolContext = {