Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix: data source return two error once it occured (#18535)

Haruko38600ebe05dc5fc
diff --git a/web/src/pages/user-setting/data-source/hooks.test.ts b/web/src/pages/user-setting/data-source/hooks.test.ts
new file mode 100644
index 0000000000..740ef7d21c
--- /dev/null
+++ b/web/src/pages/user-setting/data-source/hooks.test.ts
@@ -0,0 +1,111 @@
+import { act, renderHook } from '@testing-library/react';
+
+jest.mock('react-router', () => ({
+ useParams: jest.fn(() => ({})),
+ useSearchParams: jest.fn(() => [new URLSearchParams(''), () => {}]),
+}));
+
+jest.mock('@/components/ui/message', () => ({
+ __esModule: true,
+ default: { success: jest.fn(), error: jest.fn() },
+}));
+
+jest.mock('@/services/data-source-service', () => ({
+ __esModule: true,
+ default: {
+ dataSourceList: jest.fn(),
+ dataSourceUpdate: jest.fn(),
+ },
+ dataSourceRebuild: jest.fn(),
+ dataSourceUpdate: jest.fn(),
+ deleteDataSource: jest.fn(),
+ featchDataSourceDetail: jest.fn(),
+ getDataSourceLogs: jest.fn(),
+ testDataSource: jest.fn(),
+}));
+
+jest.mock('i18next', () => ({
+ t: jest.fn((key: string) => key),
+}));
+
+jest.mock('@tanstack/react-query', () => ({
+ useQuery: jest.fn(),
+ useQueryClient: jest.fn(() => ({})),
+}));
+
+jest.mock('@/hooks/logic-hooks', () => ({
+ useGetPaginationWithRouter: jest.fn(),
+}));
+
+jest.mock('@/hooks/common-hooks', () => ({
+ useSetModalState: jest.fn(),
+}));
+
+jest.mock('./constant', () => ({
+ DataSourceKey: {},
+ useDataSourceInfo: jest.fn(() => ({})),
+}));
+
+import { testDataSource } from '@/services/data-source-service';
+import { useTestDataSource } from './hooks';
+
+const mockTest = jest.mocked(testDataSource);
+
+const baseFields = [
+ { name: 'id', label: 'Id', type: 'text', hidden: true },
+ { name: 'name', label: 'Name', type: 'text', required: true },
+ { name: 'source', label: 'Source', type: 'text', required: true },
+];
+
+describe('useTestDataSource', () => {
+ beforeEach(() => {
+ jest.clearAllMocks();
+ });
+
+ it('does not run Test Connection when the required name field is empty', async () => {
+ const formRef = {
+ current: {
+ getFilteredValues: () => ({ id: '1', name: '', source: 'mysql' }),
+ trigger: jest.fn().mockResolvedValue(false),
+ },
+ };
+ const { result } = renderHook(() =>
+ useTestDataSource(formRef as never, undefined, baseFields as never),
+ );
+
+ await act(async () => {
+ await result.current.handleTest();
+ });
+
+ expect(formRef.current.trigger).toHaveBeenCalledWith(
+ expect.arrayContaining(['name']),
+ );
+ expect(mockTest).not.toHaveBeenCalled();
+ });
+
+ it('runs Test Connection when the required fields are valid', async () => {
+ mockTest.mockResolvedValue({ data: { code: 0 } } as never);
+ const formRef = {
+ current: {
+ getFilteredValues: () => ({ id: '1', name: 'conn', source: 'mysql' }),
+ trigger: jest.fn().mockResolvedValue(true),
+ },
+ };
+ const { result } = renderHook(() =>
+ useTestDataSource(formRef as never, undefined, baseFields as never),
+ );
+
+ await act(async () => {
+ await result.current.handleTest();
+ });
+
+ expect(formRef.current.trigger).toHaveBeenCalledWith(
+ expect.arrayContaining(['name']),
+ );
+ expect(mockTest).toHaveBeenCalledWith('1', {
+ source: 'mysql',
+ config: {},
+ });
+ });
+
+});
diff --git a/web/src/pages/user-setting/data-source/hooks.ts b/web/src/pages/user-setting/data-source/hooks.ts
index 206400f80f..1d9e8b72fb 100644
--- a/web/src/pages/user-setting/data-source/hooks.ts
+++ b/web/src/pages/user-setting/data-source/hooks.ts
@@ -329,11 +329,9 @@ export const useTestDataSource = (
});
if (data.code === 0) {
message.success(t('setting.dataSourceTestSuccess'));
- } else {
- message.error(data.message || t('setting.dataSourceTestFailed'));
}
} catch {
- message.error(t('setting.dataSourceTestFailed'));
+ // The request interceptor owns error notifications for failed requests.
} finally {
setLoading(false);
}