Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

Fix: allow use - in instance_name (#19709)

Lynn079284c1fae3
diff --git a/internal/handler/providers.go b/internal/handler/providers.go
index ea5cea02e0..d645357e08 100644
--- a/internal/handler/providers.go
+++ b/internal/handler/providers.go
@@ -352,18 +352,18 @@ type CreateProviderInstanceRequest struct {
ModelInfo []service.CreateInstanceModelInfo `json:"model_info"`
}
-// instanceNamePattern restricts an instance name to digits, underscores, and
-// ASCII letters in both cases.
-var instanceNamePattern = regexp.MustCompile(`^[0-9A-Za-z_]+$`)
+// instanceNamePattern restricts an instance name to digits, underscores,
+// hyphens, and ASCII letters in both cases.
+var instanceNamePattern = regexp.MustCompile(`^[0-9A-Za-z_-]+$`)
// validateInstanceName rejects an empty instance name or one carrying any
-// character outside digits, underscores, and ASCII letters.
+// character outside digits, underscores, hyphens, and ASCII letters.
func validateInstanceName(instanceName string) error {
if instanceName == "" {
return errors.New("instance name is required")
}
if !instanceNamePattern.MatchString(instanceName) {
- return errors.New("instance name may only contain digits, underscores, and letters")
+ return errors.New("instance name may only contain digits, underscores, hyphens, and letters")
}
return nil
}
diff --git a/internal/handler/providers_test.go b/internal/handler/providers_test.go
index 6cb9e189af..96ef838932 100644
--- a/internal/handler/providers_test.go
+++ b/internal/handler/providers_test.go
@@ -119,9 +119,10 @@ func TestValidateInstanceName(t *testing.T) {
{name: "my_instance", valid: true},
{name: "Instance123", valid: true},
{name: "_123", valid: true},
+ {name: "my-instance", valid: true},
+ {name: "-my-instance-1", valid: true},
{name: "", valid: false},
{name: "my instance", valid: false},
- {name: "my-instance", valid: false},
{name: "实例", valid: false},
{name: "instância", valid: false},
{name: "instance!", valid: false},