RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
Fix: add system_settings seeder (#21955)
Lynn13a1974b9c5f
diff --git a/internal/dao/database.go b/internal/dao/database.goindex 27b21cc32d..b8099355fc 100644--- a/internal/dao/database.go+++ b/internal/dao/database.go@@ -460,8 +460,8 @@ func InitDB(ctx context.Context, migrateDB bool) error {return fmt.Errorf("failed to auto-migrate runtime models: %w", err)}}- if err = initializeSystemSettingsEE(ctx, DB); err != nil {- return fmt.Errorf("failed to initialize enterprise system settings: %w", err)+ if err = SeedSystemSettings(ctx, DB); err != nil {+ return fmt.Errorf("failed to seed system settings: %w", err)}// Conversation lists filter by dialog and usually order by update time.for _, table := range []string{"conversation", "api_4_conversation"} {diff --git a/internal/dao/stub.go b/internal/dao/stub.goindex 62334b815c..0c78b05e91 100644--- a/internal/dao/stub.go+++ b/internal/dao/stub.go@@ -39,9 +39,6 @@ func billingDataModelsEE() []interface{} { return nil }// migrateBillingSchemaEE is a no-op in the community edition.func migrateBillingSchemaEE(ctx context.Context, db *gorm.DB) error { return nil }-// initializeSystemSettingsEE is a no-op in the community edition.-func initializeSystemSettingsEE(ctx context.Context, db *gorm.DB) error { return nil }-// migratePermissionDataEE is a no-op in the community edition.func migratePermissionDataEE(ctx context.Context, db *gorm.DB) error { return nil }diff --git a/internal/dao/system_settings_seed.go b/internal/dao/system_settings_seed.gonew file mode 100644index 0000000000..507f7dc4f6--- /dev/null+++ b/internal/dao/system_settings_seed.go@@ -0,0 +1,132 @@+//+// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+// http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+//++package dao++import (+ "context"+ "encoding/json"+ "fmt"+ "os"+ "path/filepath"++ "ragflow/internal/common"+ "ragflow/internal/entity"++ "go.uber.org/zap"+ "gorm.io/gorm"+)++// systemSettingSeed mirrors one entry of conf/system_settings.json.+type systemSettingSeed struct {+ Name string `json:"name"`+ Source string `json:"source"`+ DataType string `json:"data_type"`+ Value string `json:"value"`+}++type systemSettingsSeedFile struct {+ SystemSettings []systemSettingSeed `json:"system_settings"`+}++// SeedSystemSettings seeds the system_settings table from+// conf/system_settings.json. Rows whose name already exists are left+// untouched so operator edits and enterprise settings survive restarts;+// only missing entries are inserted.+func SeedSystemSettings(ctx context.Context, db *gorm.DB) error {+ path := findSystemSettingsSeedFile()+ if path == "" {+ common.Warn("conf/system_settings.json not found, skipping system settings seeding")+ return nil+ }+ seeds, err := loadSystemSettingsSeedFile(path)+ if err != nil {+ common.Warn("Failed to load system settings seed file", zap.String("file", path), zap.Error(err))+ return nil+ }+ return insertMissingSystemSettings(ctx, db, seeds)+}++func findSystemSettingsSeedFile() string {+ candidates := []string{+ "conf/system_settings.json",+ filepath.Join("..", "conf", "system_settings.json"),+ filepath.Join("..", "..", "conf", "system_settings.json"),+ filepath.Join("..", "..", "..", "conf", "system_settings.json"),+ }+ for _, candidate := range candidates {+ if info, err := os.Stat(candidate); err == nil && !info.IsDir() {+ return candidate+ }+ }+ return ""+}++func loadSystemSettingsSeedFile(path string) ([]entity.SystemSettings, error) {+ raw, err := os.ReadFile(path)+ if err != nil {+ return nil, fmt.Errorf("read %s: %w", path, err)+ }+ var file systemSettingsSeedFile+ if err := json.Unmarshal(raw, &file); err != nil {+ return nil, fmt.Errorf("parse %s: %w", path, err)+ }+ settings := make([]entity.SystemSettings, 0, len(file.SystemSettings))+ for _, seed := range file.SystemSettings {+ if seed.Name == "" {+ continue+ }+ if seed.DataType == "" {+ seed.DataType = entity.InferSystemSettingDataType(seed.Name)+ }+ settings = append(settings, entity.SystemSettings{+ Name: seed.Name,+ Source: seed.Source,+ DataType: seed.DataType,+ Value: seed.Value,+ })+ }+ return settings, nil+}++func insertMissingSystemSettings(ctx context.Context, db *gorm.DB, seeds []entity.SystemSettings) error {+ if len(seeds) == 0 {+ return nil+ }+ var existingNames []string+ if err := db.WithContext(ctx).Model(&entity.SystemSettings{}).Pluck("name", &existingNames).Error; err != nil {+ return fmt.Errorf("failed to list existing system settings: %w", err)+ }+ existing := make(map[string]struct{}, len(existingNames))+ for _, name := range existingNames {+ existing[name] = struct{}{}+ }+ toInsert := make([]entity.SystemSettings, 0, len(seeds))+ for _, seed := range seeds {+ if _, ok := existing[seed.Name]; ok {+ continue+ }+ toInsert = append(toInsert, seed)+ }+ if len(toInsert) == 0 {+ return nil+ }+ if err := db.WithContext(ctx).Create(&toInsert).Error; err != nil {+ return fmt.Errorf("failed to insert system settings: %w", err)+ }+ common.Info("Seeded system settings", zap.Int("count", len(toInsert)))+ return nil+}diff --git a/internal/dao/system_settings_seed_test.go b/internal/dao/system_settings_seed_test.gonew file mode 100644index 0000000000..ff8962a3ca--- /dev/null+++ b/internal/dao/system_settings_seed_test.go@@ -0,0 +1,108 @@+//+// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+// http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+//++package dao++import (+ "os"+ "path/filepath"+ "testing"++ "ragflow/internal/entity"++ "github.com/glebarez/sqlite"+ "gorm.io/gorm"+)++func TestSeedSystemSettingsInsertsMissingAndKeepsExisting(t *testing.T) {+ db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})+ if err != nil {+ t.Fatalf("open sqlite: %v", err)+ }+ if err = db.AutoMigrate(&entity.SystemSettings{}); err != nil {+ t.Fatalf("migrate system settings: %v", err)+ }++ body := `{"system_settings":[+ {"name":"enable_whitelist","source":"variable","data_type":"bool","value":"true"},+ {"name":"mail.timeout","source":"variable","data_type":"integer","value":"10"},+ {"name":"sandbox.provider_type","source":"variable","data_type":"string","value":"self_managed"},+ {"name":"","source":"variable","data_type":"string","value":""}+ ]}`+ path := filepath.Join(t.TempDir(), "system_settings.json")+ if err = os.WriteFile(path, []byte(body), 0o600); err != nil {+ t.Fatalf("write seed file: %v", err)+ }+ seeds, err := loadSystemSettingsSeedFile(path)+ if err != nil {+ t.Fatalf("load seed file: %v", err)+ }+ if len(seeds) != 3 {+ t.Fatalf("got %d seeds after dropping empty-name entries, want 3", len(seeds))+ }++ ctx := t.Context()+ if err = insertMissingSystemSettings(ctx, db, seeds); err != nil {+ t.Fatalf("seed system settings: %v", err)+ }+ // Idempotent: a second run must not duplicate rows.+ if err = insertMissingSystemSettings(ctx, db, seeds); err != nil {+ t.Fatalf("re-seed system settings: %v", err)+ }++ var count int64+ if err = db.Model(&entity.SystemSettings{}).Count(&count).Error; err != nil {+ t.Fatalf("count system settings: %v", err)+ }+ if count != 3 {+ t.Fatalf("got %d rows, want 3", count)+ }++ // An operator-edited row keeps its value on reseed.+ if err = db.Model(&entity.SystemSettings{}).+ Where("name = ?", "enable_whitelist").+ Update("value", "false").Error; err != nil {+ t.Fatalf("edit seeded row: %v", err)+ }+ if err = insertMissingSystemSettings(ctx, db, seeds); err != nil {+ t.Fatalf("re-seed after edit: %v", err)+ }+ var setting entity.SystemSettings+ if err = db.Where("name = ?", "enable_whitelist").Take(&setting).Error; err != nil {+ t.Fatalf("read seeded row: %v", err)+ }+ if setting.Value != "false" {+ t.Fatalf("existing row was overwritten: got value %q, want \"false\"", setting.Value)+ }+}++func TestLoadSystemSettingsSeedFileInfersMissingDataType(t *testing.T) {+ body := `{"system_settings":[{"name":"mail.port","value":""}]}`+ path := filepath.Join(t.TempDir(), "system_settings.json")+ if err := os.WriteFile(path, []byte(body), 0o600); err != nil {+ t.Fatalf("write seed file: %v", err)+ }+ seeds, err := loadSystemSettingsSeedFile(path)+ if err != nil {+ t.Fatalf("load seed file: %v", err)+ }+ if len(seeds) != 1 {+ t.Fatalf("got %d seeds, want 1", len(seeds))+ }+ if seeds[0].DataType != entity.InferSystemSettingDataType("mail.port") {+ t.Fatalf("data_type not inferred: got %q", seeds[0].DataType)+ }+}