Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(dataset): report incomplete bulk document deletion (#21607)

Sbaaoui Idriss18157ce5f77c
diff --git a/web/src/hooks/use-document-request.ts b/web/src/hooks/use-document-request.ts
index 0a1f727835..bc4c06ce17 100644
--- a/web/src/hooks/use-document-request.ts
+++ b/web/src/hooks/use-document-request.ts
@@ -590,10 +590,15 @@ export const useRemoveDocument = () => {
const ids = Array.isArray(documentIds) ? documentIds : [documentIds];
const { data } = await deleteDocument(datasetId!, ids);
if (data.code === 0) {
- message.success(i18n.t('message.deleted'));
queryClient.invalidateQueries({
queryKey: DocumentKeys.all(),
});
+ // The bulk count confirms completed cleanup, but cannot identify failed IDs.
+ if (Array.isArray(documentIds) && data.data?.deleted !== ids.length) {
+ message.warning(i18n.t('message.deleteIncomplete'));
+ return;
+ }
+ message.success(i18n.t('message.deleted'));
}
return data.code;
},
diff --git a/web/src/locales/en.ts b/web/src/locales/en.ts
index fc47115a06..009bf60f28 100644
--- a/web/src/locales/en.ts
+++ b/web/src/locales/en.ts
@@ -2622,6 +2622,8 @@ Example: Virtual Hosted Style`,
modified: 'Modified',
created: 'Created',
deleted: 'Deleted',
+ deleteIncomplete:
+ 'Could not confirm complete deletion. Check the remaining documents before retrying.',
noLangfuseConfigToDelete: 'No Langfuse configuration to delete',
renamed: 'Renamed',
operated: 'Operated',
diff --git a/web/src/locales/zh.ts b/web/src/locales/zh.ts
index c8780b5ea0..31d077a181 100644
--- a/web/src/locales/zh.ts
+++ b/web/src/locales/zh.ts
@@ -2198,6 +2198,7 @@ NER:使用 spaCy NER 和基于规则的关键词提取来抽取 Entities 和 R
modified: '更新成功',
created: '创建成功',
deleted: '删除成功',
+ deleteIncomplete: '无法确认删除已全部完成。请检查剩余文档后重试。',
noLangfuseConfigToDelete: '没有可删除的 Langfuse 配置',
renamed: '重命名成功',
operated: '操作成功',
diff --git a/web/src/pages/dataset/dataset/use-bulk-operate-dataset.tsx b/web/src/pages/dataset/dataset/use-bulk-operate-dataset.tsx
index 40527042a6..6ef556bcfa 100644
--- a/web/src/pages/dataset/dataset/use-bulk-operate-dataset.tsx
+++ b/web/src/pages/dataset/dataset/use-bulk-operate-dataset.tsx
@@ -10,6 +10,7 @@ import {
useSetDocumentStatus,
} from '@/hooks/use-document-request';
import { IDocumentInfo } from '@/interfaces/database/document';
+import { omit } from 'lodash';
import {
LucideCircleX,
LucideCylinder,
@@ -161,8 +162,19 @@ export function useBulkOperateDataset({
onChangeStatus(false);
}, [onChangeStatus]);
- const handleDelete = useCallback(() => {
- const deletedKeys = selectedRowKeys.filter(
+ const handleDelete = useCallback(async () => {
+ const currentKeys = selectedRowKeys.filter((id) =>
+ documents.some((doc) => doc.id === id),
+ );
+ setRowSelection((prev) =>
+ omit(
+ prev,
+ selectedRowKeys.filter((id) => !currentKeys.includes(id)),
+ ),
+ );
+ if (currentKeys.length === 0) return;
+
+ const deletedKeys = currentKeys.filter(
(x) => !documents.filter(isDocumentProcessing).some((y) => y.id === x),
);
if (deletedKeys.length === 0) {
@@ -172,8 +184,17 @@ export function useBulkOperateDataset({
return;
}
- return removeDocument(deletedKeys);
- }, [selectedRowKeys, removeDocument, documents, t]);
+ if (deletedKeys.length < currentKeys.length) {
+ toast.warning(
+ t('knowledgeConfiguration.theDocumentBeingParsedCannotBeDeleted'),
+ );
+ }
+
+ const code = await removeDocument(deletedKeys);
+ if (code === 0) {
+ setRowSelection((prev) => omit(prev, deletedKeys));
+ }
+ }, [selectedRowKeys, removeDocument, documents, t, setRowSelection]);
const list = [
{
@@ -210,12 +231,7 @@ export function useBulkOperateDataset({
id: 'delete',
label: t('common.delete'),
icon: <LucideTrash2 />,
- onClick: async () => {
- const code = await handleDelete();
- if (code === 0) {
- setRowSelection({});
- }
- },
+ onClick: handleDelete,
},
];