RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(chunk): enforce document scope on updates (#19221)
WOLIKIMCHENG1a99ebea3815
diff --git a/internal/service/chunk/chunk.go b/internal/service/chunk/chunk.goindex 9c60a5c26c..103aee9dc7 100644--- a/internal/service/chunk/chunk.go+++ b/internal/service/chunk/chunk.go@@ -1136,6 +1136,10 @@ func (s *ChunkService) UpdateChunk(ctx context.Context, req *service.UpdateChunkif !ok {return fmt.Errorf("invalid chunk format")}+ existingDocumentID, ok := existing["doc_id"].(string)+ if !ok || existingDocumentID != req.DocumentID {+ return fmt.Errorf("chunk not found")+ }// Build update dictd := make(map[string]interface{})@@ -1213,7 +1217,8 @@ func (s *ChunkService) UpdateChunk(ctx context.Context, req *service.UpdateChunk// Call updatecondition := map[string]interface{}{- "id": req.ChunkID,+ "id": req.ChunkID,+ "doc_id": req.DocumentID,}err = s.docEngine.UpdateChunks(ctx, condition, d, indexName, req.DatasetID)diff --git a/internal/service/chunk/chunk_test.go b/internal/service/chunk/chunk_test.goindex c96956ed39..880b5c25c9 100644--- a/internal/service/chunk/chunk_test.go+++ b/internal/service/chunk/chunk_test.go@@ -439,6 +439,83 @@ func TestListBuildsMatchTextExprForKeywords(t *testing.T) {}}+func TestUpdateChunkRejectsChunkFromAnotherDocument(t *testing.T) {+ db := setupChunkTestDB(t)+ pushChunkTestDB(t, db)++ insertChunkTestUserTenant(t, "user-1", "tenant-1")+ insertChunkTestKB(t, "kb-1", "tenant-1")+ insertChunkTestDoc(t, "doc-a", "kb-1")+ insertChunkTestDoc(t, "doc-b", "kb-1")++ engine := &updateChunkTestEngine{+ existingChunk: map[string]interface{}{"doc_id": "doc-b"},+ }+ svc := &ChunkService{+ docEngine: engine,+ kbDAO: dao.NewKnowledgebaseDAO(),+ userTenantDAO: dao.NewUserTenantDAO(),+ }++ err := svc.UpdateChunk(t.Context(), &service.UpdateChunkRequest{+ DatasetID: "kb-1",+ DocumentID: "doc-a",+ ChunkID: "chunk-1",+ }, "user-1")+ if err == nil {+ t.Fatal("expected UpdateChunk to reject a chunk from another document")+ }+ if !strings.Contains(err.Error(), "chunk not found") {+ t.Fatalf("UpdateChunk error = %q, want chunk not found", err)+ }+ if len(engine.updateCalls) != 0 {+ t.Fatalf("UpdateChunks calls = %d, want 0", len(engine.updateCalls))+ }+}++func TestUpdateChunkUpdatesSameDocumentWithDocumentCondition(t *testing.T) {+ db := setupChunkTestDB(t)+ pushChunkTestDB(t, db)++ insertChunkTestUserTenant(t, "user-1", "tenant-1")+ insertChunkTestKB(t, "kb-1", "tenant-1")+ insertChunkTestDoc(t, "doc-a", "kb-1")++ engine := &updateChunkTestEngine{+ existingChunk: map[string]interface{}{+ "doc_id": "doc-a",+ "content_with_weight": "existing content",+ },+ }+ svc := &ChunkService{+ docEngine: engine,+ kbDAO: dao.NewKnowledgebaseDAO(),+ userTenantDAO: dao.NewUserTenantDAO(),+ }++ err := svc.UpdateChunk(t.Context(), &service.UpdateChunkRequest{+ DatasetID: "kb-1",+ DocumentID: "doc-a",+ ChunkID: "chunk-1",+ }, "user-1")+ if err != nil {+ t.Fatalf("UpdateChunk() error = %v", err)+ }+ if len(engine.updateCalls) != 1 {+ t.Fatalf("UpdateChunks calls = %d, want 1", len(engine.updateCalls))+ }+ call := engine.updateCalls[0]+ if !reflect.DeepEqual(call.condition, map[string]interface{}{+ "id": "chunk-1",+ "doc_id": "doc-a",+ }) {+ t.Fatalf("UpdateChunks condition = %#v", call.condition)+ }+ if call.indexName != "ragflow_tenant-1" || call.datasetID != "kb-1" {+ t.Fatalf("UpdateChunks target index=%q dataset=%q", call.indexName, call.datasetID)+ }+}+func TestAddChunkSuccess(t *testing.T) {ctx := t.Context()db := setupChunkTestDB(t)@@ -1214,6 +1291,26 @@ func (e *listChunksSearchEngine) Search(_ context.Context, req *types.SearchRequ}, nil}+type updateChunkTestEngine struct {+ parseTestDocEngine+ existingChunk interface{}+ updateCalls []updateChunksCall+}++func (e *updateChunkTestEngine) GetChunk(context.Context, string, string, []string) (interface{}, error) {+ return e.existingChunk, nil+}++func (e *updateChunkTestEngine) UpdateChunks(_ context.Context, condition, newValue map[string]interface{}, indexName, datasetID string) error {+ e.updateCalls = append(e.updateCalls, updateChunksCall{+ condition: copyMap(condition),+ newValue: copyMap(newValue),+ indexName: indexName,+ datasetID: datasetID,+ })+ return nil+}+type chunkImageStorage struct {exists boololdBinary []byte