RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(agent): accept a string delimiter in StringTransform merge mode (#20331)
Eugene Kalinin251140a88341
diff --git a/internal/agent/component/string_transform.go b/internal/agent/component/string_transform.goindex 9564e80a7b..88dc181464 100644--- a/internal/agent/component/string_transform.go+++ b/internal/agent/component/string_transform.go@@ -72,6 +72,13 @@ func (p *stringTransformParam) Update(conf map[string]any) error {case []string:// already correct shapep.Delimiters = append(p.Delimiters[:0], v...)+ case string:+ // the agent UI saves merge-mode delimiters as a single string;+ // not trimmed, since "\n", "\t" and " " are valid delimiters+ p.Delimiters = nil+ if v != "" {+ p.Delimiters = []string{v}+ }case nil:// leave unchangeddefault:diff --git a/internal/agent/component/string_transform_test.go b/internal/agent/component/string_transform_test.goindex 2d1ac5f30d..0540085261 100644--- a/internal/agent/component/string_transform_test.go+++ b/internal/agent/component/string_transform_test.go@@ -17,6 +17,7 @@package componentimport (+ "errors""reflect""testing"@@ -159,6 +160,84 @@ func TestStringTransform_ParamCheck(t *testing.T) {}}+// TestStringTransform_MergeStringDelimiter: the agent UI saves merge-mode+// delimiters as a single string (","), which must build and merge.+func TestStringTransform_MergeStringDelimiter(t *testing.T) {+ c, err := NewStringTransformComponent(map[string]any{+ "method": "merge",+ "delimiters": ",",+ "script": "{{x}} and {{y}}",+ })+ if err != nil {+ t.Fatalf("NewStringTransformComponent: %v", err)+ }+ state := canvas.NewCanvasState("run-6", "task-6")+ ctx := canvas.WithState(t.Context(), state)++ out, err := c.Invoke(ctx, nil, map[string]any{"x": "foo", "y": "bar"})+ if err != nil {+ t.Fatalf("Invoke: %v", err)+ }+ if got, want := out["result"], "foo and bar"; got != want {+ t.Errorf("merge: got %v, want %v", got, want)+ }+}++// TestStringTransform_WhitespaceStringDelimiter: a whitespace string+// delimiter ("\n") is kept as is, not trimmed away.+func TestStringTransform_WhitespaceStringDelimiter(t *testing.T) {+ c, err := NewStringTransformComponent(map[string]any{+ "method": "merge",+ "delimiters": "\n",+ })+ if err != nil {+ t.Fatalf("NewStringTransformComponent: %v", err)+ }+ got := c.(*StringTransformComponent).param.Delimiters+ want := []string{"\n"}+ if !reflect.DeepEqual(got, want) {+ t.Errorf("delimiters: got %q, want %q", got, want)+ }+}++// TestStringTransform_SplitStringDelimiter: "a;b" with delimiters=";" → ["a", "b"].+func TestStringTransform_SplitStringDelimiter(t *testing.T) {+ c, err := NewStringTransformComponent(map[string]any{+ "method": "split",+ "delimiters": ";",+ })+ if err != nil {+ t.Fatalf("NewStringTransformComponent: %v", err)+ }+ state := canvas.NewCanvasState("run-7", "task-7")+ ctx := canvas.WithState(t.Context(), state)++ out, err := c.Invoke(ctx, nil, map[string]any{"line": "a;b"})+ if err != nil {+ t.Fatalf("Invoke: %v", err)+ }+ got, _ := out["result"].([]string)+ want := []string{"a", "b"}+ if !reflect.DeepEqual(got, want) {+ t.Errorf("split: got %v, want %v", got, want)+ }+}++// TestStringTransform_EmptyStringDelimiter: delimiters="" is rejected.+func TestStringTransform_EmptyStringDelimiter(t *testing.T) {+ _, err := NewStringTransformComponent(map[string]any{+ "method": "merge",+ "delimiters": "",+ })+ var pe *ParamError+ if !errors.As(err, &pe) {+ t.Fatalf("err=%v, want *ParamError", err)+ }+ if pe.Field != "delimiters" {+ t.Errorf("ParamError.Field=%q, want delimiters", pe.Field)+ }+}+// TestStringTransform_Registered: factory lookup.func TestStringTransform_Registered(t *testing.T) {c, err := New("StringTransform", map[string]any{