Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

chore: fix some function names in comments (#20550)

somasoil29bb5fc5e720
diff --git a/internal/service/dataset/update_test.go b/internal/service/dataset/update_test.go
index 72b57c4cbc..7b9b6d0b0a 100644
--- a/internal/service/dataset/update_test.go
+++ b/internal/service/dataset/update_test.go
@@ -1193,7 +1193,7 @@ func TestUpdateDataset_AcceptsValidComponentParams_Builtin(t *testing.T) {
}
}
-// extractorNodeMetadata returns the metadata object stored on the first
+// extractorNodeMetadataInTest returns the metadata object stored on the first
// Extractor node of a parser_config (the component-scoped form).
func extractorNodeMetadataInTest(t *testing.T, cfg map[string]interface{}) map[string]interface{} {
t.Helper()
diff --git a/internal/service/document/document_upload_test.go b/internal/service/document/document_upload_test.go
index 0b7588db4c..0778ef2ebb 100644
--- a/internal/service/document/document_upload_test.go
+++ b/internal/service/document/document_upload_test.go
@@ -6,9 +6,10 @@ import (
"ragflow/internal/entity"
)
-// cloneParserConfigForDocument must deep-copy the nested maps a database load
-// hands out, so writing a component entry onto one document's config cannot
-// leak into the dataset's config or a sibling document's config.
+// TestCloneParserConfigForDocument verifies that cloneParserConfigForDocument must
+// deep-copy the nested maps a database load hands out, so writing a component
+// entry onto one document's config cannot leak into the dataset's config or a
+// sibling document's config.
func TestCloneParserConfigForDocument(t *testing.T) {
if clone := cloneParserConfigForDocument(nil); clone == nil || len(clone) != 0 {
t.Fatalf("nil config must clone to an empty object, got %#v", clone)
diff --git a/internal/service/file/file_folder_test.go b/internal/service/file/file_folder_test.go
index 809529ef7e..5cf3ab851d 100644
--- a/internal/service/file/file_folder_test.go
+++ b/internal/service/file/file_folder_test.go
@@ -205,8 +205,9 @@ func TestRenameLinkedDocumentsLookupErrorPropagates(t *testing.T) {
}
}
-// Renaming while moving into the same parent folder (no storage move) must
-// also propagate the new name to every linked document.
+// TestMoveEntryRecursiveRenameUpdatesAllLinkedDocuments verifies that renaming while
+// moving into the same parent folder (no storage move) must also propagate the new
+// name to every linked document.
func TestMoveEntryRecursiveRenameUpdatesAllLinkedDocuments(t *testing.T) {
db := setupFolderTestDB(t)
insertFolderTestFile(t, "file-1", "folder-1", "old.pdf")
diff --git a/internal/service/memory_queue_task_test.go b/internal/service/memory_queue_task_test.go
index 313b5997e3..e67a38ad0e 100644
--- a/internal/service/memory_queue_task_test.go
+++ b/internal/service/memory_queue_task_test.go
@@ -25,10 +25,11 @@ func TestPublishMemoryTaskWakeupContainsOnlyDurableIdentity(t *testing.T) {
}
}
-// publishMemoryTaskWakeup is the agent-canvas memory-save publish path. When the
-// message queue engine is a NatsEngine whose Init failed at boot, publishing
-// must surface a clean error (caught by the Message component's best-effort
-// memory save) rather than panicking and failing the whole canvas run.
+// TestQueueMemoryTaskUninitializedQueueReturnsError verifies that publishMemoryTaskWakeup,
+// the agent-canvas memory-save publish path, surfaces a clean error. When the
+// queue engine is a NatsEngine whose Init failed at boot (caught by the Message
+// component's best-effort memory save) rather than panicking and failing the whole
+// canvas run.
func TestQueueMemoryTaskUninitializedQueueReturnsError(t *testing.T) {
previous := engine.GetMessageQueueEngine()
engine.SetMessageQueueEngine(natsengine.NewNatsEngine("127.0.0.1", 1))
diff --git a/internal/service/metadata.go b/internal/service/metadata.go
index 552b9c6a51..87e7f7102a 100644
--- a/internal/service/metadata.go
+++ b/internal/service/metadata.go
@@ -515,7 +515,7 @@ func ExtractMetaFields(chunk map[string]interface{}) (map[string]interface{}, er
return metaFields, nil
}
-// mergeFieldValues merges two field values when the same key appears multiple times
+// MergeFieldValues merges two field values when the same key appears multiple times
// If both are arrays, append all elements. If one is array and other is string, append string to array.
// Returns []interface{} with all merged values (flattened).
func MergeFieldValues(existing, new interface{}) []interface{} {
diff --git a/internal/service/nlp/datasetnav.go b/internal/service/nlp/datasetnav.go
index 2addd09374..2cad92b644 100644
--- a/internal/service/nlp/datasetnav.go
+++ b/internal/service/nlp/datasetnav.go
@@ -1767,7 +1767,8 @@ func firstStringValue(v interface{}) string {
return ""
}
-// intValue returns the integer value of an engine field.
+// firstStringSlice returns v as a []string, unwrapping a []interface{} whose
+// elements are all strings; returns nil for any other type.
func firstStringSlice(v interface{}) []string {
switch s := v.(type) {
case []string:
diff --git a/internal/service/web_search_provider_test.go b/internal/service/web_search_provider_test.go
index bc4c6aec0b..982c04e996 100644
--- a/internal/service/web_search_provider_test.go
+++ b/internal/service/web_search_provider_test.go
@@ -665,10 +665,10 @@ func TestRetrieveYouComWebSearchRejectsErrorStatuses(t *testing.T) {
}
}
-// Brave, Exa, Firecrawl, Linkup and Parallel all authenticate with a key and
-// ship no keyless path, so selecting one without a key must leave web search
-// unconfigured rather than silently degrade. (Exa has a free tier, but the key
-// is still mandatory — see its own test.)
+// TestResolveWebSearchProviderSelectsKeyedProviders asserts that Brave, Exa, Firecrawl,
+// Linkup and Parallel all authenticate with a key and ship no keyless path, so
+// selecting one without a key must leave web search unconfigured rather than silently
+// degrade. (Exa has a free tier, but the key is still mandatory — see its own test.)
func TestResolveWebSearchProviderSelectsKeyedProviders(t *testing.T) {
cases := []struct {
provider string