RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(memory): make default prompts deterministic (#18547)
primorLee3838c626aa9c
diff --git a/api/db/joint_services/memory_message_service.py b/api/db/joint_services/memory_message_service.pyindex 3ec007c595..1405a3a423 100644--- a/api/db/joint_services/memory_message_service.py+++ b/api/db/joint_services/memory_message_service.py@@ -366,7 +366,7 @@ def fix_missing_tokenized_memory():def judge_system_prompt_is_default(system_prompt: str, memory_type: int | list[str]):memory_type_list = memory_type if isinstance(memory_type, list) else get_memory_type_human(memory_type)- return system_prompt == PromptAssembler.assemble_system_prompt({"memory_type": memory_type_list})+ return PromptAssembler.is_default_system_prompt(system_prompt, {"memory_type": memory_type_list})async def queue_save_to_memory_task(memory_ids: list[str], message_dict: dict):diff --git a/memory/utils/prompt_util.py b/memory/utils/prompt_util.pyindex 18e5f0561e..d0df625ce4 100644--- a/memory/utils/prompt_util.py+++ b/memory/utils/prompt_util.py@@ -13,6 +13,7 @@# See the License for the specific language governing permissions and# limitations under the License.#+from itertools import permutationsfrom typing import Optional, Listfrom common.constants import MemoryType@@ -113,7 +114,16 @@ You are an expert at analyzing conversations to extract structured memory.@classmethoddef assemble_system_prompt(cls, config: dict) -> str:types_to_extract = cls._get_types_to_extract(config["memory_type"])+ return cls._assemble_system_prompt(config, types_to_extract)+ @classmethod+ def is_default_system_prompt(cls, system_prompt: str, config: dict) -> bool:+ """Recognize generated defaults without depending on type section order."""+ types_to_extract = cls._get_types_to_extract(config["memory_type"])+ return any(system_prompt == cls._assemble_system_prompt(config, list(type_order)) for type_order in permutations(types_to_extract))++ @classmethod+ def _assemble_system_prompt(cls, config: dict, types_to_extract: List[str]) -> str:type_instructions = cls._generate_type_instructions(types_to_extract)output_format = cls._generate_output_format(types_to_extract)@@ -132,22 +142,16 @@ You are an expert at analyzing conversations to extract structured memory.@staticmethoddef _get_types_to_extract(requested_types: List[str]) -> List[str]:- types = set()- for rt in requested_types:- if rt in [e.name.lower() for e in MemoryType] and rt != MemoryType.RAW.name.lower():- types.add(rt)- return list(types)+ return [memory_type.name.lower() for memory_type in MemoryType if memory_type is not MemoryType.RAW and memory_type.name.lower() in requested_types]@classmethoddef _generate_type_instructions(cls, types_to_extract: List[str]) -> str:- target_types = set(types_to_extract)- instructions = [cls.TYPE_INSTRUCTIONS[mt] for mt in target_types]+ instructions = [cls.TYPE_INSTRUCTIONS[mt] for mt in types_to_extract]return "\n".join(instructions)@classmethoddef _generate_output_format(cls, types_to_extract: List[str]) -> str:- target_types = set(types_to_extract)- output_parts = [cls.OUTPUT_TEMPLATES[mt] for mt in target_types]+ output_parts = [cls.OUTPUT_TEMPLATES[mt] for mt in types_to_extract]return ",\n".join(output_parts)@staticmethoddiff --git a/test/unit_test/memory/utils/test_prompt_util.py b/test/unit_test/memory/utils/test_prompt_util.pyindex ff06ac8b88..f3102b884c 100644--- a/test/unit_test/memory/utils/test_prompt_util.py+++ b/test/unit_test/memory/utils/test_prompt_util.py@@ -14,6 +14,10 @@# limitations under the License.#+import os+import subprocess+import sys+from memory.utils.prompt_util import PromptAssembler@@ -22,3 +26,35 @@ def test_semantic_output_format_requires_valid_at_timestamp():assert '"valid_at": "timestamp — use the conversation time when the fact has no date of its own"' in promptassert '"valid_at": "timestamp or empty"' not in prompt+++def test_multi_type_prompt_is_stable_across_hash_seeds():+ code = """+from memory.utils.prompt_util import PromptAssembler++print(PromptAssembler.assemble_system_prompt(+ {"memory_type": ["semantic", "episodic", "procedural"]}+))+"""++ def assemble_with_seed(seed: int) -> str:+ env = os.environ.copy()+ env["PYTHONHASHSEED"] = str(seed)+ return subprocess.run(+ [sys.executable, "-c", code],+ check=True,+ capture_output=True,+ text=True,+ env=env,+ ).stdout++ assert assemble_with_seed(1) == assemble_with_seed(3)+++def test_noncanonical_prompt_order_is_still_default():+ config = {"memory_type": ["semantic", "episodic", "procedural"]}+ legacy_prompt = PromptAssembler._assemble_system_prompt(config, ["procedural", "semantic", "episodic"])++ assert legacy_prompt != PromptAssembler.assemble_system_prompt(config)+ assert PromptAssembler.is_default_system_prompt(legacy_prompt, config)+ assert not PromptAssembler.is_default_system_prompt(legacy_prompt + "custom", config)