RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
test(ingestion): pin that the image parser handoff never downgrades to text (#21500)
CCLUCKY39e6f0340094
diff --git a/internal/ingestion/component/parser_image_handoff_test.go b/internal/ingestion/component/parser_image_handoff_test.gonew file mode 100644index 0000000000..37a320e986--- /dev/null+++ b/internal/ingestion/component/parser_image_handoff_test.go@@ -0,0 +1,103 @@+//+// Copyright 2026 The InfiniFlow Authors. All Rights Reserved.+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+// http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.+//++package component++import (+ "context"+ "testing"++ "gorm.io/gorm"++ "ragflow/internal/dao"+ "ragflow/internal/entity"+ modelModule "ragflow/internal/entity/models"+ "ragflow/internal/ingestion/component/schema"+ "ragflow/internal/parser/parser"+)++// TestImageHandoffAlwaysEmitsJSON pins the #16835 contract at the place it+// actually breaks: a Parser run over an image must hand the Tokenizer a JSON+// payload, and the Tokenizer must turn it into a chunk. The image parser has no+// text payload to fall back on, so the emitted format is not a user choice and+// setups["image"]["output_format"] must not reach it.+//+// The failure mode is silent: a "text" handoff routes the Tokenizer to its text+// branch, which reads the top-level text field the image parser never fills, and+// the document indexes zero chunks while the pipeline reports success.+//+// The single write point is buildParserOutputs; every media branch (image,+// audio, PDF vision) leaves through it, so asserting here covers them all.+// TestMaybeDispatchImage_HardcodesJSONOutput and TestLegacyOutputFormatKeyIsIgnored+// pin the same invariant one level down; this is the only one that measures the+// reported symptom.+func TestImageHandoffAlwaysEmitsJSON(t *testing.T) {+ withFileComponentTestDB(t)++ origResolver := resolveTenantModelByType+ t.Cleanup(func() { resolveTenantModelByType = origResolver })++ drv := &imagePromptCaptureDriver{}+ resolveTenantModelByType = func(context.Context, *gorm.DB, string, entity.ModelType) (modelModule.ModelDriver, string, *modelModule.APIConfig, int, error) {+ return drv, "img-model", &modelModule.APIConfig{}, 0, nil+ }++ // OCR off, so the only text source is the vision model: a non-empty item+ // proves the payload came through the handoff rather than a local fallback.+ setups := imageSwitchSetups(t, false)+ setups["image"]["output_format"] = "text"++ c := &ParserComponent{setups: setups, enableVisionEnhancement: true}+ out, err := c.Invoke(t.Context(), dao.DB, map[string]any{+ "binary": picturePNG(t),+ "name": "Screenshot.png",+ "file_type": "png",+ "tenant_id": "t1",+ })+ if err != nil {+ t.Fatalf("Invoke: %v", err)+ }+ if got := out["output_format"]; got != "json" {+ t.Fatalf("output_format = %v, want json", got)+ }++ items, ok := out["json"].([]parser.DocItem)+ if !ok || len(items) != 1 {+ t.Fatalf("json = %T/%d, want one image item", out["json"], len(items))+ }+ item := items[0].ToMap()+ if item["doc_type_kwd"] != "image" {+ t.Fatalf("doc_type_kwd = %v, want image", item["doc_type_kwd"])+ }+ if text, _ := item["text"].(string); text != "captured" {+ t.Fatalf("image item text = %q, want the vision answer %q", text, "captured")+ }++ upstream, err := decodeTokenizerFromUpstream(out)+ if err != nil {+ t.Fatalf("decodeTokenizerFromUpstream: %v", err)+ }+ if got := upstream.OutputFormat; got != schema.PayloadFormatJSON {+ t.Fatalf("tokenizer output_format = %q, want %q", got, schema.PayloadFormatJSON)+ }+ chunks := chunksFromTokenizerUpstream(upstream)+ if len(chunks) != 1 {+ t.Fatalf("chunks = %d, want 1", len(chunks))+ }+ if chunks[0].Text != "captured" {+ t.Errorf("chunk text = %q, want %q", chunks[0].Text, "captured")+ }+}