Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(ingestion): support legacy .xls BIFF8 as tag source (#21483)

jay777213e313daf6ffd
diff --git a/internal/ingestion/component/tag_biff8_test.go b/internal/ingestion/component/tag_biff8_test.go
new file mode 100644
index 0000000000..9b7006ac5d
--- /dev/null
+++ b/internal/ingestion/component/tag_biff8_test.go
@@ -0,0 +1,84 @@
+package component
+
+import (
+ "encoding/base64"
+ "testing"
+)
+
+// tagBIFF8FixtureBase64 was generated with xlwt: one sheet "tags" with
+// (content, tags) rows, including a single-cell row that must accumulate
+// into the next tagged row. It is an OLE compound document (BIFF8), not
+// OOXML bytes renamed to .xls.
+const tagBIFF8FixtureBase64 = `
+0M8R4KGxGuEAAAAAAAAAAAAAAAAAAAAAPgADAP7/CQAGAAAAAAAAAAAAAAABAAAACQAAAAAAAAAAEAAA/v///wAAAAD+////AAAAAAgAAAD/////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+//////////////////////////////////////////8JCBAAAAYFALsNzAcAAAAABgAAAOEAAgCwBMEAAgAAAOIAAABcAHAATm9uZSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEIAAgCwBGEBAgAAAD0BAgABAJwAAgAOABkAAgAAABIAAgAAAGMAAgAAABMAAgAAAK8BAgAAALwB
+AgAAAEAAAgAAAI0AAgAAAD0AEgDgAVoAzz9OKjgAAAAAAAEAWAIiAAIAAAAOAAIAAQC3AQIAAADaAAIAAAAxABUAyAAAAP9/kAEAAAAAAQAFAEFyaWFsMQAVAMgAAAD/f5ABAAAAAAEABQBBcmlhbDEAFQDIAAAA
+/3+QAQAAAAABAAUAQXJpYWwxABUAyAAAAP9/kAEAAAAAAQAFAEFyaWFsMQAVAMgAAAD/f5ABAAAAAAEABQBBcmlhbDEAFQDIAAAA/3+QAQAAAAABAAUAQXJpYWwxABUAyAAAAP9/kAEAAAAAAQAFAEFyaWFsHgQM
+AKQABwAAR2VuZXJhbOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8g
+AAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8g
+AAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQA9f8g
+AAD0AAAAAAAAAADAIOAAFAAGAKQA9f8gAAD0AAAAAAAAAADAIOAAFAAGAKQAAQAgAAD4AAAAAAAAAADAIOAAFAAHAKQAAQAgAAD4AAAAAAAAAADAIJMCBAAAgAD/YAECAAEAhQAMAAgEAAAAAAQAdGFnc/wAZQAH
+AAAABwAAAA0AAFJBR0Zsb3cgZ3VpZGUMAABSQUcsdHV0b3JpYWwJAABMTE0gaW50cm8DAABMTE0JAABzb2xvIGxpbmURAABjb250aW51ZWQgY29udGVudAkAAFRhZzEsVGFnMgoAAAAJCBAAAAYQALsNzAcAAAAA
+BgAAAA0AAgABAAwAAgBkAA8AAgABABEAAgAAABAACAD8qfHSTWJQP18AAgAAAIAACAAAAAAAAQAAACUCBAAAAP8AgQACAAEMAAIOAAAAAAAEAAAAAAACAAAAKgACAAAAKwACAAAAggACAAEAGwACAAAAGgACAAAA
+FAAFAAIAACZQFQAFAAIAACZGgwACAAEAhAACAAAAJgAIADMzMzMzM9M/JwAIADMzMzMzM9M/KAAIAIXrUbgeheM/KQAIAK5H4XoUrtc/oQAiAAkAZAABAAEAAQCDACwBLAGamZmZmZm5P5qZmZmZmbk/AQASAAIA
+AADdAAIAAAAZAAIAAABjAAIAAAATAAIAAAAIAhAAAAAAAAIA/wAAAAAAAAEPAP0ACgAAAAAAEQAAAAAA/QAKAAAAAQARAAEAAAAIAhAAAQAAAAIA/wAAAAAAAAEPAP0ACgABAAAAEQACAAAA/QAKAAEAAQARAAMA
+AAAIAhAAAgAAAAEA/wAAAAAAAAEPAP0ACgACAAAAEQAEAAAACAIQAAMAAAACAP8AAAAAAAABDwD9AAoAAwAAABEABQAAAP0ACgADAAEAEQAGAAAAPgISALYCAAAAAEAAAAAAAAAAAAAAAAoAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAIAAAADAAAABAAAAAUAAAAGAAAABwAAAP7////9/////v//////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+//////////////////////////////////////////////////////////////////////////////////////////////////////////9SAG8AbwB0ACAARQBuAHQAcgB5AAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAFgAFAf//////////AQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP7///8AAAAAAAAAAFcAbwByAGsAYgBvAG8AawAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAASAAIB////////////////AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAH///////////////8AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAD+////AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
+AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAf///////////////wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP7///8AAAAAAAAAAA==
+`
+
+func TestParseBIFF8TagSource(t *testing.T) {
+ // StdEncoding ignores \r\n, so the multi-line fixture decodes directly.
+ data, err := base64.StdEncoding.DecodeString(tagBIFF8FixtureBase64)
+ if err != nil {
+ t.Fatalf("decode BIFF8 fixture: %v", err)
+ }
+ got, err := parseTagSourceByFilename(data, "tags.xls")
+ if err != nil {
+ t.Fatalf("xls: unexpected error: %v", err)
+ }
+ if len(got) != 3 {
+ t.Fatalf("xls: expected 3 examples, got %d (%+v)", len(got), got)
+ }
+ if got[0].Content != "RAGFlow guide" || len(got[0].Tags) != 2 || got[0].Tags[0] != "RAG" || got[0].Tags[1] != "tutorial" {
+ t.Errorf("xls[0] = %+v", got[0])
+ }
+ if got[1].Content != "LLM intro" || len(got[1].Tags) != 1 || got[1].Tags[0] != "LLM" {
+ t.Errorf("xls[1] = %+v", got[1])
+ }
+ if got[2].Content != "solo line\ncontinued content" || len(got[2].Tags) != 2 {
+ t.Errorf("xls[2] = %+v", got[2])
+ }
+}
diff --git a/internal/ingestion/component/tag_source.go b/internal/ingestion/component/tag_source.go
index f157a3e1f2..38e6218729 100644
--- a/internal/ingestion/component/tag_source.go
+++ b/internal/ingestion/component/tag_source.go
@@ -44,12 +44,14 @@ import (
"sync"
"time"
+ excel "github.com/jloor/go-excel-reader"
"github.com/xuri/excelize/v2"
"ragflow/internal/common"
"ragflow/internal/dao"
"ragflow/internal/entity"
"ragflow/internal/ingestion/component/schema"
+ "ragflow/internal/parser/parser"
"ragflow/internal/tokenizer"
"gorm.io/gorm"
@@ -358,7 +360,7 @@ func parseTagSourceByFilename(data []byte, filename string) ([]schema.TagLabel,
delimiter := detectCSVDelimiterBytes(data)
return parseCSVTagSourceReader(bytes.NewReader(data), delimiter), nil
default:
- return nil, fmt.Errorf("unsupported tag source extension %q: only .xlsx, .txt and .csv are supported", filepath.Ext(filename))
+ return nil, fmt.Errorf("unsupported tag source extension %q: only .xlsx, .xls, .txt and .csv are supported", filepath.Ext(filename))
}
}
@@ -494,7 +496,15 @@ func parseCSVQuoteAwareReader(r io.Reader, delimiter rune) []schema.TagLabel {
// first and second non-empty cells. Single-cell rows are accumulated as body text
// and prepended to the next tagged row, matching CSV parsing behavior.
// The second cell holds comma-separated tags.
+//
+// A legacy BIFF .xls (OLE compound document) is detected by magic and routed
+// to parseBIFF8TagSource, which applies the same per-row rule via
+// go-excel-reader — mirroring internal/parser/parser/xls_parser.go. An .xls
+// that is actually OOXML (renamed .xlsx) falls through to the excelize path.
func parseXLSXTagSource(data []byte) []schema.TagLabel {
+ if bytes.HasPrefix(data, parser.CompoundDocumentSignature) {
+ return parseBIFF8TagSource(data)
+ }
f, err := excelize.OpenReader(bytes.NewReader(data))
if err != nil {
common.Warn(fmt.Sprintf("extractor tags: open xlsx tag source: %v", err))
@@ -510,13 +520,6 @@ func parseXLSXTagSource(data []byte) []schema.TagLabel {
continue
}
content := ""
- appendLine := func(s string) {
- if content == "" {
- content = s
- } else {
- content += "\n" + s
- }
- }
for _, row := range rows {
var cells []string
for _, c := range row {
@@ -524,22 +527,71 @@ func parseXLSXTagSource(data []byte) []schema.TagLabel {
cells = append(cells, c)
}
}
- if len(cells) == 0 {
- continue
- }
- if len(cells) == 1 {
- appendLine(cells[0])
- continue
+ accumulateTagCells(cells, &content, &result)
+ }
+ }
+ return result
+}
+
+// parseBIFF8TagSource applies the parseXLSXTagSource row rule to a legacy
+// BIFF .xls workbook: every sheet is read with no header, each row's first
+// and second non-empty cells form a (content, tags) pair, and single-cell
+// rows accumulate as body text for the next tagged row. Cells beyond the
+// second are ignored, matching the xlsx path. The BIFF reader exposes no
+// merged ranges, so a vertical merge stays a dense row with an empty slave
+// cell — the same caveat as internal/parser/parser/xls_parser.go.
+func parseBIFF8TagSource(data []byte) []schema.TagLabel {
+ reader, err := excel.OpenXLS(bytes.NewReader(data), excel.WithErrorValues(true))
+ if err != nil {
+ common.Warn(fmt.Sprintf("extractor tags: open BIFF xls tag source: %v", err))
+ return nil
+ }
+ defer reader.Close()
+
+ result := make([]schema.TagLabel, 0)
+ for reader.NextSheet() {
+ content := ""
+ for reader.Read() {
+ var cells []string
+ for col := 0; col < reader.FieldCount(); col++ {
+ if c := strings.TrimSpace(parser.SpreadsheetCellString(reader.GetValue(col))); c != "" {
+ cells = append(cells, c)
+ }
}
- appendLine(cells[0])
- tags := splitAndTrim(cells[1], ",")
- result = append(result, schema.TagLabel{Content: content, Tags: tags})
- content = ""
+ accumulateTagCells(cells, &content, &result)
}
}
+ if err := reader.Err(); err != nil {
+ common.Warn(fmt.Sprintf("extractor tags: read BIFF xls tag source: %v", err))
+ }
return result
}
+// accumulateTagCells applies the shared tag row rule: empty rows are skipped,
+// single-cell rows accumulate as body text for the next tagged row, and rows
+// with two or more non-empty cells emit a (content, tags) pair from the first
+// two cells. Extra cells are ignored.
+func accumulateTagCells(cells []string, content *string, result *[]schema.TagLabel) {
+ if len(cells) == 0 {
+ return
+ }
+ appendLine := func(s string) {
+ if *content == "" {
+ *content = s
+ } else {
+ *content += "\n" + s
+ }
+ }
+ if len(cells) == 1 {
+ appendLine(cells[0])
+ return
+ }
+ appendLine(cells[0])
+ tags := splitAndTrim(cells[1], ",")
+ *result = append(*result, schema.TagLabel{Content: *content, Tags: tags})
+ *content = ""
+}
+
func stripEmptyFields(fields []string) []string {
out := make([]string, 0, len(fields))
for _, f := range fields {
diff --git a/internal/parser/parser/xls_parser.go b/internal/parser/parser/xls_parser.go
index ed855ffae2..76c5dfcd8a 100644
--- a/internal/parser/parser/xls_parser.go
+++ b/internal/parser/parser/xls_parser.go
@@ -26,7 +26,11 @@ import (
excel "github.com/jloor/go-excel-reader"
)
-var compoundDocumentSignature = []byte{0xd0, 0xcf, 0x11, 0xe0, 0xa1, 0xb1, 0x1a, 0xe1}
+// CompoundDocumentSignature is the OLE compound-document magic
+// (D0 CF 11 E0 ...), the on-disk container for legacy BIFF .xls.
+// Shared with the tag source reader (internal/ingestion/component/tag_source.go),
+// which applies the same magic check to legacy .xls tag files.
+var CompoundDocumentSignature = []byte{0xd0, 0xcf, 0x11, 0xe0, 0xa1, 0xb1, 0x1a, 0xe1}
type XLSParser struct {
ParseMethod string
@@ -93,7 +97,7 @@ func (p *XLSParser) ParseWithResult(ctx context.Context, filename string, data [
sheetsCount int
err error
)
- if bytes.HasPrefix(data, compoundDocumentSignature) {
+ if bytes.HasPrefix(data, CompoundDocumentSignature) {
items, sheetsCount, err = parseBIFF8Bytes(ctx, data)
} else {
mediaBudget := newEmbeddedMediaBudget()
@@ -156,7 +160,7 @@ func readBIFF8Records(ctx context.Context, reader excel.Reader) ([][]string, []i
}
cells := make([]string, reader.FieldCount())
for col := range cells {
- cells[col] = spreadsheetCellString(reader.GetValue(col))
+ cells[col] = SpreadsheetCellString(reader.GetValue(col))
}
if rowIsEmpty(cells) {
continue
@@ -178,7 +182,10 @@ func readBIFF8Records(ctx context.Context, reader excel.Reader) ([][]string, []i
return records, dataRows, rows[0].number
}
-func spreadsheetCellString(value any) string {
+// SpreadsheetCellString renders one BIFF cell as text: times use RFC3339,
+// nil is empty, everything else is Sprint'd and trimmed by the caller.
+// Shared with the tag source reader (internal/ingestion/component/tag_source.go).
+func SpreadsheetCellString(value any) string {
switch value := value.(type) {
case nil:
return ""