Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(parser): forward caller ctx through PDF TCADP path (#17673)

Taranum Wasu4dfcab718dc0
diff --git a/internal/parser/parser/pdf_parser_common.go b/internal/parser/parser/pdf_parser_common.go
index dcb93f0a96..197d25c358 100644
--- a/internal/parser/parser/pdf_parser_common.go
+++ b/internal/parser/parser/pdf_parser_common.go
@@ -380,7 +380,7 @@ func (p *PDFParser) ParseWithResult(ctx context.Context, filename string, data [
case "somark":
return parsePDFWithSoMark(filename, data, p)
case "tcadp":
- return parsePDFWithTCADP(filename, data, p)
+ return parsePDFWithTCADP(ctx, filename, data, p)
}
cfg := deepdoctype.DefaultParserConfig()
cfg.Pages = p.Pages
diff --git a/internal/parser/parser/pdf_parser_tcadp.go b/internal/parser/parser/pdf_parser_tcadp.go
index 226f9bd438..b10b13334c 100644
--- a/internal/parser/parser/pdf_parser_tcadp.go
+++ b/internal/parser/parser/pdf_parser_tcadp.go
@@ -14,8 +14,8 @@ import (
// parsePDFWithTCADP sends PDF binary data to the TCADP cloud reconstruction
// service. Thin wrapper over the shared parseWithTCADP core — env-fallbacks
// and request construction live there.
-func parsePDFWithTCADP(filename string, data []byte, parser *PDFParser) ParseResult {
- return parseWithTCADP(context.Background(), filename, data, "PDF",
+func parsePDFWithTCADP(ctx context.Context, filename string, data []byte, parser *PDFParser) ParseResult {
+ return parseWithTCADP(ctx, filename, data, "PDF",
parser.TCADPAPIServer, parser.TCADPAPIKey,
parser.TCADPTableResultType, parser.TCADPMarkdownImageResponseType,
parser.OutputFormat)
diff --git a/internal/parser/parser/pdf_parser_tcadp_test.go b/internal/parser/parser/pdf_parser_tcadp_test.go
index f3775e72b3..37dd8148aa 100644
--- a/internal/parser/parser/pdf_parser_tcadp_test.go
+++ b/internal/parser/parser/pdf_parser_tcadp_test.go
@@ -3,10 +3,12 @@ package parser
import (
"archive/zip"
"bytes"
+ "context"
"net/http"
"net/http/httptest"
"strings"
"testing"
+ "time"
)
func TestPDFParser_ParseWithResult_TCADPJSONIntegration(t *testing.T) {
@@ -78,7 +80,56 @@ func TestPDFParser_ParseWithResult_TCADPMarkdownIntegration(t *testing.T) {
}
}
+func TestPDFParser_ParseWithResult_TCADPCancellationAbortsDownload(t *testing.T) {
+ withSSRFBypass(t)
+
+ const downloadDelay = 500 * time.Millisecond
+ var slow *httptest.Server
+ submit := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ if r.URL.Path != "/reconstruct_document" {
+ http.NotFound(w, r)
+ return
+ }
+ w.Header().Set("Content-Type", "application/json")
+ _, _ = w.Write([]byte(`{"DocumentRecognizeResultUrl":"` + slow.URL + `/download"}`))
+ }))
+ defer submit.Close()
+ slow = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ select {
+ case <-time.After(downloadDelay):
+ _, _ = w.Write([]byte("not-a-zip"))
+ case <-r.Context().Done():
+ }
+ }))
+ defer slow.Close()
+
+ pdf := NewPDFParser()
+ pdf.ConfigureFromSetup(map[string]any{
+ "parse_method": "TCADP parser",
+ "output_format": "json",
+ "tcadp_apiserver": submit.URL,
+ "tcadp_api_key": "tcadp-secret",
+ })
+ ctx, cancel := context.WithTimeout(t.Context(), 50*time.Millisecond)
+ defer cancel()
+
+ start := time.Now()
+ res := pdf.ParseWithResult(ctx, "sample.pdf", []byte("%PDF-1.4\nmock"))
+ elapsed := time.Since(start)
+ if res.Err == nil {
+ t.Fatalf("expected cancellation error, got nil (elapsed=%v)", elapsed)
+ }
+ if !strings.Contains(res.Err.Error(), "context") {
+ t.Fatalf("error %q does not mention context cancellation", res.Err)
+ }
+ if elapsed > downloadDelay/2 {
+ t.Errorf("TCADP download did not abort on ctx cancellation; elapsed=%v", elapsed)
+ }
+}
+
func TestPDFParser_ParseWithResult_TCADPRequiresAPIServer(t *testing.T) {
+ t.Setenv("TCADP_APISERVER_URL", "")
+ t.Setenv("TCADP_APISERVER", "")
pdf := NewPDFParser()
pdf.ConfigureFromSetup(map[string]any{"parse_method": "TCADP parser"})
ctx := t.Context()