Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

Feat: Validate the knowledge base that was deleted from the search page. (#18522)

balibabu525571941a02
diff --git a/web/.oxlintrc.json b/web/.oxlintrc.json
index 6391d69dea..9d5cc299e0 100644
--- a/web/.oxlintrc.json
+++ b/web/.oxlintrc.json
@@ -24,6 +24,7 @@
"typescript/no-non-null-assertion": "off",
"react/react-in-jsx-scope": "off",
"react/no-unescaped-entities": "warn",
- "no-console": ["warn", { "allow": ["warn", "error"] }]
+ "no-console": ["warn", { "allow": ["warn", "error"] }],
+ "no-unused-vars": ["warn", { "fix": { "imports": "safe-fix" } }]
}
}
diff --git a/web/src/components/knowledge-base-item.tsx b/web/src/components/knowledge-base-item.tsx
index 383127bb15..91aee2062f 100644
--- a/web/src/components/knowledge-base-item.tsx
+++ b/web/src/components/knowledge-base-item.tsx
@@ -24,7 +24,7 @@ import { useBuildQueryVariableOptions } from '@/pages/agent/hooks/use-get-begin-
import { getEmbeddingBaseName } from '@/utils/llm-util';
import { useDebounce } from 'ahooks';
import { toLower } from 'lodash';
-import { type ReactNode, useCallback, useMemo, useRef, useState } from 'react';
+import { type ReactNode, useCallback, useMemo, useState } from 'react';
import { useFormContext, useWatch } from 'react-hook-form';
import { useTranslation } from 'react-i18next';
import { RAGFlowAvatar } from './ragflow-avatar';
@@ -54,46 +54,27 @@ export function useDisableDifferenceEmbeddingDataset(name: string) {
handleScroll,
hasNextPage,
} = useFetchKnowledgeList(false, debouncedSearchString);
- const datasetCacheRef = useRef(new Map<string, IDataset>());
-
const selectedDatasetIds = useMemo(
() => (Array.isArray(datasetId) ? datasetId : []),
[datasetId],
);
- // Selected dataset IDs that are neither in the currently loaded page nor
- // already cached. These need to be fetched by ID so their names can be
- // echoed back in the form field (the paginated list may not contain them).
- const missingIds = useMemo(() => {
- const loadedIds = new Set(datasetListOrigin.map((d) => d.id));
- return selectedDatasetIds.filter(
- (id) => !loadedIds.has(id) && !datasetCacheRef.current.has(id),
- );
- }, [datasetListOrigin, selectedDatasetIds]);
-
- const { data: missingDatasets } = useFetchDatasetsByIds(missingIds);
+ // The paginated list may not contain the selected datasets (unloaded
+ // pages, filtered out by the search box), so resolve them by ID to echo
+ // their names back in the form field. A dataset that has been deleted
+ // comes back missing and its badge falls back to the raw id.
+ const { data: selectedDatasets } = useFetchDatasetsByIds(selectedDatasetIds);
const datasetList = useMemo(() => {
- datasetListOrigin.forEach((dataset) => {
- datasetCacheRef.current.set(dataset.id, dataset);
- });
- missingDatasets?.forEach((dataset) => {
- datasetCacheRef.current.set(dataset.id, dataset);
- });
-
- const selectedDatasets = selectedDatasetIds
- .map((id) => datasetCacheRef.current.get(id))
- .filter(Boolean) as IDataset[];
-
return Array.from(
new Map(
- [...datasetListOrigin, ...selectedDatasets].map((dataset) => [
+ [...datasetListOrigin, ...(selectedDatasets ?? [])].map((dataset) => [
dataset.id,
dataset,
]),
).values(),
);
- }, [datasetListOrigin, selectedDatasetIds, missingDatasets]);
+ }, [datasetListOrigin, selectedDatasets]);
// Datasets are mutually selectable when their embedding models resolve to
// the same base model name, even if they use different provider instances
diff --git a/web/src/hooks/use-knowledge-request.ts b/web/src/hooks/use-knowledge-request.ts
index bf6672f09b..891e4ed07f 100644
--- a/web/src/hooks/use-knowledge-request.ts
+++ b/web/src/hooks/use-knowledge-request.ts
@@ -78,7 +78,7 @@ import {
} from '@tanstack/react-query';
import { useDebounce } from 'ahooks';
import { omit } from 'lodash';
-import { useCallback, useEffect, useMemo, useState } from 'react';
+import { useCallback, useMemo, useState } from 'react';
import { useParams, useSearchParams } from 'react-router';
import {
useGetPaginationWithRouter,
@@ -1109,41 +1109,6 @@ export const useFetchKnowledgeList = (
};
};
-/**
- * For consumers that need the COMPLETE list (no scroll UI).
- * Uses a large page size to minimize round-trips, and auto-loads
- * until exhausted.
- */
-export const useFetchAllKnowledgeList = (
- shouldFilterListWithoutDocument: boolean = false,
- keywords = '',
-): { list: IDataset[]; loading: boolean } => {
- const { list, loading, hasNextPage, fetchNextPage } = useFetchKnowledgeList(
- shouldFilterListWithoutDocument,
- keywords,
- 100,
- );
-
- useEffect(() => {
- if (hasNextPage && !loading) {
- fetchNextPage();
- }
- }, [hasNextPage, loading, fetchNextPage]);
-
- return { list, loading };
-};
-
-export const useSelectKnowledgeOptions = () => {
- const { list } = useFetchAllKnowledgeList();
-
- const options = list?.map((item) => ({
- label: item.name,
- value: item.id,
- }));
-
- return options;
-};
-
/**
* Fetch datasets by a set of IDs. Used to resolve already-selected datasets
* that are not present in the first page of the paginated list, e.g. to echo
@@ -1155,6 +1120,10 @@ export const useFetchDatasetsByIds = (ids: string[]) => {
queryKey: KnowledgeListKeys.byIds(sortedIds),
enabled: sortedIds.length > 0,
gcTime: 0,
+ // Hold the previous result across id-list changes so consumers rendering
+ // from `data` don't flash an empty state while the next lookup is in
+ // flight.
+ placeholderData: keepPreviousData,
queryFn: async () => {
const { data } = await listDatasetByIds(sortedIds);
return (data?.data ?? []) as IDataset[];
diff --git a/web/src/hooks/use-stale-dataset-validation.ts b/web/src/hooks/use-stale-dataset-validation.ts
new file mode 100644
index 0000000000..4fe1892894
--- /dev/null
+++ b/web/src/hooks/use-stale-dataset-validation.ts
@@ -0,0 +1,77 @@
+/*
+ * Copyright 2026 The InfiniFlow Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { get } from 'lodash';
+import { useEffect, useMemo } from 'react';
+import { UseFormReturn, useWatch } from 'react-hook-form';
+import { useTranslation } from 'react-i18next';
+import { z } from 'zod';
+import { useStaleDatasetIds } from './use-knowledge-request';
+
+/**
+ * Extend a form schema with staleness validation on its dataset-id field
+ * (`fieldName`, a dotted path defaulting to `dataset_ids`). Only the
+ * persisted ids are looked up: ids picked from the dataset select are valid
+ * by construction, while a persisted id may reference a dataset that has
+ * since been deleted or emptied of chunks — those stale ids are flagged here.
+ */
+export function useStaleDatasetFormSchema<T extends z.ZodTypeAny>(
+ schema: T,
+ persistedDatasetIds?: string[],
+ fieldName = 'dataset_ids',
+) {
+ const { t } = useTranslation();
+ const { staleDatasetIds, settled: datasetsFetched } =
+ useStaleDatasetIds(persistedDatasetIds);
+
+ const formSchema = useMemo(() => {
+ const path = fieldName.split('.');
+ return schema.superRefine((data: any, ctx) => {
+ const ids = get(data, path) as string[] | undefined;
+ if (ids?.some((id) => staleDatasetIds.has(id))) {
+ ctx.addIssue({
+ path,
+ message: t('chat.datasetUnavailable'),
+ code: z.ZodIssueCode.custom,
+ });
+ }
+ });
+ }, [schema, staleDatasetIds, fieldName, t]);
+
+ return { formSchema, datasetsFetched };
+}
+
+/**
+ * A persisted dataset-id value never fires onChange validation, so once the
+ * lookup of those ids has settled, revalidate explicitly — it may reference
+ * datasets that have since been deleted or emptied of chunks.
+ */
+export function useRevalidateStaleDatasetIds(
+ form: UseFormReturn<any>,
+ datasetsFetched: boolean,
+ fieldName = 'dataset_ids',
+) {
+ const datasetIds = useWatch({ control: form.control, name: fieldName });
+ const trigger = form.trigger;
+
+ useEffect(() => {
+ if (!datasetsFetched || !datasetIds?.length) {
+ return;
+ }
+
+ trigger(fieldName);
+ }, [trigger, datasetsFetched, datasetIds?.length, fieldName]);
+}
diff --git a/web/src/pages/agent/canvas/node/retrieval-node.tsx b/web/src/pages/agent/canvas/node/retrieval-node.tsx
index bbbd0dc473..c3217a56eb 100644
--- a/web/src/pages/agent/canvas/node/retrieval-node.tsx
+++ b/web/src/pages/agent/canvas/node/retrieval-node.tsx
@@ -1,12 +1,17 @@
import { NodeCollapsible } from '@/components/collapse';
import { RAGFlowAvatar } from '@/components/ragflow-avatar';
-import { useFetchAllKnowledgeList } from '@/hooks/use-knowledge-request';
+import {
+ useFetchDatasetsByIds,
+ useStaleDatasetIds,
+} from '@/hooks/use-knowledge-request';
import { useFetchAllMemoryList } from '@/hooks/use-memory-request';
import { BaseNode } from '@/interfaces/database/agent';
import { NodeProps, Position } from '@xyflow/react';
import classNames from 'classnames';
import { get } from 'lodash';
+import { TriangleAlert } from 'lucide-react';
import { memo } from 'react';
+import { useTranslation } from 'react-i18next';
import { NodeHandleId, RetrievalFrom } from '../../constant';
import { RetrievalFormSchemaType } from '../../form/retrieval-form/next';
import { useGetVariableLabelOrTypeByValue } from '../../hooks/use-get-begin-query';
@@ -25,12 +30,24 @@ function InnerRetrievalNode({
}: NodeProps<BaseNode<RetrievalFormSchemaType>>) {
const knowledgeBaseIds: string[] = get(data, 'form.dataset_ids', []);
const memoryIds: string[] = get(data, 'form.memory_ids', []);
- const { list: knowledgeList } = useFetchAllKnowledgeList(true);
+ const { t } = useTranslation();
const { getLabel } = useGetVariableLabelOrTypeByValue({ nodeId: id });
const isMemory = data.form?.retrieval_from === RetrievalFrom.Memory;
+ const persistedDatasetIds = isMemory ? [] : knowledgeBaseIds;
+
+ // Resolve names/avatars for the persisted ids directly: the paginated
+ // knowledge list can miss them (unloaded pages, emptied datasets filtered
+ // out). Shares the byIds query with the staleness check below.
+ const { data: datasets } = useFetchDatasetsByIds(persistedDatasetIds);
+
+ // Mirror the form's stale-dataset validation: a persisted id referencing a
+ // dataset that has since been deleted or emptied of chunks is flagged on
+ // the node as well. Stays empty while the lookup is in flight.
+ const { staleDatasetIds } = useStaleDatasetIds(persistedDatasetIds);
+
const memoryList = useFetchAllMemoryList();
return (
@@ -69,19 +86,34 @@ function InnerRetrievalNode({
);
}
- const item = knowledgeList.find((y) => id === y.id);
+ const item = datasets?.find((y) => id === y.id);
const label = getLabel(id);
+ // A variable reference (has a label) is never stale; a dataset id
+ // that no longer resolves to a usable dataset is.
+ const isStale = !label && staleDatasetIds.has(id);
return (
- <div className={styles.nodeText} key={id}>
+ <div
+ className={classNames(styles.nodeText, {
+ 'border border-state-error !bg-state-error-5': isStale,
+ })}
+ key={id}
+ title={isStale ? t('chat.datasetUnavailable') : undefined}
+ >
<div className="flex items-center gap-1.5">
- <RAGFlowAvatar
- className="size-6 rounded-lg"
- avatar={item?.avatar}
- name={item ? item?.name : id}
- />
+ {isStale ? (
+ <TriangleAlert className="size-4 shrink-0 text-state-error" />
+ ) : (
+ <RAGFlowAvatar
+ className="size-6 rounded-lg"
+ avatar={item?.avatar}
+ name={item ? item?.name : id}
+ />
+ )}
- <div className={'truncate flex-1'}>{label || item?.name}</div>
+ <div className={'truncate flex-1'}>
+ {label || item?.name || id}
+ </div>
</div>
</div>
);
diff --git a/web/src/pages/agent/form/retrieval-form/next.tsx b/web/src/pages/agent/form/retrieval-form/next.tsx
index d8cb10269c..d46d5fa61e 100644
--- a/web/src/pages/agent/form/retrieval-form/next.tsx
+++ b/web/src/pages/agent/form/retrieval-form/next.tsx
@@ -21,6 +21,10 @@ import {
} from '@/components/ui/form';
import { Radio } from '@/components/ui/radio';
import { Textarea } from '@/components/ui/textarea';
+import {
+ useRevalidateStaleDatasetIds,
+ useStaleDatasetFormSchema,
+} from '@/hooks/use-stale-dataset-validation';
import { zodResolver } from '@hookform/resolvers/zod';
import { memo, useMemo } from 'react';
@@ -150,15 +154,23 @@ function RetrievalForm({ node }: INextOperatorForm) {
const defaultValues = useValues(node);
+ const { formSchema, datasetsFetched } = useStaleDatasetFormSchema(
+ FormSchema,
+ defaultValues?.dataset_ids,
+ );
+
const form = useForm({
defaultValues: defaultValues,
- resolver: zodResolver(FormSchema),
+ resolver: zodResolver(formSchema),
+ mode: 'onChange',
});
const hideKnowledgeGraphField = useHideKnowledgeGraphField(form);
useWatchFormChange(node?.id, form);
+ useRevalidateStaleDatasetIds(form, datasetsFetched);
+
return (
<Form {...form}>
<FormWrapper>
diff --git a/web/src/pages/agent/form/tool-form/retrieval-form/index.tsx b/web/src/pages/agent/form/tool-form/retrieval-form/index.tsx
index f77b7b77f7..17a9537463 100644
--- a/web/src/pages/agent/form/tool-form/retrieval-form/index.tsx
+++ b/web/src/pages/agent/form/tool-form/retrieval-form/index.tsx
@@ -7,6 +7,10 @@ import { SimilaritySliderFormField } from '@/components/similarity-slider';
import { TopNFormField } from '@/components/top-n-item';
import { Form } from '@/components/ui/form';
+import {
+ useRevalidateStaleDatasetIds,
+ useStaleDatasetFormSchema,
+} from '@/hooks/use-stale-dataset-validation';
import { zodResolver } from '@hookform/resolvers/zod';
import { t } from 'i18next';
@@ -32,15 +36,23 @@ export const FormSchema = z.object({
const RetrievalForm = () => {
const defaultValues = useValues();
+ const { formSchema, datasetsFetched } = useStaleDatasetFormSchema(
+ FormSchema,
+ defaultValues?.dataset_ids,
+ );
+
const form = useForm({
defaultValues: defaultValues,
- resolver: zodResolver(FormSchema),
+ resolver: zodResolver(formSchema),
+ mode: 'onChange',
});
const hideKnowledgeGraphField = useHideKnowledgeGraphField(form);
useWatchFormChange(form);
+ useRevalidateStaleDatasetIds(form, datasetsFetched);
+
const ownerTenantId = useOwnerTenantId();
return (
diff --git a/web/src/pages/agent/form/tool-form/use-values.ts b/web/src/pages/agent/form/tool-form/use-values.ts
index 6000b6c070..e9c531be41 100644
--- a/web/src/pages/agent/form/tool-form/use-values.ts
+++ b/web/src/pages/agent/form/tool-form/use-values.ts
@@ -24,7 +24,7 @@ export function useValues() {
const { initializeAgentToolValues } = useAgentToolInitialValues();
- const values = useMemo(() => {
+ const values = useMemo<Record<string, any>>(() => {
const agentNode = findUpstreamNodeById(clickedNodeId);
const tool = getAgentToolById(clickedToolId, agentNode!);
const formData = tool?.params;
diff --git a/web/src/pages/next-chats/chat/app-settings/chat-settings.tsx b/web/src/pages/next-chats/chat/app-settings/chat-settings.tsx
index b2f6c03d80..3b1dd9d9e7 100644
--- a/web/src/pages/next-chats/chat/app-settings/chat-settings.tsx
+++ b/web/src/pages/next-chats/chat/app-settings/chat-settings.tsx
@@ -4,8 +4,11 @@ import { ScrollArea } from '@/components/ui/scroll-area';
import { DatasetMetadata } from '@/constants/chat';
import { useSetModalState } from '@/hooks/common-hooks';
import { useFetchChat, useUpdateChat } from '@/hooks/use-chat-request';
-import { useStaleDatasetIds } from '@/hooks/use-knowledge-request';
import { useFindLlmByUuid } from '@/hooks/use-llm-request';
+import {
+ useRevalidateStaleDatasetIds,
+ useStaleDatasetFormSchema,
+} from '@/hooks/use-stale-dataset-validation';
import { cn } from '@/lib/utils';
import {
removeUselessFieldsFromValues,
@@ -15,7 +18,7 @@ import { zodResolver } from '@hookform/resolvers/zod';
import { isEmpty, omit } from 'lodash';
import { LucidePanelRightClose, LucideSettings } from 'lucide-react';
import { useEffect } from 'react';
-import { useForm, useWatch } from 'react-hook-form';
+import { useForm } from 'react-hook-form';
import { useTranslation } from 'react-i18next';
import { useParams } from 'react-router';
import { z } from 'zod';
@@ -30,14 +33,11 @@ type ChatSettingsProps = { hasSingleChatBox: boolean };
export function ChatSettings({ hasSingleChatBox }: ChatSettingsProps) {
const { data } = useFetchChat();
- // Only the persisted ids need validation: ids picked from the dataset
- // select are valid by construction, while a persisted id may reference a
- // dataset that has since been deleted or emptied of chunks.
- const { staleDatasetIds, settled: datasetsFetched } = useStaleDatasetIds(
+ const chatSettingSchema = useChatSettingSchema();
+ const { formSchema, datasetsFetched } = useStaleDatasetFormSchema(
+ chatSettingSchema,
data?.dataset_ids,
);
-
- const formSchema = useChatSettingSchema(staleDatasetIds);
const { updateChat, loading } = useUpdateChat();
const findLlmByUuid = useFindLlmByUuid();
const { id } = useParams();
@@ -155,19 +155,7 @@ export function ChatSettings({ hasSingleChatBox }: ChatSettingsProps) {
}
}, [data, form]);
- const datasetIds = useWatch({ control: form.control, name: 'dataset_ids' });
- const trigger = form.trigger;
-
- // A persisted dataset_ids value never fires onChange validation, so once
- // the lookup of those ids has settled, revalidate explicitly — it may
- // reference datasets that have since been deleted or emptied of chunks.
- useEffect(() => {
- if (!datasetsFetched || !datasetIds?.length) {
- return;
- }
-
- trigger('dataset_ids');
- }, [trigger, datasetsFetched, datasetIds.length]);
+ useRevalidateStaleDatasetIds(form, datasetsFetched);
return (
<>
diff --git a/web/src/pages/next-chats/chat/app-settings/use-chat-setting-schema.tsx b/web/src/pages/next-chats/chat/app-settings/use-chat-setting-schema.tsx
index 69d59187eb..cdfe5040bc 100644
--- a/web/src/pages/next-chats/chat/app-settings/use-chat-setting-schema.tsx
+++ b/web/src/pages/next-chats/chat/app-settings/use-chat-setting-schema.tsx
@@ -14,7 +14,7 @@ import { useTranslate } from '@/hooks/common-hooks';
import { z, ZodIssueCode } from 'zod';
import { chatPromptKbIssues } from './validate-chat-prompt';
-export function useChatSettingSchema(staleDatasetIds: Set<string>) {
+export function useChatSettingSchema() {
const { t } = useTranslate('chat');
const promptConfigSchema = z.object({
@@ -83,15 +83,5 @@ export function useChatSettingSchema(staleDatasetIds: Set<string>) {
}
});
- // A persisted dataset_ids value may reference datasets that have since been
- // deleted or emptied of chunks — those stale ids are flagged here.
- return formSchema.superRefine((data, ctx) => {
- if (data.dataset_ids.some((id) => staleDatasetIds.has(id))) {
- ctx.addIssue({
- path: ['dataset_ids'],
- message: t('datasetUnavailable'),
- code: z.ZodIssueCode.custom,
- });
- }
- });
+ return formSchema;
}
diff --git a/web/src/pages/next-search/search-setting.tsx b/web/src/pages/next-search/search-setting.tsx
index cc0daa4a96..0edb085398 100644
--- a/web/src/pages/next-search/search-setting.tsx
+++ b/web/src/pages/next-search/search-setting.tsx
@@ -20,10 +20,8 @@ import AvatarNameDescription from '@/components/avatar-name-description';
import { KnowledgeBaseFormField } from '@/components/knowledge-base-item';
import { LlmSettingFieldItems } from '@/components/llm-setting-items/next';
import { MetadataFilter } from '@/components/metadata-filter';
-import { ModelTreeSelect } from '@/components/model-tree-select';
import { SimilaritySliderFormField } from '@/components/similarity-slider';
import { Button } from '@/components/ui/button';
-import { SingleFormSlider } from '@/components/ui/dual-range-slider';
import {
Form,
FormControl,
@@ -32,11 +30,14 @@ import {
FormLabel,
FormMessage,
} from '@/components/ui/form';
-import { Input } from '@/components/ui/input';
import { MultiSelect } from '@/components/ui/multi-select';
import { Spin } from '@/components/ui/spin';
import { Switch } from '@/components/ui/switch';
import { useFetchKnowledgeMetadataKeys } from '@/hooks/use-knowledge-request';
+import {
+ useRevalidateStaleDatasetIds,
+ useStaleDatasetFormSchema,
+} from '@/hooks/use-stale-dataset-validation';
import { useFetchTenantInfo } from '@/hooks/use-user-setting-request';
import { cn } from '@/lib/utils';
import { zodResolver } from '@hookform/resolvers/zod';
@@ -74,10 +75,23 @@ function SearchSetting({
const { search_config } = data || {};
const { llm_setting } = search_config || {};
const { t } = useTranslation();
- const { formSchema, modelsFetched } = useSearchSettingFormSchema();
+ const { formSchema: searchSettingSchema, modelsFetched } =
+ useSearchSettingFormSchema();
+ const { formSchema, datasetsFetched } = useStaleDatasetFormSchema(
+ searchSettingSchema,
+ search_config?.kb_ids,
+ 'search_config.kb_ids',
+ );
const formMethods = useForm<SearchSettingFormData>({
resolver: zodResolver(formSchema),
+ mode: 'onChange',
});
+
+ useRevalidateStaleDatasetIds(
+ formMethods,
+ datasetsFetched,
+ 'search_config.kb_ids',
+ );
const descriptionDefaultValue = t('search.descriptionValue');
const resetForm = useCallback(() => {
formMethods.reset({