RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(embedding): omit unsupported user field for OVH AI endpoint (#19758)
Andrej Kratky709a91eb2fad
diff --git a/rag/llm/embedding_model.py b/rag/llm/embedding_model.pyindex 4efc832164..8ec8c6bf7f 100644--- a/rag/llm/embedding_model.py+++ b/rag/llm/embedding_model.py@@ -275,6 +275,8 @@ class OpenAIEmbed(Base):# is active. Local servers that reject unknown fields (LocalAI,# LM Studio, Xinference) use their own embed classes and omit it.kwargs = {"input": batch, "model": self.model_name, "encoding_format": "float", **openai_user_kwargs()}+ if urlparse(str(self.client.base_url)).hostname == "oai.endpoints.kepler.ai.cloud.ovh.net":+ kwargs.pop("user", None)extra_body = self._extra_body()if extra_body is not None:kwargs["extra_body"] = extra_bodydiff --git a/test/unit_test/rag/llm/test_ovh_embedding_user.py b/test/unit_test/rag/llm/test_ovh_embedding_user.pynew file mode 100644index 0000000000..aafddb7d07--- /dev/null+++ b/test/unit_test/rag/llm/test_ovh_embedding_user.py@@ -0,0 +1,86 @@+from types import SimpleNamespace+import unittest+from unittest.mock import Mock, patch++from common.llm_request_context import reset_llm_request_context, set_llm_request_context+from rag.llm.embedding_model import OpenAIEmbed, OpenAI_APIEmbed+++class OvhEmbeddingUserTests(unittest.TestCase):+ def setUp(self):+ self.context = set_llm_request_context(session_id="test-session")+ self.embed = object.__new__(OpenAIEmbed)+ self.embed.model_name = "BGE-M3"+ response = SimpleNamespace(+ data=[SimpleNamespace(index=1, embedding=[2.0]), SimpleNamespace(index=0, embedding=[1.0])],+ usage=SimpleNamespace(total_tokens=7),+ )+ self.create = Mock(return_value=response)+ self.embed.client = SimpleNamespace(+ base_url="https://oai.endpoints.kepler.ai.cloud.ovh.net/v1",+ embeddings=SimpleNamespace(create=self.create),+ )++ def tearDown(self):+ reset_llm_request_context(self.context)++ def test_ovh_omits_user_and_preserves_payload_and_result(self):+ vectors, tokens = self.embed._call(["first", "second"])+ self.assertEqual(+ self.create.call_args.kwargs,+ {+ "input": ["first", "second"],+ "model": "BGE-M3",+ "encoding_format": "float",+ },+ )+ self.assertEqual(vectors, [[1.0], [2.0]])+ self.assertEqual(tokens, 7)++ def test_compatible_provider_inherits_ovh_filter(self):+ with patch("rag.llm.embedding_model.OpenAI", return_value=self.embed.client):+ provider = OpenAI_APIEmbed("test-key", "BGE-M3", self.embed.client.base_url)+ provider._call(["query"])+ self.assertNotIn("user", self.create.call_args.kwargs)+ self.assertEqual(self.create.call_args.kwargs["model"], "BGE-M3")++ def test_ovh_hostname_case_port_and_trailing_slash(self):+ self.embed.client.base_url = "https://OAI.ENDPOINTS.KEPLER.AI.CLOUD.OVH.NET:443/v1/"+ self.embed._call(["query"])+ self.assertNotIn("user", self.create.call_args.kwargs)++ def test_other_hosts_keep_context_user(self):+ for url in (+ "https://api.openai.com/v1",+ "https://example.test/v1?host=oai.endpoints.kepler.ai.cloud.ovh.net",+ "https://oai.endpoints.kepler.ai.cloud.ovh.net.example.test/v1",+ ):+ with self.subTest(url=url):+ self.embed.client.base_url = url+ self.embed._call(["query"])+ self.assertEqual(self.create.call_args.kwargs["user"], "test-session")++ def test_extra_body_is_preserved(self):+ self.embed._extra_body = lambda: {"custom": True}+ self.embed._call(["query"])+ self.assertEqual(self.create.call_args.kwargs["extra_body"], {"custom": True})+ self.assertNotIn("user", self.create.call_args.kwargs)++ def test_provider_errors_propagate_without_retry(self):+ self.create.side_effect = RuntimeError("provider error")+ with self.assertRaisesRegex(RuntimeError, "provider error"):+ self.embed._call(["query"])+ self.assertEqual(self.create.call_count, 1)++ def test_no_context_does_not_add_user(self):+ token = set_llm_request_context()+ try:+ self.embed.client.base_url = "https://api.openai.com/v1"+ self.embed._call(["query"])+ self.assertNotIn("user", self.create.call_args.kwargs)+ finally:+ reset_llm_request_context(token)+++if __name__ == "__main__":+ unittest.main()