RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(agent): reject missing models before save and run (#19761)
Sbaaoui Idriss7297f524dd6a
diff --git a/internal/service/agent.go b/internal/service/agent.goindex a4874c953a..b704ae71c5 100644--- a/internal/service/agent.go+++ b/internal/service/agent.go@@ -1165,6 +1165,9 @@ func (s *AgentService) UpdateAgent(ctx context.Context, userID, canvasID string,if err := component.ValidateDynamicEntries(dslMap); err != nil {return fmt.Errorf("update agent %s: %w", canvasID, err)}+ if err := validateAgentChatModels(ctx, userID, dslMap); err != nil {+ return err+ }updates["dsl"] = entity.JSONMap(dslpkg.NormalizeForCanvas(dslMap))}@@ -1713,6 +1716,9 @@ func (s *AgentService) RunAgent(ctx context.Context, userID, canvasID, sessionIDdsl = dslpkg.NormalizeForRun(session.DSL)}}+ if err := validateAgentChatModels(ctx, userID, dsl); err != nil {+ return nil, err+ }// A handler may allocate the session id before calling RunAgent so the// effective id is available even when the run emits no events. Treat an// absent conversation row as a first touch regardless of who generated the@@ -1859,6 +1865,33 @@ func (s *AgentService) RunAgent(ctx context.Context, userID, canvasID, sessionIDreturn out, nil}+// validateAgentChatModels rejects stale Agent model references before saving or+// execution. Agent components always invoke a chat model; model-free canvases+// contain no Agent component and pass through.+func validateAgentChatModels(ctx context.Context, userID string, dsl map[string]any) error {+ c, err := canvas.DecodeFromDSL(dsl)+ if err != nil {+ return nil+ }+ resolver := NewModelProviderService()+ for _, node := range c.Components {+ if !strings.EqualFold(node.Obj.ComponentName, "Agent") {+ continue+ }+ modelRef, ok := node.Obj.Params["model_id"].(string)+ if !ok {+ modelRef, _ = node.Obj.Params["llm_id"].(string)+ }+ if _, _, _, _, err := resolver.ResolveModelConfig(ctx, userID, entity.ModelTypeChat, modelRef); err != nil {+ if errors.Is(err, errModelConfigUnavailable) || errors.Is(err, gorm.ErrRecordNotFound) {+ return errors.New("The configured chat model is missing or unavailable. Please select a valid model.")+ }+ return fmt.Errorf("validate Agent chat model: %w: %w", err, ErrAgentStorageError)+ }+ }+ return nil+}+// buildRunFunc assembles the per-run RunFunc the orchestrator (canvas.Runner)// drives.//diff --git a/internal/service/agent_sessions.go b/internal/service/agent_sessions.goindex b56f4c4d1f..da13aef485 100644--- a/internal/service/agent_sessions.go+++ b/internal/service/agent_sessions.go@@ -756,6 +756,12 @@ func (s *AgentService) CreateAgentSession(ctx context.Context, req *CreateAgentS}dsl = canvas.DSL}+ if err := validateAgentChatModels(ctx, req.UserID, dsl); err != nil {+ if errors.Is(err, ErrAgentStorageError) {+ return nil, common.CodeServerError, errors.New("Internal storage error while accessing the agent.")+ }+ return nil, common.CodeDataError, err+ }name := strings.TrimSpace(req.Name)if name == "" {diff --git a/web/src/hooks/use-agent-request.ts b/web/src/hooks/use-agent-request.tsindex 212814ce8b..6074d0d991 100644--- a/web/src/hooks/use-agent-request.ts+++ b/web/src/hooks/use-agent-request.ts@@ -1211,9 +1211,10 @@ export function useCreateAgentSession() {queryClient.invalidateQueries({queryKey: [AgentApiAction.FetchSessionsByCanvasId],});+ return data.data;}- return data?.data ?? {};+ throw new Error(data.message);},});diff --git a/web/src/pages/agent/explore/hooks/use-send-session-message.ts b/web/src/pages/agent/explore/hooks/use-send-session-message.tsindex e8f0d710e2..6198f4d844 100644--- a/web/src/pages/agent/explore/hooks/use-send-session-message.ts+++ b/web/src/pages/agent/explore/hooks/use-send-session-message.ts@@ -1,4 +1,3 @@-import sonnerMessage from '@/components/ui/message';import { useSetModalState } from '@/hooks/common-hooks';import {useCreateAgentSession,@@ -116,7 +115,6 @@ export const useSendSessionMessage = () => {}, 100);} catch (error) {isCreatingSession.current = false;- sonnerMessage.error('Failed to create session');console.error('Failed to create session:', error);return;}diff --git a/web/src/pages/agent/index.tsx b/web/src/pages/agent/index.tsxindex bb2d5e4f38..fa9f0f2e5e 100644--- a/web/src/pages/agent/index.tsx+++ b/web/src/pages/agent/index.tsx@@ -53,7 +53,6 @@ import { useCancelCurrentDataflow } from './hooks/use-cancel-dataflow';import { useHandleExportJsonFile } from './hooks/use-export-json';import { useFetchDataOnMount } from './hooks/use-fetch-data';import { useFetchPipelineLog } from './hooks/use-fetch-pipeline-log';-import { useGetBeginNodeDataInputs } from './hooks/use-get-begin-query';import { useIsPipeline } from './hooks/use-is-pipeline';import {useIsConversationMode,@@ -124,15 +123,7 @@ export default function Agent() {const { flowDetail: agentDetail } = useFetchDataOnMount();const { buildDslData } = useBuildDslData();const { setAgent, loading: savingWidgetSettings } = useSetAgent(false);- const inputs = useGetBeginNodeDataInputs();const { handleRun } = useSaveGraphBeforeOpeningDebugDrawer(showChatDrawer);- const handleRunAgent = useCallback(() => {- if (inputs.length > 0) {- showChatDrawer();- } else {- handleRun();- }- }, [handleRun, inputs, showChatDrawer]);const {visible: versionDialogVisible,hideModal: hideVersionDialog,@@ -219,17 +210,16 @@ export default function Agent() {stopFetchTrace,});- const handleButtonRunClick = useCallback(() => {+ const handleButtonRunClick = useCallback(async () => {if (isWebhookMode) {- saveGraph();- showWebhookTestSheet();+ if ((await saveGraph())?.code === 0) showWebhookTestSheet();} else if (isPipeline) {handleRunPipeline();} else {- handleRunAgent();+ handleRun();}}, [- handleRunAgent,+ handleRun,handleRunPipeline,isPipeline,isWebhookMode,diff --git a/web/src/pages/agent/utils.test.ts b/web/src/pages/agent/utils.test.tsindex 6b23384dff..7805896dbb 100644--- a/web/src/pages/agent/utils.test.ts+++ b/web/src/pages/agent/utils.test.ts@@ -4,6 +4,7 @@ import {generateNodeNamesWithIncreasingIndex,getEmptyMessageNodeNames,isEmptyMessageContent,+ receiveMessageError,transformTokenChunkerParams,} from './utils';@@ -52,6 +53,25 @@ describe('transformTokenChunkerParams', () => {});});+describe('receiveMessageError', () => {+ it('accepts successful SSE events without an application code', () => {+ expect(+ receiveMessageError({+ response: { status: 200 },+ data: { event: 'workflow_finished' },+ }),+ ).toBe(false);+ });+ it('rejects application errors returned with HTTP 200', () => {+ expect(+ receiveMessageError({ response: { status: 200 }, data: { code: 102 } }),+ ).toBe(true);+ expect(+ receiveMessageError({ response: { status: 200 }, data: { code: 0 } }),+ ).toBe(false);+ });+});+describe('Message component content validation', () => {describe('isEmptyMessageContent', () => {it('treats missing, non-array and blank-only content as empty', () => {diff --git a/web/src/pages/agent/utils.ts b/web/src/pages/agent/utils.tsindex 18b8b1b4e8..4fce126df6 100644--- a/web/src/pages/agent/utils.ts+++ b/web/src/pages/agent/utils.ts@@ -740,7 +740,9 @@ export const buildDslGlobalVariables = (// TODO: This is caused by `useSendMessageBySSE`; it is recommended to sort out the logic.export const receiveMessageError = (res: any) =>- res && res?.response.status !== 200;+ res &&+ (res?.response.status !== 200 ||+ (typeof res?.data?.code === 'number' && res.data.code !== 0));// Replace the id in the object with textexport const replaceIdWithText = (