Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(web): bound port and max records in the Execute SQL form (#19072)

chanx834043202897
diff --git a/web/src/pages/agent/form/exesql-form/index.tsx b/web/src/pages/agent/form/exesql-form/index.tsx
index b68a31fb8f..47b4abb448 100644
--- a/web/src/pages/agent/form/exesql-form/index.tsx
+++ b/web/src/pages/agent/form/exesql-form/index.tsx
@@ -26,7 +26,14 @@ import { buildOutputList } from '../../utils/build-output-list';
import { FormWrapper } from '../components/form-wrapper';
import { Output } from '../components/output';
import { PromptEditor } from '../components/prompt-editor';
-import { FormSchema, useSubmitForm } from './use-submit-form';
+import {
+ FormSchema,
+ MaxMaxRecords,
+ MaxPort,
+ MinMaxRecords,
+ MinPort,
+ useSubmitForm,
+} from './use-submit-form';
const outputList = buildOutputList(initialExeSqlValues.outputs);
@@ -98,7 +105,13 @@ export function ExeSQLFormWidgets({ loading }: { loading: boolean }) {
<FormItem>
<FormLabel>{t('port')}</FormLabel>
<FormControl>
- <NumberInput {...field} className="w-full"></NumberInput>
+ <NumberInput
+ {...field}
+ min={MinPort}
+ max={MaxPort}
+ integer
+ className="w-full"
+ ></NumberInput>
</FormControl>
<FormMessage />
</FormItem>
@@ -125,7 +138,13 @@ export function ExeSQLFormWidgets({ loading }: { loading: boolean }) {
<FormItem>
<FormLabel>{t('maxRecords')}</FormLabel>
<FormControl>
- <NumberInput {...field} className="w-full"></NumberInput>
+ <NumberInput
+ {...field}
+ min={MinMaxRecords}
+ max={MaxMaxRecords}
+ integer
+ className="w-full"
+ ></NumberInput>
</FormControl>
<FormMessage />
</FormItem>
diff --git a/web/src/pages/agent/form/exesql-form/use-submit-form.ts b/web/src/pages/agent/form/exesql-form/use-submit-form.ts
index b7141a2cf9..a52d9cc43e 100644
--- a/web/src/pages/agent/form/exesql-form/use-submit-form.ts
+++ b/web/src/pages/agent/form/exesql-form/use-submit-form.ts
@@ -2,14 +2,24 @@ import { useTestDbConnect } from '@/hooks/use-agent-request';
import { useCallback } from 'react';
import { z } from 'zod';
+// The backend only checks for a positive integer, so an unbounded value lets a
+// single query pull an entire table into memory. Cap it an order of magnitude
+// above the 1024 default.
+export const MinMaxRecords = 1;
+export const MaxMaxRecords = 10000;
+
+// TCP port range.
+export const MinPort = 1;
+export const MaxPort = 65535;
+
export const ExeSQLFormSchema = {
db_type: z.string().min(1),
database: z.string().min(1),
username: z.string().min(1),
host: z.string().min(1),
- port: z.number(),
+ port: z.number().int().min(MinPort).max(MaxPort),
password: z.string().optional().or(z.literal('')),
- max_records: z.number(),
+ max_records: z.number().int().min(MinMaxRecords).max(MaxMaxRecords),
};
export const FormSchema = z