RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
fix(router): accept share (beta) token on agent upload and attachment download (#18681)
euvre89687504b731
diff --git a/internal/router/agent_routes.go b/internal/router/agent_routes.goindex 2538b5b3b3..ee43320f34 100644--- a/internal/router/agent_routes.go+++ b/internal/router/agent_routes.go@@ -57,9 +57,7 @@ func RegisterAgentRoutes(g *gin.RouterGroup, h *handler.AgentHandler) {// File operations.g.GET("/download", h.DownloadAgentFile)- g.GET("/attachments/:attachment_id/download", h.DownloadAttachment)g.GET("/attachments/:attachment_id/preview", h.PreviewAttachment)- g.POST("/:canvas_id/upload", h.UploadAgentFile)// Component introspection + debug.g.GET("/:canvas_id/components/:component_id/input-form", h.GetComponentInputForm)diff --git a/internal/router/agent_routes_test.go b/internal/router/agent_routes_test.goindex 2be990d5b8..7af24df403 100644--- a/internal/router/agent_routes_test.go+++ b/internal/router/agent_routes_test.go@@ -17,12 +17,15 @@package routerimport (+ "context"+ "encoding/json""net/http""net/http/httptest""testing""github.com/gin-gonic/gin"+ "ragflow/internal/common""ragflow/internal/handler")@@ -89,3 +92,62 @@ func TestAgentSessionCancelRouteRegistered(t *testing.T) {t.Fatal("POST /api/v1/tasks/:session_id/cancel was not registered")}}++// TestAgentUploadAndAttachmentDownloadOnBetaAuth pins the auth wiring of+// the agent file upload and attachment-download routes: the embedded+// agent page holds only a share (beta) token, so both must sit on the+// beta-auth group. Unauthenticated, its middleware answers HTTP 200 ++// code 102 instead of the bare 401 the JWT-only AuthMiddleware would+// return, which is what bounced the embedded page to /login.+func TestAgentUploadAndAttachmentDownloadOnBetaAuth(t *testing.T) {+ gin.SetMode(gin.TestMode)++ engine := gin.New()+ r := &Router{+ authHandler: handler.NewAuthHandler(),+ agentHandler: &handler.AgentHandler{},+ }+ r.Setup(engine)++ cases := []struct {+ name string+ method string+ path string+ }{+ {"agent file upload", http.MethodPost, "/api/v1/agents/canvas-1/upload"},+ {"agent attachment download", http.MethodGet, "/api/v1/agents/attachments/att-1/download"},+ }+ for _, tt := range cases {+ t.Run(tt.name, func(t *testing.T) {+ resp := httptest.NewRecorder()+ req := httptest.NewRequestWithContext(context.Background(), tt.method, tt.path, nil)+ engine.ServeHTTP(resp, req)++ if resp.Code == http.StatusNotFound {+ t.Fatalf("%s %s returned 404; route is not registered", tt.method, tt.path)+ }+ var body struct {+ Code common.ErrorCode `json:"code"`+ }+ if err := json.Unmarshal(resp.Body.Bytes(), &body); err != nil {+ t.Fatalf("failed to decode response body: %v", err)+ }+ if resp.Code != http.StatusOK || body.Code != common.CodeDataError {+ t.Fatalf("status=%d body=%s; want beta auth middleware to handle the route (HTTP 200 + code %d)", resp.Code, resp.Body.String(), common.CodeDataError)+ }+ })+ }++ t.Run("agent attachment preview stays JWT-only", func(t *testing.T) {+ resp := httptest.NewRecorder()+ req := httptest.NewRequestWithContext(context.Background(), http.MethodGet, "/api/v1/agents/attachments/att-1/preview", nil)+ engine.ServeHTTP(resp, req)++ if resp.Code == http.StatusNotFound {+ t.Fatal("GET /api/v1/agents/attachments/:attachment_id/preview was not registered")+ }+ if resp.Code != http.StatusUnauthorized {+ t.Fatalf("status=%d body=%s; want the JWT-only AuthMiddleware to keep guarding the preview route", resp.Code, resp.Body.String())+ }+ })+}diff --git a/internal/router/router.go b/internal/router/router.goindex 55752573f3..14d96e4cf4 100644--- a/internal/router/router.go+++ b/internal/router/router.go@@ -222,6 +222,9 @@ func (r *Router) Setup(engine *gin.Engine) {apiBetaAuth.GET("/documents/images/:image_id", r.documentHandler.GetDocumentImage)apiBetaAuth.GET("/thumbnails", r.documentHandler.GetThumbnail)+ apiBetaAuth.POST("/agents/:canvas_id/upload", r.agentHandler.UploadAgentFile)+ apiBetaAuth.GET("/agents/attachments/:attachment_id/download", r.agentHandler.DownloadAttachment)+// MCP server endpoint — exposes RAGFlow capabilities as MCP tools.// Uses BetaAuthMiddleware to resolve the user from the// Authorization header.