RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.
Go agent-harnessagent-native-databaseagentic-aiagentic-retrievalagentic-searchaiai-agentscontext-enginecontext-engineeringcontext-managementharness-engineeringknowledge-compilationragretrieval-augmented-generationretrieval-harnesssearch-harness
refactor(workflow): preserve completed parallel results (#20391)
Sbaaoui Idriss8ffecc8d926e
diff --git a/internal/agent/workflowx/parallel.go b/internal/agent/workflowx/parallel.goindex 500053c8cd..8b9a5c2dc5 100644--- a/internal/agent/workflowx/parallel.go+++ b/internal/agent/workflowx/parallel.go@@ -350,6 +350,7 @@ func runParallelInvoke[I, O any](bridgeState := defaultBridgeoutputs := make([]O, totalCount)+ completedResults := make(map[int]any)if isResume && prev != nil {totalCount = prev.TotalCount@@ -370,6 +371,7 @@ func runParallelInvoke[I, O any](return nil, fmt.Errorf("%w: cannot coerce completed result at index %d (type %T) to target type", ErrParallelResumeStateInvalid, idx, v)}outputs[idx] = typed+ completedResults[idx] = typed}// Only re-invoke the previously-interrupted indices.indicesToProcess = append([]int(nil), prev.InterruptedIndices...)@@ -384,7 +386,6 @@ func runParallelInvoke[I, O any](// Drain the result channel, categorising each entry.var normalErr errorvar interruptErrs []error- completedResults := make(map[int]any)for r := range results {if r.err == nil {if r.index >= 0 && r.index < len(outputs) {diff --git a/internal/agent/workflowx/parallel_integration_test.go b/internal/agent/workflowx/parallel_integration_test.goindex be35f46193..201a317740 100644--- a/internal/agent/workflowx/parallel_integration_test.go+++ b/internal/agent/workflowx/parallel_integration_test.go@@ -25,6 +25,7 @@ package workflowximport ("context"+ "encoding/json""errors""strings""sync"@@ -191,6 +192,67 @@ func TestIntegration_InvokeResume_ReplaysOnlyNonCompletedIndices(t *testing.T) {}}+func TestIntegration_InvokeResume_PreservesCompletedResultsAcrossInterrupts(t *testing.T) {+ ctx := t.Context()+ first, err := encodeParallelState(ParallelInterruptState{+ OriginalInputsJSON: []byte(`[0,1]`),+ CompletedResults: map[int]any{0: 10},+ InterruptedIndices: []int{1},+ TotalCount: 2,+ })+ if err != nil {+ t.Fatalf("encode first interrupt: %v", err)+ }+ var calls [2]atomic.Int32+ interruptAgain := true+ runner := testCountingRunnable{fn: func(ctx context.Context, in int, _ ...compose.Option) (int, error) {+ calls[in].Add(1)+ if in == 1 && interruptAgain {+ return 0, compose.StatefulInterrupt(ctx, "second pause", in)+ }+ return in + 10, nil+ }}+ opts := getParallelOptions([]ParallelOption{WithParallelMaxConcurrency(0), WithParallelEnableSubCheckpoint(false)})+ _, err = runParallelInvoke(injectResumeState(ctx, first), "par", runner, []int{0, 1}, opts, newParallelBridgeState(nil))+ if err == nil {+ t.Fatal("first resume: expected second interrupt")+ }+ encodedSignal, err := json.Marshal(err)+ if err != nil {+ t.Fatalf("marshal composite interrupt: %v", err)+ }+ var signal struct{ State []byte }+ if err := json.Unmarshal(encodedSignal, &signal); err != nil {+ t.Fatalf("decode composite interrupt: %v", err)+ }+ var second ParallelInterruptState+ if err := json.Unmarshal(signal.State, &second); err != nil {+ t.Fatalf("decode second checkpoint: %v", err)+ }+ if got := second.CompletedResults[0]; got != float64(10) {+ t.Errorf("completed item 0 missing from second checkpoint: got %v", got)+ }+ if len(second.InterruptedIndices) != 1 || second.InterruptedIndices[0] != 1 {+ t.Errorf("second checkpoint pending indices = %v, want [1]", second.InterruptedIndices)+ }++ interruptAgain = false+ out, err := runParallelInvoke(injectResumeState(ctx, signal.State), "par", runner, []int{0, 1}, opts, newParallelBridgeState(nil))+ if err != nil {+ t.Fatalf("second resume: %v", err)+ }+ for i, want := range []int{10, 11} {+ if out[i] != want {+ t.Errorf("out[%d] = %d, want %d", i, out[i], want)+ }+ }+ for i, want := range []int32{0, 2} {+ if got := calls[i].Load(); got != want {+ t.Errorf("item %d invoked %d times, want %d", i, got, want)+ }+ }+}+// TestIntegration_StableCheckpointID_AcrossResumes asserts// the P0 "Stable child checkpoint ID reuse" requirement: the// per-item checkpoint ID is the same across the first run