Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

Upon entering a wiki, the top-right corner indicates that modifications have been made, even though no changes were actually performed. (#19482)

balibabua4b9fb55dff1
diff --git a/web/src/components/markdown-editor.tsx b/web/src/components/markdown-editor.tsx
index ea02a7218a..76ca65ed92 100644
--- a/web/src/components/markdown-editor.tsx
+++ b/web/src/components/markdown-editor.tsx
@@ -18,12 +18,13 @@ import { useCallback, useEffect, useRef, useState } from 'react';
import LexicalEditor from '@/lib/editor/lexical-editor';
import RawMarkdownEditor from '@/lib/editor/raw-markdown-editor';
+import type { WikiPageType } from '@/utils/wiki-link-util';
interface MarkdownEditorProps {
content: string;
onChange?: (content: string) => void;
readOnly?: boolean;
- onWikiLinkClick?: (pageType: 'concept' | 'entity', slug: string) => void;
+ onWikiLinkClick?: (pageType: WikiPageType, slug: string) => void;
}
export default function MarkdownEditor({
@@ -40,6 +41,9 @@ export default function MarkdownEditor({
if (content === contentRef.current) {
return;
}
+ // External content change (e.g. page switch): keep the ref in sync so
+ // toggleSource picks up the new content.
+ contentRef.current = content;
if (showSource) setRawContent(content);
}, [showSource, content]);
diff --git a/web/src/lib/editor/lexical-editor.tsx b/web/src/lib/editor/lexical-editor.tsx
index 1914f6793e..dc4317ab95 100644
--- a/web/src/lib/editor/lexical-editor.tsx
+++ b/web/src/lib/editor/lexical-editor.tsx
@@ -20,6 +20,8 @@ import { $createParagraphNode, $getRoot } from 'lexical';
import type { JSX } from 'react';
import { useEffect, useMemo, useRef } from 'react';
+import type { WikiPageType } from '@/utils/wiki-link-util';
+
import ContentEditable from './content-editable';
import theme from './editor-theme';
import {
@@ -33,6 +35,10 @@ import nodes from './nodes';
// Direct CSS import (more reliable than @import in App.css)
import './editor-theme.css';
+// Updates that import externally-provided content carry this tag so
+// ChangeListener can skip them — onChange should only fire for user edits.
+const ExternalContentSyncTag = 'external-content-sync';
+
interface Props {
content: string;
onChange?: (markdown: string) => void;
@@ -40,7 +46,7 @@ interface Props {
placeholder?: string;
onToggleSource?: () => void;
showSource?: boolean;
- onWikiLinkClick?: (pageType: 'concept' | 'entity', slug: string) => void;
+ onWikiLinkClick?: (pageType: WikiPageType, slug: string) => void;
}
function InitialContentPlugin({
@@ -58,15 +64,18 @@ function InitialContentPlugin({
if (seeded.current) return;
seeded.current = true;
- editor.update(() => {
- const root = $getRoot();
- root.clear();
- if (content && content.trim()) {
- $convertFromEnhancedMarkdownString(content, transformers);
- } else {
- root.append($createParagraphNode());
- }
- });
+ editor.update(
+ () => {
+ const root = $getRoot();
+ root.clear();
+ if (content && content.trim()) {
+ $convertFromEnhancedMarkdownString(content, transformers);
+ } else {
+ root.append($createParagraphNode());
+ }
+ },
+ { tag: ExternalContentSyncTag },
+ );
// oxlint-disable-next-line react/exhaustive-deps
}, [editor]);
@@ -83,18 +92,21 @@ function ContentSyncPlugin({
const [editor] = useLexicalComposerContext();
useEffect(() => {
- editor.update(() => {
- const currentMarkdown = $convertToEnhancedMarkdownString(transformers);
- if (currentMarkdown === content) return;
-
- const root = $getRoot();
- root.clear();
- if (content && content.trim()) {
- $convertFromEnhancedMarkdownString(content, transformers);
- } else {
- root.append($createParagraphNode());
- }
- });
+ editor.update(
+ () => {
+ const currentMarkdown = $convertToEnhancedMarkdownString(transformers);
+ if (currentMarkdown === content) return;
+
+ const root = $getRoot();
+ root.clear();
+ if (content && content.trim()) {
+ $convertFromEnhancedMarkdownString(content, transformers);
+ } else {
+ root.append($createParagraphNode());
+ }
+ },
+ { tag: ExternalContentSyncTag },
+ );
}, [content, editor, transformers]);
return null;
@@ -108,16 +120,12 @@ function ChangeListener({
transformers: Transformer[];
}) {
const [editor] = useLexicalComposerContext();
- const initRef = useRef(false);
useEffect(() => {
if (!onChange) return;
const removeListener = editor.registerUpdateListener(
- ({ dirtyElements, dirtyLeaves }) => {
- if (!initRef.current) {
- initRef.current = true;
- return;
- }
+ ({ dirtyElements, dirtyLeaves, tags }) => {
+ if (tags.has(ExternalContentSyncTag)) return;
if (dirtyElements.size === 0 && dirtyLeaves.size === 0) return;
const markdown = editor.read(() =>
$convertToEnhancedMarkdownString(transformers),
diff --git a/web/src/lib/editor/plugins/wiki-link-click-plugin.tsx b/web/src/lib/editor/plugins/wiki-link-click-plugin.tsx
index 2bccc810a1..60be844a34 100644
--- a/web/src/lib/editor/plugins/wiki-link-click-plugin.tsx
+++ b/web/src/lib/editor/plugins/wiki-link-click-plugin.tsx
@@ -1,8 +1,5 @@
import { useLexicalComposerContext } from '@lexical/react/LexicalComposerContext';
-import {
- parseWikiLinkHref,
- type WikiPageType,
-} from '@/pages/dataset/compilation/utils/parse-wiki-link';
+import { parseWikiLinkHref, type WikiPageType } from '@/utils/wiki-link-util';
import { useEffect } from 'react';
type WikiLinkClickPluginProps = {
diff --git a/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts b/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts
index 3f79098f00..8d93cdb7a9 100644
--- a/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts
+++ b/web/src/pages/dataset/compilation/hooks/use-wiki-detail-content.ts
@@ -6,9 +6,9 @@ import {
import { Docagg } from '@/interfaces/database/chat';
import { IArtifact, IWikiCommit } from '@/interfaces/database/dataset';
import { downloadMarkdownFile } from '@/utils/file-util';
+import type { WikiPageType } from '@/utils/wiki-link-util';
import { useCallback, useEffect, useMemo } from 'react';
-import type { WikiPageType } from '../utils/parse-wiki-link';
import { useCommitArtifact } from './use-commit-artifact';
import { useWikiEditor } from './use-wiki-editor';
import { useWikiLinkNavigation } from './use-wiki-link-navigation';
diff --git a/web/src/pages/dataset/compilation/wiki-detail-editor-panel.tsx b/web/src/pages/dataset/compilation/wiki-detail-editor-panel.tsx
index 539c243482..7a688f2c37 100644
--- a/web/src/pages/dataset/compilation/wiki-detail-editor-panel.tsx
+++ b/web/src/pages/dataset/compilation/wiki-detail-editor-panel.tsx
@@ -10,8 +10,8 @@ import {
import { Spin } from '@/components/ui/spin';
import type { Docagg } from '@/interfaces/database/chat';
import type { IWikiCommitDetail } from '@/interfaces/database/dataset';
+import type { WikiPageType } from '@/utils/wiki-link-util';
-import type { WikiPageType } from './utils/parse-wiki-link';
import { WikiVersionDiffPanel } from './wiki-version-diff-panel';
type WikiDetailEditorPanelProps = {
diff --git a/web/src/pages/dataset/compilation/wiki-left-panel/hooks/use-wiki-navigation.ts b/web/src/pages/dataset/compilation/wiki-left-panel/hooks/use-wiki-navigation.ts
index de9a1a428a..781abea55a 100644
--- a/web/src/pages/dataset/compilation/wiki-left-panel/hooks/use-wiki-navigation.ts
+++ b/web/src/pages/dataset/compilation/wiki-left-panel/hooks/use-wiki-navigation.ts
@@ -6,8 +6,6 @@ import { IArtifactTopic } from '@/interfaces/database/dataset';
import { useDebounce } from 'ahooks';
import { useCallback, useMemo, useRef, useState } from 'react';
-export type WikiPageType = 'concept' | 'entity' | 'topic';
-
const normalizeTopicPath = (topic: string) =>
topic
.split('/')
diff --git a/web/src/pages/dataset/compilation/utils/parse-wiki-link.test.ts b/web/src/utils/wiki-link-util.test.ts
similarity index 89%
rename from web/src/pages/dataset/compilation/utils/parse-wiki-link.test.ts
rename to web/src/utils/wiki-link-util.test.ts
index f20ae98347..77bc8c39dd 100644
--- a/web/src/pages/dataset/compilation/utils/parse-wiki-link.test.ts
+++ b/web/src/utils/wiki-link-util.test.ts
@@ -1,4 +1,4 @@
-import { parseWikiLinkHref } from './parse-wiki-link';
+import { parseWikiLinkHref } from './wiki-link-util';
describe('parseWikiLinkHref', () => {
it('preserves nested typed slugs in artifact links', () => {
diff --git a/web/src/pages/dataset/compilation/utils/parse-wiki-link.ts b/web/src/utils/wiki-link-util.ts
similarity index 100%
rename from web/src/pages/dataset/compilation/utils/parse-wiki-link.ts
rename to web/src/utils/wiki-link-util.ts