Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

Fix: Allow deletion of selected tags in the extractor operator form. (#19097)

balibabub4855c16a586
diff --git a/web/src/components/ui/async-tree-select.tsx b/web/src/components/ui/async-tree-select.tsx
index 4bb40091ec..97d3b0a7a7 100644
--- a/web/src/components/ui/async-tree-select.tsx
+++ b/web/src/components/ui/async-tree-select.tsx
@@ -5,7 +5,7 @@ import {
} from '@/components/ui/popover';
import { cn } from '@/lib/utils';
import { isEmpty } from 'lodash';
-import { ChevronDown, ChevronRight, Loader2 } from 'lucide-react';
+import { ChevronDown, ChevronRight, Loader2, X } from 'lucide-react';
import { ReactNode, useCallback, useEffect, useMemo, useState } from 'react';
import { useTranslation } from 'react-i18next';
import { Button } from './button';
@@ -23,9 +23,13 @@ export type TreeNodeType = {
type AsyncTreeSelectProps = {
treeData: TreeNodeType[];
value?: TreeId;
+ // Cleared is reported as '' (same convention as SelectWithSearch), never
+ // undefined — RHF falls back to defaultValues when a field gets undefined.
onChange?(value: TreeId): void;
loadData?(node: TreeNodeType): Promise<any>;
canSelect?(node: TreeNodeType): boolean;
+ // When false, hides the clear button and disables re-click deselection.
+ allowClear?: boolean;
};
function getNodeText(node: ReactNode): string {
@@ -41,6 +45,7 @@ export function AsyncTreeSelect({
loadData,
onChange,
canSelect,
+ allowClear = true,
}: AsyncTreeSelectProps) {
const [open, setOpen] = useState(false);
const [searchText, setSearchText] = useState('');
@@ -53,6 +58,8 @@ export function AsyncTreeSelect({
return treeData.find((x) => x.id === value)?.title;
}, [treeData, value]);
+ const hasSelection = value !== undefined && value !== '';
+
const visibleNodeIds = useMemo(() => {
const trimmed = searchText.trim().toLowerCase();
if (!trimmed) {
@@ -138,11 +145,24 @@ export function AsyncTreeSelect({
await toggleNode(node);
return;
}
- onChange?.(node.id);
+ // Clicking the selected node again clears the selection.
+ if (value !== node.id) {
+ onChange?.(node.id);
+ } else if (allowClear) {
+ onChange?.('');
+ }
setOpen(false);
setSearchText('');
},
- [canSelect, onChange, toggleNode],
+ [allowClear, canSelect, onChange, toggleNode, value],
+ );
+
+ const handleClear = useCallback(
+ (e: React.MouseEvent<HTMLButtonElement>) => {
+ e.stopPropagation();
+ onChange?.('');
+ },
+ [onChange],
);
const handleArrowClick = useCallback(
@@ -236,7 +256,19 @@ export function AsyncTreeSelect({
{selectedTitle || (
<span className="text-slate-400">{t('common.pleaseSelect')}</span>
)}
- <ChevronDown className="size-5" />
+ <span className="flex items-center gap-1">
+ {allowClear && hasSelection && (
+ <Button
+ type="button"
+ variant="ghost"
+ className="size-5"
+ onClick={handleClear}
+ >
+ <X />
+ </Button>
+ )}
+ <ChevronDown className="size-5" />
+ </span>
</div>
</PopoverTrigger>
<PopoverContent className="p-1 min-w-[var(--radix-popover-trigger-width)]">
diff --git a/web/src/locales/zh.ts b/web/src/locales/zh.ts
index 2608d0783e..7069e2e95d 100644
--- a/web/src/locales/zh.ts
+++ b/web/src/locales/zh.ts
@@ -1991,7 +1991,7 @@ NER:使用 spaCy NER 和基于规则的关键词提取来抽取 Entities 和 R
compilationTitleSuffix: '的数据集',
llmWiki: 'Wiki',
skills: 'To Skills',
- navTree: 'PageIndex',
+ navTree: 'Tree/Page index',
graph: 'Graph',
structureMindmap: 'Mindmap',
structureTimeline: 'Timeline',
diff --git a/web/src/pages/agent/form/extractor-form/use-tag-file-tree.ts b/web/src/pages/agent/form/extractor-form/use-tag-file-tree.ts
index 8cc7896a9a..7e73564f5c 100644
--- a/web/src/pages/agent/form/extractor-form/use-tag-file-tree.ts
+++ b/web/src/pages/agent/form/extractor-form/use-tag-file-tree.ts
@@ -75,7 +75,12 @@ export function useTagFileTree(value?: string) {
`${value}/ancestors`,
);
const folders: IFile[] = data?.data?.parent_folders?.toReversed() ?? [];
- setTreeData((tree) => uniqBy(tree.concat(folders.map(toTreeNode)), 'id'));
+ // The root folder is its own parent (parent_id === id). Keeping it in
+ // the tree breaks AsyncTreeSelect's root detection (no node would count
+ // as top-level, so nothing renders), so drop it — its children then
+ // render as top-level nodes, same as a fresh listing.
+ const chain = folders.filter((x) => x.id !== x.parent_id);
+ setTreeData((tree) => uniqBy(tree.concat(chain.map(toTreeNode)), 'id'));
for (const folder of folders) {
const ret = await fetchList(folder.id);
if (ret.code === 0) {
diff --git a/web/src/pages/files/move-dialog.tsx b/web/src/pages/files/move-dialog.tsx
index c73b5c7613..da7af53911 100644
--- a/web/src/pages/files/move-dialog.tsx
+++ b/web/src/pages/files/move-dialog.tsx
@@ -23,7 +23,7 @@ export function MoveDialog({ hideModal, onOk, loading }: IModalProps<any>) {
const { fetchList } = useFetchPureFileList();
- const [treeValue, setTreeValue] = useState<number | string>('');
+ const [treeValue, setTreeValue] = useState<number | string>();
const [treeData, setTreeData] = useState([]);