Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(search): do not jump to previous search results on empty query (#18520)

euvrec22e53c96b55
diff --git a/web/src/pages/next-search/search-home.tsx b/web/src/pages/next-search/search-home.tsx
index 7c36e10f2a..e7600c4f5e 100644
--- a/web/src/pages/next-search/search-home.tsx
+++ b/web/src/pages/next-search/search-home.tsx
@@ -19,8 +19,9 @@ import message from '@/components/ui/message';
import { useAutoResizeTextarea } from '@/hooks/use-auto-resize-textarea';
import { IUserInfo } from '@/interfaces/database/user-setting';
import { cn } from '@/lib/utils';
+import { isEmpty, trim } from 'lodash';
import { Search } from 'lucide-react';
-import { Dispatch, SetStateAction, useRef } from 'react';
+import { Dispatch, SetStateAction, useCallback, useRef } from 'react';
import { useTranslation } from 'react-i18next';
import './index.less';
import { RAGFlowLogo } from './ragflow-logo';
@@ -48,6 +49,19 @@ export default function SearchHome({
const isMultiLine = useAutoResizeTextarea(searchInputRef, searchText);
+ const handleStartSearch = useCallback(() => {
+ if (canSearch === false) {
+ message.warning(t('search.chooseDataset'));
+ return;
+ }
+ // Do not enter the searching view with an empty question: it would render
+ // the previous search's stale results from the mutation cache.
+ if (isEmpty(trim(searchText))) {
+ return;
+ }
+ setIsSearching(!isSearching);
+ }, [canSearch, isSearching, searchText, setIsSearching, t]);
+
return (
<section className="relative w-full flex transition-all justify-center items-center mt-[15vh]">
<div className="relative z-10 px-8 pt-8 flex text-transparent flex-col justify-center items-center w-full max-w-[780px]">
@@ -85,11 +99,7 @@ export default function SearchHome({
!e.nativeEvent.isComposing
) {
e.preventDefault();
- if (canSearch === false) {
- message.warning(t('search.chooseDataset'));
- return;
- }
- setIsSearching(!isSearching);
+ handleStartSearch();
}
}}
onChange={(e) => {
@@ -106,13 +116,7 @@ export default function SearchHome({
'absolute right-3 flex size-9 items-center justify-center rounded-full bg-text-primary text-bg-base shadow transition-opacity hover:opacity-90',
isMultiLine ? 'bottom-3' : 'top-1/2 -translate-y-1/2',
)}
- onClick={() => {
- if (canSearch === false) {
- message.warning(t('search.chooseDataset'));
- return;
- }
- setIsSearching(!isSearching);
- }}
+ onClick={handleStartSearch}
>
<Search size={18} />
</button>