Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(paddleocr): handle submit request creation errors (#21839)

adwsc24b3b15cb90
diff --git a/internal/entity/models/paddleocr.go b/internal/entity/models/paddleocr.go
index c8ddf1cd0f..2b45811baf 100644
--- a/internal/entity/models/paddleocr.go
+++ b/internal/entity/models/paddleocr.go
@@ -157,6 +157,9 @@ func (p *PaddleOCRModel) OCRFile(ctx context.Context, modelName *string, content
return nil, fmt.Errorf("failed to marshal json: %w", err)
}
req, err = http.NewRequestWithContext(ctx, "POST", url, bytes.NewBuffer(jsonData))
+ if err != nil {
+ return nil, fmt.Errorf("failed to create submit request: %w", err)
+ }
req.Header.Set("Content-Type", "application/json")
} else {
body := &bytes.Buffer{}
@@ -173,6 +176,9 @@ func (p *PaddleOCRModel) OCRFile(ctx context.Context, modelName *string, content
writer.Close()
req, err = http.NewRequestWithContext(ctx, "POST", url, body)
+ if err != nil {
+ return nil, fmt.Errorf("failed to create submit request: %w", err)
+ }
req.Header.Set("Content-Type", writer.FormDataContentType())
}
diff --git a/internal/entity/models/paddleocr_test.go b/internal/entity/models/paddleocr_test.go
index 8e409d25aa..3371168733 100644
--- a/internal/entity/models/paddleocr_test.go
+++ b/internal/entity/models/paddleocr_test.go
@@ -3,9 +3,11 @@ package models
import (
"context"
"encoding/json"
+ "errors"
"fmt"
"net/http"
"net/http/httptest"
+ "net/url"
"os"
"strings"
"testing"
@@ -281,6 +283,39 @@ func TestPaddleOCRResolvedAPIConfig(t *testing.T) {
})
}
+func TestPaddleOCRModelOCRFileRejectsInvalidEndpoint(t *testing.T) {
+ for _, tc := range []struct {
+ name string
+ fileURL *string
+ }{
+ {name: "multipart upload"},
+ {name: "file URL", fileURL: ptr("https://files.example/document.pdf")},
+ } {
+ t.Run(tc.name, func(t *testing.T) {
+ defer func() {
+ if panicValue := recover(); panicValue != nil {
+ t.Fatalf("OCRFile panicked for invalid endpoint: %v", panicValue)
+ }
+ }()
+
+ driver := NewPaddleOCRModel(nil, URLSuffix{OCR: "v2/ocr/jobs"})
+ baseURL := "https://ocr.example/%zz"
+ modelName := "PaddleOCR-VL-1.6"
+ response, err := driver.OCRFile(t.Context(), &modelName, []byte("%PDF-1.4"), tc.fileURL, &APIConfig{BaseURL: &baseURL}, nil, nil)
+ if response != nil {
+ t.Fatalf("OCRFile response = %+v, want nil", response)
+ }
+ if err == nil || !strings.Contains(err.Error(), "failed to create submit request") {
+ t.Fatalf("OCRFile error = %v, want submit request creation error", err)
+ }
+ var escapeErr url.EscapeError
+ if !errors.As(err, &escapeErr) {
+ t.Fatalf("OCRFile error = %v, want wrapped URL escape error", err)
+ }
+ })
+ }
+}
+
// TestPaddleOCRModelOCRFileUnwrapsAPIKeyPayload pins the layering contract the
// cloud driver owns: OCRFile receives the tenant api_key JSON payload verbatim
// and resolves the bearer token and server endpoint itself, mirroring Python's