Skip to content

RAGFlow is an agent-native database: a Retrieval-Augmented Generation (RAG) engine that grew into context infrastructure.

fix(agent/tool): compare hostnames case-insensitively in DoPinned guard (#21171)

xugangqiangd7ecac5965ee
diff --git a/internal/agent/tool/http_helper.go b/internal/agent/tool/http_helper.go
index 5a9386ca33..e53db38b7f 100644
--- a/internal/agent/tool/http_helper.go
+++ b/internal/agent/tool/http_helper.go
@@ -31,6 +31,7 @@ import (
"net"
"net/http"
neturl "net/url"
+ "strings"
"time"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
@@ -205,7 +206,7 @@ func (h *HTTPHelper) DoPinned(
if err != nil {
return nil, fmt.Errorf("http_helper: parse url: %w", err)
}
- if u.Hostname() != originalHost {
+ if !strings.EqualFold(u.Hostname(), originalHost) {
return nil, fmt.Errorf(
"http_helper: DoPinned url host %q != originalHost %q "+
"(refusing to pin — would break TLS SNI / cert check)",
diff --git a/internal/agent/tool/http_helper_test.go b/internal/agent/tool/http_helper_test.go
index 81882916f9..6c8d238669 100644
--- a/internal/agent/tool/http_helper_test.go
+++ b/internal/agent/tool/http_helper_test.go
@@ -491,6 +491,50 @@ func TestHTTPHelper_DoPinnedRefusesMismatchedURLHost(t *testing.T) {
}
}
+// TestHTTPHelper_DoPinnedAcceptsCaseInsensitiveHost locks in that the
+// DoPinned host guard is case-insensitive. DNS hostnames are
+// case-insensitive, so a URL host spelled with a different case than
+// originalHost (e.g. a user-typed "EXAMPLE.TEST" vs the resolver's
+// lowercased "example.test") must still be pinned and delivered, not
+// refused. A genuinely different host is still refused by
+// TestHTTPHelper_DoPinnedRefusesMismatchedURLHost.
+func TestHTTPHelper_DoPinnedAcceptsCaseInsensitiveHost(t *testing.T) {
+ t.Parallel()
+ ctx := t.Context()
+
+ srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ _, _ = io.WriteString(w, "ok")
+ }))
+ defer srv.Close()
+
+ u, perr := neturl.Parse(srv.URL)
+ if perr != nil {
+ t.Fatalf("parse server URL %q: %v", srv.URL, perr)
+ }
+ serverHost, serverPort, sperr := net.SplitHostPort(u.Host)
+ if sperr != nil {
+ t.Fatalf("split server host:port from %q: %v", u.Host, sperr)
+ }
+ // URL host is UPPER-case; originalHost (as a resolver would record
+ // it) is lower-case — DNS-equivalent, so the pin must proceed.
+ targetURL := fmt.Sprintf("http://EXAMPLE.TEST:%s/", serverPort)
+ pinnedIP := net.ParseIP(serverHost)
+ if pinnedIP == nil {
+ t.Fatalf("server host %q is not an IP literal", serverHost)
+ }
+
+ h := NewHTTPHelper()
+ resp, err := h.DoPinned(ctx,
+ http.MethodGet, targetURL, "", "", nil, "example.test", pinnedIP)
+ if err != nil {
+ t.Fatalf("DoPinned rejected case-insensitive equivalent host: %v", err)
+ }
+ defer resp.Body.Close()
+ if resp.StatusCode != http.StatusOK {
+ t.Fatalf("status = %d, want 200", resp.StatusCode)
+ }
+}
+
// TestHTTPHelper_DoPinnedBypassesProxy locks in the proxy bypass
// added after the post-Phase-7 review: even when baseTransport.Proxy
// is set (e.g. via HTTP_PROXY / HTTPS_PROXY env), DoPinned must NOT